From: Tengfei Fan <quic_tengfan@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: <kernel@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] dt-bindings: arm: qcom: Document QCS9100 compatible
Date: Wed, 7 Aug 2024 17:14:54 +0800 [thread overview]
Message-ID: <773dc5b5-a537-4e6d-8e71-d2cb405c98fd@quicinc.com> (raw)
In-Reply-To: <3020262e-f3b2-4921-b33b-8d0d7babf36a@kernel.org>
On 8/7/2024 3:27 PM, Krzysztof Kozlowski wrote:
> On 06/08/2024 06:19, Tengfei Fan wrote:
>> Add the compatible for QCS9100 SoC.
>
> Standard reply: we see that from the diff. Oh wait, no! The diff is
> doing something entirely else.
>
> You do much more - change SA8775p bindings.
>
> Commit msg should say why you are doing such invasive change.
>
> Best regards,
> Krzysztof
>
I will explain the reason why change SA8775p bindings for support
QCS9100 in the commit message of the next version patch series.
--
Thx and BRs,
Tengfei Fan
next prev parent reply other threads:[~2024-08-07 9:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 4:19 [PATCH 0/4] soc: qcom: Add QCS9100 SoC ID and compatible support Tengfei Fan
2024-08-06 4:19 ` [PATCH 1/4] dt-bindings: arm: qcom,ids: add SoC ID for QCS9100 Tengfei Fan
2024-08-07 7:26 ` Krzysztof Kozlowski
2024-08-06 4:19 ` [PATCH 2/4] soc: qcom: socinfo: add QCS9100 ID Tengfei Fan
2024-08-07 7:26 ` Krzysztof Kozlowski
2024-08-06 4:19 ` [PATCH 3/4] dt-bindings: arm: qcom: Document QCS9100 compatible Tengfei Fan
2024-08-07 7:27 ` Krzysztof Kozlowski
2024-08-07 9:14 ` Tengfei Fan [this message]
2024-08-06 4:19 ` [PATCH 4/4] arm64: dts: qcom: sa8775p-ride: Add " Tengfei Fan
2024-08-07 7:28 ` Krzysztof Kozlowski
2024-08-07 9:17 ` Tengfei Fan
2024-08-07 9:35 ` Krzysztof Kozlowski
2024-08-07 11:04 ` Tingwei Zhang
2024-08-08 11:05 ` Krzysztof Kozlowski
2024-08-12 2:16 ` Tingwei Zhang
2024-08-12 6:15 ` Krzysztof Kozlowski
2024-08-12 7:07 ` Tingwei Zhang
2024-08-13 8:34 ` Krzysztof Kozlowski
2024-08-13 8:59 ` Aiqun Yu (Maria)
2024-08-19 11:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=773dc5b5-a537-4e6d-8e71-d2cb405c98fd@quicinc.com \
--to=quic_tengfan@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox