From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/10] ARM: dts: qcom: ipq8064: drop invalid GCC thermal-sensor unit-address
Date: Thu, 20 Apr 2023 12:48:06 +0200 [thread overview]
Message-ID: <776bb753-6302-b140-ab8d-fe6fb1b0bcf8@linaro.org> (raw)
In-Reply-To: <20230420075053.41976-5-krzysztof.kozlowski@linaro.org>
On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> GCC comes with syscon compatible so the thermal-sensor child node should
> not have unit-address (bindings also do not expect it):
>
> Warning (unit_address_vs_reg): /soc/clock-controller@900000/thermal-sensor@900000: node has a unit name, but no reg or ranges property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index 182018d79a7b..49310520da1c 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -522,7 +522,7 @@ gcc: clock-controller@900000 {
> #reset-cells = <1>;
> #power-domain-cells = <1>;
>
> - tsens: thermal-sensor@900000 {
> + tsens: thermal-sensor {
> compatible = "qcom,ipq8064-tsens";
>
> nvmem-cells = <&tsens_calib>, <&tsens_calib_backup>;
next prev parent reply other threads:[~2023-04-20 10:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 7:50 [PATCH 01/10] ARM: dts: qcom: ipq4019: correct syscon unit-address Krzysztof Kozlowski
2023-04-20 7:50 ` [PATCH 02/10] ARM: dts: qcom: sdx55: correct rsc unit-address Krzysztof Kozlowski
2023-04-20 10:45 ` Konrad Dybcio
2023-04-20 7:50 ` [PATCH 03/10] ARM: dts: qcom: msm8974: correct pronto unit-address Krzysztof Kozlowski
2023-04-20 10:46 ` Konrad Dybcio
2023-04-20 7:50 ` [PATCH 04/10] ARM: dts: qcom: ipq8064: drop leading 0 from unit-address Krzysztof Kozlowski
2023-04-20 10:46 ` Konrad Dybcio
2023-04-20 7:50 ` [PATCH 05/10] ARM: dts: qcom: ipq8064: drop invalid GCC thermal-sensor unit-address Krzysztof Kozlowski
2023-04-20 10:48 ` Konrad Dybcio [this message]
2023-04-20 7:50 ` [PATCH 06/10] ARM: dts: qcom: ipq8064: correct LED node names Krzysztof Kozlowski
2023-04-20 10:48 ` Konrad Dybcio
2023-04-20 7:50 ` [PATCH 07/10] ARM: dts: qcom: ipq8064: align USB node names with bindings Krzysztof Kozlowski
2023-04-20 10:48 ` Konrad Dybcio
2023-04-20 7:50 ` [PATCH 08/10] ARM: dts: qcom: apq8060-dragonboard: move regulators out of simple-bus Krzysztof Kozlowski
2023-04-20 10:49 ` Konrad Dybcio
2023-04-20 7:50 ` [PATCH 09/10] ARM: dts: qcom: msm8960-cdp: move regulator " Krzysztof Kozlowski
2023-04-20 10:49 ` Konrad Dybcio
2023-04-20 7:50 ` [PATCH 10/10] ARM: dts: qcom: apq8084: correct thermal sensor unit-address Krzysztof Kozlowski
2023-04-20 10:50 ` Konrad Dybcio
2023-04-20 10:45 ` [PATCH 01/10] ARM: dts: qcom: ipq4019: correct syscon unit-address Konrad Dybcio
2023-05-25 4:54 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=776bb753-6302-b140-ab8d-fe6fb1b0bcf8@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox