From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F0F52DF137 for ; Mon, 11 May 2026 06:36:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778481392; cv=none; b=C5qOzMKXbfffsLMqevUSJatHoe2md9tmYVRSM66+ogxCmyZde56ms9m6ojk4oI0SILBIVxqOOmNIgYbX00MjBTu0hTLWA1vs7AHuUBRbvtRtHJgX8ijYIngXR9Vtv3xE9hCpQ8H/hS4W9gAh13Vsc6n4jmWtLhUaz0P3ketiyqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778481392; c=relaxed/simple; bh=lZbRbAh+DVTE8ujkY7JeZBiPbcfbY8lNdmMSt/Ya6Uc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YvfJChaTVOoC68aEac7WR9EvVdcLJzj/oJ2FwL73s4mv8Ku29uQ9U39RCsYdahpZH6bIQa+oC4wOXGedHdoxjJzxMqbbwQ+ySj9ogjIWqMZTH98lUMzlgnrvh6A/7kpT7wcmWnDlTrJLWDr2purEga1W/bFTAH3CkvZTzJZbwUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RB6Cjpn1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H+XTCNqf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RB6Cjpn1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H+XTCNqf" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64ALco2H2095054 for ; Mon, 11 May 2026 06:36:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LSef7RQI0F2G/1yBQohbBWlriTMuEBGlgqLIUB16uHI=; b=RB6Cjpn1eJY8kw5p ZboJC02bz7VBu6IlxSk0J/7NtKWeFfuo2WxNMQz2eotVtn/sAPETnKT3mmVjOhqq 2w8OD129WJ+Vw9+0F/FT2Y7H6ewjj14SyIUhoKST9lC3yrna0mFeqrWSGmlMYSeo fcOGyq9saLghWvikkjM4YvAcKMItyy4c4Q09YRVhq9mPwYw+LfIDb1Yr59qSdpXi lwXcCjyMu+Z8Xtbe1QrhKvdF02IcFs4mj+Spbnj2x0HnwHx0gnNCyWWmbnIZyrs8 tTtUe7JZITFyPxblgNFTH/zkHZwlnIfDBswcIuFZ4ijQ6FXyvkuizQ0wvcpuhFFL qiVyuQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1ux6vvt1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 11 May 2026 06:36:29 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-36781927b4dso4202631a91.0 for ; Sun, 10 May 2026 23:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778481388; x=1779086188; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LSef7RQI0F2G/1yBQohbBWlriTMuEBGlgqLIUB16uHI=; b=H+XTCNqfrGxiwjM8PCHM+DVsOqiYwwRLxKm7MAlhPdyyPSeLTaOGi7rrLaL9fKPBsG j4TMDs0+QsSolzqugJR3NOTCNrTmMxOy3taZNIbbDig1Lvit+AHdIuK3ST4v8HP6fgFN PbbGYmhn8Pg4lpkpcRGBE+TtocD6TuwGYOzFUCLX0zh3AWx++lhVJBBw72q3mwRc3ern apT5+F57sgVajvy1a+XL38ipyufbF8rhnPEh+R3LTpp0boLyAV+DSZzbbfzldYhApz42 yjStT9/31JxIqQE4mlPvlJk1iImIBNJ0AEiFNjD60yTk7SYDovezQQ30RwFAhqZiOJD9 Ffig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778481388; x=1779086188; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LSef7RQI0F2G/1yBQohbBWlriTMuEBGlgqLIUB16uHI=; b=Kx4k+WwrA06MeA8OX078XTadxKUa7PiQFn7Cd2z9U7WMsrNlW9lVRqoV5FSeWtv/De dahbuOLo/Umh+5hs2dJsxi/00m7q5qSx5Jvuj42+ymLMUeSEYpdVk24uPSUGPS6oV584 KleewXkEBz8nHdx2OsHVY6MqumCOrQdqUKn76Fe0izYkwiy0vSeG4bf9oy7qe3xCv7Iw +XVFlrNALih77WBRXLhPUywJEeiEoeUAMDuY84CTaeWHti02fmF/bmt2zM4JlZSawrxV pAa+W7RlgOnytxEV9oZAbuamhCCJksVfexuZ15iiJD8gocgDKw1KpSyMV8wmRdRYYswa 3m0Q== X-Forwarded-Encrypted: i=1; AFNElJ8EaqvogbUP48L6h6U8DRfUaoAYjfxf+YG2xZ4yizOCYzNfZsNOGp4+fPm1oHQCB/dySIQN4fRIzO0GkzT8@vger.kernel.org X-Gm-Message-State: AOJu0YwIVaDt+R0DC5IcPCnbYI0PmtLD5RqVoIgWgHVrKsf9NgZ+Rbgs O+GnXuYhQA4gytbmkDsIvaJVZIwqBM6TmsydBPhbD8fm/8dkEmrRteNef6JI7wkTZ3fSZcAHD8p CV11Z5vC2qbrS687mhj3Pi2jQTmaVeY8qfZws2XfZStoBIWa+Wcp2279zSyGVRDCQ5XrF X-Gm-Gg: Acq92OERcB4bJFuKdV86OGeLBRuxfu9neYh/8LtnoFEfGh1qDNsb3rJjhsA8AYwCOXf p9LNRifuLljk35MKZKPaNJkU8RDYsxxO35m9iPK+hk9sWRrScOVjpP8aSo0Xdgl21anDeV5LJ/h NcrVCuFdyTKeH5G13FSRbTMflLRvbFEOWsfEc96cPwHioOWXSI6WF7PyIIuSF/jnMREvIvlbruE +udZdvbwnO4cB79r5gYXWCRrgEAqMNuVP326Vt6sAAYIwSxh3K7ddOVBIbtVeLKn+B2uwce07uS C9LGLCoVRnaGkD0Tknc2ZoHhJ25+1w+accwTGYqBJoV4XRlvkE6WBFPrF2pdBtD+LD2ssK0bn+I pm5E9GqUk6l6YIDu2SRS5c3IForVoAf8h2998mDKPDVpwcRl/D0L4eQ== X-Received: by 2002:a17:90a:d60d:b0:365:7e4d:bcb8 with SMTP id 98e67ed59e1d1-365ab9afa3fmr22776112a91.1.1778481388258; Sun, 10 May 2026 23:36:28 -0700 (PDT) X-Received: by 2002:a17:90a:d60d:b0:365:7e4d:bcb8 with SMTP id 98e67ed59e1d1-365ab9afa3fmr22776097a91.1.1778481387790; Sun, 10 May 2026 23:36:27 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-367be23b331sm3347418a91.1.2026.05.10.23.36.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 May 2026 23:36:27 -0700 (PDT) Message-ID: <77922d17-69c8-2710-d206-3d2f37651310@oss.qualcomm.com> Date: Mon, 11 May 2026 12:06:21 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 03/16] media: iris: Introduce set_preset_register as a vpu_op Content-Language: en-US To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal References: <20260507-iris-ar50lt-v1-0-d22cccedc3e2@oss.qualcomm.com> <20260507-iris-ar50lt-v1-3-d22cccedc3e2@oss.qualcomm.com> From: Vishnu Reddy In-Reply-To: <20260507-iris-ar50lt-v1-3-d22cccedc3e2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTExMDA3MSBTYWx0ZWRfX1cpIaungtdfH RChjiv9gf+zVlq0uvJg7AXKo2JcnxtOzAHg6ThGGdb0tYzRMGSNhTOH3/JByjkpD9Ys1xfuKs4j adep+to3Mh2DUQsr8wjAdzWtMgHpZudBEBD1PYmruTkjPRo/2UXTp4y61xin4OD+oFHuWljqUxJ fPrd6pAvJ6cOnk3hGl0PksN8dxm99qb/5tS3aOHWtlNYuZPqnKBBs7Mq5w3foeXgKnAtJzki/7N sy1nvqFcbuRuntSHK30DMqiBNEh6SFgnqDMkAC8x4fB/QGalj5ehjSUiCSD3ukpeeCSHTnTTRsn ZdjeRx15DeekmQvzb+0uSJK9QFFUVVzM8B/FtWib0gcM6X+rFjVtEWRg1iTYkS3b1DdoTa1rMTo nrHgMAumfxS8AzYNy0CRW2oF/rBYX5h7/HP5K2csq837LlLbrj8SJKv13DKYAAnkCCZi43Nv4Dj JjpjoG8S6zcHNaJ4GQw== X-Authority-Analysis: v=2.4 cv=QJZYgALL c=1 sm=1 tr=0 ts=6a0178ed cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=h5up4yhgnEjzzxj5UEEA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: VkLqmseHaBWde1rhXlrZoNq-K6mHHPkW X-Proofpoint-GUID: VkLqmseHaBWde1rhXlrZoNq-K6mHHPkW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_02,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605110071 On 5/7/2026 12:12 PM, Dmitry Baryshkov wrote: > diff --git a/drivers/media/platform/qcom/iris/iris_vpu4x.c b/drivers/media/platform/qcom/iris/iris_vpu4x.c > index 02e100a4045f..f608a297d4a3 100644 > --- a/drivers/media/platform/qcom/iris/iris_vpu4x.c > +++ b/drivers/media/platform/qcom/iris/iris_vpu4x.c > @@ -368,4 +368,5 @@ const struct vpu_ops iris_vpu4x_ops = { > .program_bootup_registers = iris_vpu35_vpu4x_program_bootup_registers, > .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, > .set_hwmode = iris_vpu4x_set_hwmode, > + .set_preset_registers = iris_vpu_set_preset_registers, > }; > diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c > index 7bba3b6209c2..ff0070c85ccf 100644 > --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c > +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c > @@ -472,7 +472,7 @@ int iris_vpu_power_on(struct iris_core *core) > > iris_opp_set_rate(core->dev, freq); > > - iris_vpu_set_preset_registers(core); > + core->iris_platform_data->vpu_ops->set_preset_registers(core); > > iris_vpu_interrupt_init(core); > core->intr_status = 0; > diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.h b/drivers/media/platform/qcom/iris/iris_vpu_common.h > index 09799a375c14..21ed4c9bd5e3 100644 > --- a/drivers/media/platform/qcom/iris/iris_vpu_common.h > +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.h > @@ -22,6 +22,7 @@ struct vpu_ops { > void (*program_bootup_registers)(struct iris_core *core); > u64 (*calc_freq)(struct iris_inst *inst, size_t data_size); > int (*set_hwmode)(struct iris_core *core); > + void (*set_preset_registers)(struct iris_core *core); > }; > > int iris_vpu_boot_firmware(struct iris_core *core); Reviewed-by: Vishnu Reddy