From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EE2F2AE8E for ; Mon, 4 Aug 2025 12:49:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754311800; cv=none; b=imdmC1EIPEdIZliR0kmG9ZJB6LPV0v/mKZGllrBlsd8qNx+6B6LX2rVOk5vzVOiCanO8b/41piZDEcQEeZuUr7mfCqXbmjyV4AkyrrcbN77y5yIXHtdHcPLlXJQuO3LTJ6eXSDyyaatoZa2vhpae5pInO4QURX6dt17I5TxgCw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754311800; c=relaxed/simple; bh=cc9bDQvvEzApY/ZAQ1QmRe/Rk3TKihq9tFViG1dVIrU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WM1SapNFYFaTEyu9IQ4EtFmB0yFSa/6klfUyfxNWiqSj9qV0jQjona7GbYZME/ycpRG+InPh1zD7lyKV9uSG8q8zf21RVJ/VTkoQHqWGyovDnquK7JMlktna45KnM+UhWQyXaT/NsqzVBSqPG0uzHMcqNu5lXUW99DHTl2AsAd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TgV00bXK; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TgV00bXK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754311798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+Xhhf7HOlGHP/+Ew73mE+84gy9qClegxqAGKGx6kZAE=; b=TgV00bXK9aPS6j5TcKnUxRcbB7nBAcRAjkKTQd2BqJpTh1z1Qv70ogjpKF5RyUFN5XjD7/ kfW13qm+qBCIstnIHh7uvoqutw+4IWoW96asL3mi+Hd1xJraHD13rEM0wu1FAP5V21Vcul m0GeU1BUSLVlj+dLf7hcf5YTZvjM1tQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-93-ittC6c9MMfSUIEpOQXIONQ-1; Mon, 04 Aug 2025 08:49:56 -0400 X-MC-Unique: ittC6c9MMfSUIEpOQXIONQ-1 X-Mimecast-MFC-AGG-ID: ittC6c9MMfSUIEpOQXIONQ_1754311796 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3b78b88ecfeso1253376f8f.3 for ; Mon, 04 Aug 2025 05:49:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754311795; x=1754916595; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+Xhhf7HOlGHP/+Ew73mE+84gy9qClegxqAGKGx6kZAE=; b=hk0dfVGazfpAOT0d+ueiBvqIFEtFJjowStKuAEu278X8aQWqN8uTB2A18kaBqlpsGj 8gATPUzPQLIotaF0v8wKJ21ukgZolrHjVsZiGy3FLN+hLMlwEKmnDjGv4A0bG0jpRCMj r161+SF5CDTYlKya/O/inN1gf4F4tHJGN7/pJ74RR3kelWLB5Va10zHav1iGLYOWm/Jv BNCz+P7YOVmbNrbgzaI0zP8kIvmb7R04dEPFq8sBLku7cFjavONANQII6tj5exVuPmKo hDmABc49K+dqBfojrOBQIsyDCcnr1EjQid3nwXtMoThH+ilhZOaABS6HVDAxj4I3EwRp 2fww== X-Forwarded-Encrypted: i=1; AJvYcCVZwE0kHbV8DGEDyPgbloWSoLkmCFaKFIlrd4VPvbAJjti+Y+RMVlZY9hFq6uU6D6eG+MK3//fuNdjpftPX@vger.kernel.org X-Gm-Message-State: AOJu0YzWVPDUCDtBo9YpdZPeG+noGtB/NJj7O3M+Vpehh0rd4EF1kq0q Kua2TJFb2t520lkOllXlmhO/Ym8Fgft6c44O1+Q84jqZCQL0Gv4wrhBWxsQ7y75BcCsHe3CaD15 IU+tDqStjTA1Za/9xvNH8fcbPkhdRqyE58EcgvGAHmgGSAHvs9eCVIyYfUPjSJeufsOk= X-Gm-Gg: ASbGnctY7DtSTGhCFMVEZ1JtIE862Rg3FAEMl+AL0M+qClzBKTgGwg4yelpFkkeVJtq pL9acQWBgYLkWnk7xF9MIpTAEKLJ5OKoOBS8Za5d9DA8I0fUrj6qVki/A7rDUJDPVKIVvb8sxyF e6HEuADlq+gTbJvXEEuARxYbLnoAS/OEvRzNDFCa0Fx7x2WAXDK9KAJbEOTCs1dS7pkPN6pdSax xWRP8T4ED55HTFrkmrX61zFZMWg7JylD+SxqJBX8EemMsBnkwSGGgLWWV+g3kX7Psa6o6Obyc6C F1v/Y3oJeX7nWhhK7LO5wXp/BE/Oxl7vSq/0TwYCLiKL6McH49xXfQiO8KeD3e7SMzREeerigeq 3MZx1GUqOsBdHGogN4hSn7ChJiWSdEsT5uiH9Ge7h9joyPE9evql+eYq5vAevBgSidHk= X-Received: by 2002:a5d:584c:0:b0:3a6:ec1d:1cba with SMTP id ffacd0b85a97d-3b8d947083emr7216530f8f.20.1754311795532; Mon, 04 Aug 2025 05:49:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHFXgDt/YpWGgP2V8sWDg7uI7r5JelqiIRnbxs/Y/QppAtTZ4vWQf600coJVI3Z9N9Z5dRAbg== X-Received: by 2002:a5d:584c:0:b0:3a6:ec1d:1cba with SMTP id ffacd0b85a97d-3b8d947083emr7216499f8f.20.1754311795008; Mon, 04 Aug 2025 05:49:55 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0e:2c00:d6bb:8859:fbbc:b8a9? (p200300d82f0e2c00d6bb8859fbbcb8a9.dip0.t-ipconnect.de. [2003:d8:2f0e:2c00:d6bb:8859:fbbc:b8a9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4589edf56e0sm169284285e9.1.2025.08.04.05.49.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Aug 2025 05:49:54 -0700 (PDT) Message-ID: <77d17dbf-1609-41b1-9244-488d2ce75b33@redhat.com> Date: Mon, 4 Aug 2025 14:49:53 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC][PATCH v2 22/29] mm/numa: Register information into Kmemdump To: Eugen Hristev , Michal Hocko Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, andersson@kernel.org, pmladek@suse.com, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, corbet@lwn.net, mojha@qti.qualcomm.com, rostedt@goodmis.org, jonechou@google.com, tudor.ambarus@linaro.org References: <20250724135512.518487-1-eugen.hristev@linaro.org> <20250724135512.518487-23-eugen.hristev@linaro.org> <751514db-9e03-4cf3-bd3e-124b201bdb94@redhat.com> <23e7ec80-622e-4d33-a766-312c1213e56b@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04.08.25 14:29, Eugen Hristev wrote: > > > On 8/4/25 15:18, David Hildenbrand wrote: >> On 04.08.25 13:06, Eugen Hristev wrote: >>> >>> >>> On 8/4/25 13:54, Michal Hocko wrote: >>>> On Wed 30-07-25 16:04:28, David Hildenbrand wrote: >>>>> On 30.07.25 15:57, Eugen Hristev wrote: >>>> [...] >>>>>> Yes, registering after is also an option. Initially this is how I >>>>>> designed the kmemdump API, I also had in mind to add a flag, but, after >>>>>> discussing with Thomas Gleixner, he came up with the macro wrapper idea >>>>>> here: >>>>>> https://lore.kernel.org/lkml/87ikkzpcup.ffs@tglx/ >>>>>> Do you think we can continue that discussion , or maybe start it here ? >>>>> >>>>> Yeah, I don't like that, but I can see how we ended up here. >>>>> >>>>> I also don't quite like the idea that we must encode here what to include in >>>>> a dump and what not ... >>>>> >>>>> For the vmcore we construct it at runtime in crash_save_vmcoreinfo_init(), >>>>> where we e.g., have >>>>> >>>>> VMCOREINFO_STRUCT_SIZE(pglist_data); >>>>> >>>>> Could we similar have some place where we construct what to dump similarly, >>>>> just not using the current values, but the memory ranges? >>>> >>>> All those symbols are part of kallsyms, right? Can we just use kallsyms >>>> infrastructure and a list of symbols to get what we need from there? >>>> >>>> In other words the list of symbols to be completely external to the code >>>> that is defining them? >>> >>> Some static symbols are indeed part of kallsyms. But some symbols are >>> not exported, for example patch 20/29, where printk related symbols are >>> not to be exported. Another example is with static variables, like in >>> patch 17/29 , not exported as symbols, but required for the dump. >>> Dynamic memory regions are not have to also be considered, have a look >>> for example at patch 23/29 , where dynamically allocated memory needs to >>> be registered. >>> >>> Do you think that I should move all kallsyms related symbols annotation >>> into a separate place and keep it for the static/dynamic regions in place ? >> >> If you want to use a symbol from kmemdump, then make that symbol >> available to kmemdump. > > That's what I am doing, registering symbols with kmemdump. > Maybe I do not understand what you mean, do you have any suggestion for > the static variables case (symbols not exported) ? Let's use patch #20 as example: What I am thinking is that you would not include "linux/kmemdump.h" and not leak all of that KMEMDUMP_ stuff in all these files/subsystems that couldn't less about kmemdump. Instead of doing static struct printk_ringbuffer printk_rb_dynamic; You'd do struct printk_ringbuffer printk_rb_dynamic; and have it in some header file, from where kmemdump could lookup the address. So you move the logic of what goes into a dump from the subsystems to the kmemdump core. -- Cheers, David / dhildenb