From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCD7C433DB for ; Fri, 12 Mar 2021 13:04:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D39764FFD for ; Fri, 12 Mar 2021 13:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231779AbhCLNEL (ORCPT ); Fri, 12 Mar 2021 08:04:11 -0500 Received: from z11.mailgun.us ([104.130.96.11]:39370 "EHLO z11.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231789AbhCLNDn (ORCPT ); Fri, 12 Mar 2021 08:03:43 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1615554223; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=2DQdQ4OuyMLLVtN9I86/vm9sES/GqmJNArWanvnHFiI=; b=pe4Hwe6wfVUQ7tqkOGkSHk/FI+CiLy4LlFFEZSXfZ/KhT56bN+eW/nFwF1dUH/06V5sNy/Vi soLuKvMM08mG4/aTh6MC5PBiqSIQTHe/HPK4riyJr0DrOqCOTZY4sORL9MndLwdv0eWkPKIt ZtaD3KepuuE4X2nfdUjQRAax4j0= X-Mailgun-Sending-Ip: 104.130.96.11 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 604b66646dc1045b7d8aebd5 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 12 Mar 2021 13:02:28 GMT Sender: srivasam=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 48B0BC433ED; Fri, 12 Mar 2021 13:02:27 +0000 (UTC) Received: from [192.168.29.24] (unknown [49.37.156.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: srivasam) by smtp.codeaurora.org (Postfix) with ESMTPSA id BA744C433C6; Fri, 12 Mar 2021 13:02:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BA744C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=srivasam@codeaurora.org Subject: Re: [PATCH v4 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver To: Doug Anderson Cc: gross@kernel.org, Bjorn Andersson , Rob Herring , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Rohit kumar , Srinivas Kandagatla , Stephen Boyd , Judy Hsiao , Ajit Pandey , V Sujith Kumar Reddy References: <20210311164815.14113-1-srivasam@codeaurora.org> <20210311164815.14113-2-srivasam@codeaurora.org> From: Srinivasa Rao Mandadapu Organization: Qualcomm India Private Limited. Message-ID: <7825f825-8b84-fda8-5884-e4f0ea4edf12@codeaurora.org> Date: Fri, 12 Mar 2021 18:32:20 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Doug, Thanks for your time!!! On 3/12/2021 1:26 AM, Doug Anderson wrote: > Hi, > > On Thu, Mar 11, 2021 at 8:49 AM Srinivasa Rao Mandadapu > wrote: >> From: Ajit Pandey >> >> Add dai link for supporting lpass I2S driver, which is used >> for audio capture and playback. >> Add lpass-cpu node with pin controls and i2s primary >> and secondary dai-links >> >> Signed-off-by: Ajit Pandey >> Signed-off-by: V Sujith Kumar Reddy >> Signed-off-by: Srinivasa Rao Mandadapu >> --- >> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 58 ++++++++++++++++++++ >> 1 file changed, 58 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> index 436582279dad..501e3d4c9097 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> @@ -9,6 +9,7 @@ >> #include >> #include >> #include >> +#include > It seems marginally better to include "sc7180-lpass.h" to get this? I > don't really know the difference between the two but since unless > we're planning to delete the sc7180 version it seems like you might as > well include that one? Yes, I agree. Recently, all Quallcomm variant headers are combined and created "qcom,lpass.h". "sc7180-lpass.h" still includes "qcom,lpass.h". So I will change and repost the patch. Here is the reference commit: > > >> /* PMICs depend on spmi_bus label and so must come after SoC */ >> #include "pm6150.dtsi" >> @@ -283,6 +284,42 @@ keyboard_backlight: keyboard-backlight { >> max-brightness = <1023>; >> }; >> }; >> + >> + sound: sound { >> + compatible = "google,sc7180-trogdor"; >> + model = "sc7180-rt5682-max98357a-1mic"; >> + >> + audio-routing = >> + "Headphone Jack", "HPOL", >> + "Headphone Jack", "HPOR"; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + dai-link@0 { >> + link-name = "MultiMedia0"; >> + reg = ; >> + cpu { >> + sound-dai = <&lpass_cpu MI2S_PRIMARY>; >> + }; >> + >> + codec { >> + sound-dai = <&alc5682 MI2S_PRIMARY>; > I'm an audio noob but isn't "MI2S_PRIMARY" something to be used with > "lpass_cpu", not with "alc5682" ? > > I have no idea what the IDs correspond to on "alc5682". Are you sure > we even need an extra ID there? The "alc5682" bindings upstream don't > talk anything about dai-cells, but maybe they're just wrong... Yes. I will change and re-post. > > -Doug -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.