From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DBA0C6FD1F for ; Sat, 11 Mar 2023 12:36:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230419AbjCKMgZ (ORCPT ); Sat, 11 Mar 2023 07:36:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230407AbjCKMgX (ORCPT ); Sat, 11 Mar 2023 07:36:23 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE8C713594E for ; Sat, 11 Mar 2023 04:36:20 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id b10so8134638ljr.0 for ; Sat, 11 Mar 2023 04:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678538179; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KKq3UOpgcv7dOjJn1dLmGbzJrysgGQToZlLkm4HZwEM=; b=qKCvLXh9ll4O56c35waq5CaCZiYyzPaT1tUcmskQ2WY0vgP4hqZShds5KJuyzcqM5R ski3PHKV5m0/9L9j+6S/Hpxmv0Q6gC74B3Dlv3/grBvgVYHtUoGrw6u4iO50MFx7vYP+ xfumzyPb1RAGUY3363xjvwGQl1BelEipSLuz+PyDwQL+rtEoB76IayGSzX73Uy0aJtQe sjznDdRGylB5raA/wYwbpxuacLnwVo+o21feJrc2d224SY+s3hCJWFiJJdrCMSfpVA+q kP0vMxSBcqH+tG16VEZkffjdesoW+8trwuiF+nMi3kyMspVy8CECbuRhH7JLqXy7UtGz fiAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678538179; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KKq3UOpgcv7dOjJn1dLmGbzJrysgGQToZlLkm4HZwEM=; b=VYjVA59fZhMPJ9Rrxg38/QccS98eWmReAlWL1uUz2tQhG66+pKMlGAmtWObHJIUA7h 2Km9PdrruE8U5TKsh16NHCz59zWkWyJXRhdH3N2OEQbhDQIAqg7AdfJlrIttxAS2Evg+ dk7BrzB0TTwrhWV2jzLmara7I6kQ69isY0Qc6CxIFxkI0M9RwwL55bij/BK+/D9R+geF ppF2LSn8JjBY9OY6u3CLfigdIA371tj/2lkGmYcigABbSmTRJx27YuvQTbzAAOUxk17y ewJLSBrsSvZy9yCOE+pkdPUwIwjZtOkqG1W4xs4w9BqqqZmrqHyJ6CjPHxxyAs08yazJ +NXg== X-Gm-Message-State: AO0yUKWcEmHqr9Lj17i9w50267cBUreXyxuB/dVhsKyAberBoR2PjK9e 23oipMwBdvX5B0tvmaAsvCvSPw== X-Google-Smtp-Source: AK7set/ve/82/jh259j3jFvjcUtoMjtiSUrbwoxhf4whEIOVUxf5kgbZKOVor+py6YR0tXj2rx7FSA== X-Received: by 2002:a2e:9186:0:b0:295:c386:35f6 with SMTP id f6-20020a2e9186000000b00295c38635f6mr8354782ljg.44.1678538178981; Sat, 11 Mar 2023 04:36:18 -0800 (PST) Received: from [192.168.1.101] (abyj16.neoplus.adsl.tpnet.pl. [83.9.29.16]) by smtp.gmail.com with ESMTPSA id f4-20020a2ea0c4000000b002958bf18efcsm301025ljm.104.2023.03.11.04.36.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Mar 2023 04:36:18 -0800 (PST) Message-ID: <784d08ea-04a3-bbad-66e2-d19d98c0e5d7@linaro.org> Date: Sat, 11 Mar 2023 13:36:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v7 6/9] interconnect: qcom: rpm: Handle interface clocks Content-Language: en-US To: Bryan O'Donoghue , Andy Gross , Bjorn Andersson , Georgi Djakov , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230228-topic-qos-v7-0-815606092fff@linaro.org> <20230228-topic-qos-v7-6-815606092fff@linaro.org> <50f03895-816f-be8d-d956-d237fb13f5a0@linaro.org> <6d10906e-08cd-0380-5f5d-3ac0eec60276@linaro.org> <67590cd3-5543-59ed-6158-b272103ebd05@linaro.org> <858a8925-f11b-652d-3f02-f5ceea7d11fa@linaro.org> <74c0c724-b6a9-3755-7f56-9f421cece1a3@linaro.org> <500c7924-c43c-4233-1688-f8b6fbbad66f@linaro.org> <544e6f22-f2f4-2c7c-1978-a96c9763e2ab@linaro.org> From: Konrad Dybcio In-Reply-To: <544e6f22-f2f4-2c7c-1978-a96c9763e2ab@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 11.03.2023 13:11, Bryan O'Donoghue wrote: > On 11/03/2023 00:54, Konrad Dybcio wrote: >>> - Update the commit log and potentially the structure comments >> I'm probably just very biased because I authored these commits, but I can't >> see which part is not clear.. Could I (and this is not passive-aggressive or >> anything) ask for a pointer there? >> > > I mean to say "non scaling clocks" isn't an indicator IMO of the fact that these are QoS node specific clocks. > > Right now the interconnect model is predicated on bus and bus_a but, you've found that on some SoCs we have node-specific clocks too. > > :g/non\ scaling/s//non-scaling\ node-specific/g > > would do or "QoS node-specific" the fact the clocks don't scale is incidental the dependency though is that IMO at least these are additional node-specific clocks we need to enable. Okay that makes sense. Thanks. Konrad > > --- > bod