From: Krzysztof Kozlowski <krzk@kernel.org>
To: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Neeraj Soni <neeraj.soni@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v6 3/4] ufs: host: Add ICE clock scaling during UFS clock changes
Date: Wed, 25 Feb 2026 15:12:18 +0100 [thread overview]
Message-ID: <784d5711-3f3a-48af-ab1b-9a8834249445@kernel.org> (raw)
In-Reply-To: <aZ7x7gG0OZEQSKVy@hu-arakshit-hyd.qualcomm.com>
On 25/02/2026 13:58, Abhinaba Rakshit wrote:
> On Wed, Feb 25, 2026 at 10:00:12AM +0100, Krzysztof Kozlowski wrote:
>> On 19/02/2026 10:39, Abhinaba Rakshit wrote:
>>> Implement ICE (Inline Crypto Engine) clock scaling in sync with
>>> UFS controller clock scaling. This ensures that the ICE operates at
>>> an appropriate frequency when the UFS clocks are scaled up or down,
>>> improving performance and maintaining stability for crypto operations.
>>>
>>> Incase of OPP scaling is not supported by ICE, ensure to not prevent
>>> devfreq for UFS, as ICE OPP-table is optional.
>>>
>>> Acked-by: Manivannan Sadhasivam <mani@kernel.org>
>>> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
>>> ---
>>> drivers/ufs/host/ufs-qcom.c | 21 ++++++++++++++++++++-
>>
>>
>> SCSI/UFS is not respecting subsystem boundaries, thus you must not
>> combine multiple subsystem when targeting UFS.
>>
>> Please split your patches.
>
> Sorry, if I fail to understand the context here.
> This patch-series is already split into 4 patches based on the subsystem.
s/patches/patchset/
Please split the patchset to not combine independent patches targeting
different subsystem into one patchset.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-25 14:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 9:39 [PATCH v6 0/4] Enable ICE clock scaling Abhinaba Rakshit
2026-02-19 9:39 ` [PATCH v6 1/4] dt-bindings: crypto: ice: add operating-points-v2 property for QCOM ICE Abhinaba Rakshit
2026-02-28 8:57 ` Herbert Xu
2026-02-19 9:39 ` [PATCH v6 2/4] soc: qcom: ice: Add OPP-based clock scaling support for ICE Abhinaba Rakshit
2026-02-19 14:16 ` Konrad Dybcio
2026-02-20 7:37 ` Abhinaba Rakshit
2026-02-19 9:39 ` [PATCH v6 3/4] ufs: host: Add ICE clock scaling during UFS clock changes Abhinaba Rakshit
2026-02-25 9:00 ` Krzysztof Kozlowski
2026-02-25 12:58 ` Abhinaba Rakshit
2026-02-25 14:12 ` Krzysztof Kozlowski [this message]
2026-02-26 6:14 ` Abhinaba Rakshit
2026-02-26 6:40 ` Krzysztof Kozlowski
2026-02-26 6:55 ` Abhinaba Rakshit
2026-02-19 9:39 ` [PATCH v6 4/4] soc: qcom: ice: Set ICE clk to TURBO on probe Abhinaba Rakshit
2026-02-19 14:18 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=784d5711-3f3a-48af-ab1b-9a8834249445@kernel.org \
--to=krzk@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=abhinaba.rakshit@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neeraj.soni@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox