From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D230B26A1B5 for ; Mon, 16 Jun 2025 15:51:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750089118; cv=none; b=C9UoWxd/d0RcgnkNIgCVdbRRjIRUcFeFewL/+IdnaUU3KS0RUiylMoQMa0xcMY8+xxH7TXh8yQ/07yo+bSpRYVfC0YsapAFWOp+bnGw//D1/Jlwiba3/RvW51mUvaR6Yf3DARhIksfeZeiL5WTrxpXSSfUO/tOCoei69wiNQFN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750089118; c=relaxed/simple; bh=PV+hjbr1UcOA60DQPHguMD3wEZU4n+jwNG7/rCy7Fvw=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=gMxPr1STUs9sliEOWKk9kJxPBl45d5AGSXmKo+SYEgKdf89fXNdBbKtfRnz0FTZIvDdlUsfSr61TGet+KlN/+QWEuzGCU95z5tw2Pm/LOaPHJ5RqI2fpIfugQ6vLu5/WmBnV10LcOmmAb7vJtxoU1RtUgZtlYCKiqRuo/YP4e/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qP9peBEB; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qP9peBEB" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3a510432236so3449626f8f.0 for ; Mon, 16 Jun 2025 08:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750089114; x=1750693914; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=B3aIxTq8eP0LU6Js9V3eNq8kd450CZ0HrFoXlpXX77I=; b=qP9peBEBMe1KGRcqA2zIdj2HsKSyRbSk1mQcq3XOsTitKUjwVzCxGmucxHdWzHgdTI p7/dFsvy1ra2khZuSe7SJrEqxKDiU4/h7spvC3cZJKWqQir8XLr+/ywX+8INSPxvnkvy rzg4ezYwFahht/d1la+m16dI8mUcKLZMXBOvKFuqPvXNltFNvZreUTY+8EKuFs38Yodw /kKdddJWIUmhFEuiv0sfvIbivbKvUsTh/DnpjPUxquFpuGDKp7sl6OdQH0AiyPXw0v3V HbQRhoQwUcZLbcsyP6FSFf/78d+bNxWAggB9XCUy96/lts+UGCKDEC9NwbtZh5RFxYYQ zD/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750089114; x=1750693914; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=B3aIxTq8eP0LU6Js9V3eNq8kd450CZ0HrFoXlpXX77I=; b=gjZDjGxbRUQzCt31/C1bZe3oQBS91a3p1P3smOdFoBlS+X+OgojoGCT0LfEBEsrPiR QBY9f1qFhtGGaxa/kPaB529ye2zDyRbXRPjER/KRNhPhDffOUQRcdmRl7LYqpsA+lfxG Q+/kr68KsQgW3ZR8JDHfKuksovFWW2uyYluH1fd9u/dwgV7Vg0Tnn3glwFg7q6nTW+pt XXUZuXK9RsFXTEKnx/mmwKafcU6Imyy5lr0nzrxQeOb2bMBHZG3HWr0byUuiWorTmCPQ pZ0al6OWRc6IOZ0LPfdaInp87IG4KoXSeq3zoHWMpTvKtIxnodOALzUhTG0jzIEjMkNZ IA6A== X-Gm-Message-State: AOJu0Yyk+y/s6wub40rZ2gkuyRPIjYg9yOAiq3Wwc1Zukt5W7G8cyh6y fCb6GM8tpkpTAzppUyHiqmLQ2o6stYFXyRQkWDUAb5oD9ee5TBM1sip2cFVca+JH6rg= X-Gm-Gg: ASbGnctmRs1ubpImgI3qmnrDYodZVmLn3l2t4ZaQjWsEytzTFduA9szb0TkqafrpGgf eMKep/PtF4p54NMwuDm3vAV7hS/WWaZSrQ1PzzVHNjN+JpQa5Twa3L9wCzYXKf4OocJJLiu6Z1g yvKUuk6ZNiGoJWiW7KJVVrKljDutMC8mLGaJ0sAf4TD6zg1cqDN9Oyv6vOE8mB3cEsi0fm8rfBJ LwfPU9nLwtdmoOhvioMHS/wswvVYnwONHzEuaKogpWDTuWxSNR6b6UySpF1BIsmCrqCOrxx1mXW lMKDVXn61ZSYr2m++qZJDmP2EFiIFgSJjewUSWDtkNjxG8kvW/miT6YIMnwg3CAtn2dREyPOQTN bLLA1YR/raH+JUdHC2yBscoFtLyravLpyOpm8 X-Google-Smtp-Source: AGHT+IEj5cUnxUUFo+d8zqbumS2ayHNMbIjK7THuy3PbiLsuMDqskV06eRRHi2zveWUbvuEPOUaqXQ== X-Received: by 2002:a05:6000:4818:b0:3a5:2e59:833a with SMTP id ffacd0b85a97d-3a57238b9fcmr8023602f8f.1.1750089114107; Mon, 16 Jun 2025 08:51:54 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:6c7:97de:65a8:488a? ([2a01:e0a:3d9:2080:6c7:97de:65a8:488a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e224795sm150088105e9.7.2025.06.16.08.51.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jun 2025 08:51:53 -0700 (PDT) Message-ID: <786e3337-4c14-4281-932e-6a93aac53cf8@linaro.org> Date: Mon, 16 Jun 2025 17:51:53 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH 00/28] interconnect: qcom: icc-rpmh: use NULL-terminated arrays and drop static IDs To: Dmitry Baryshkov , Georgi Djakov , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250616-rework-icc-v1-0-bc1326294d71@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250616-rework-icc-v1-0-bc1326294d71@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 16/06/2025 02:28, Dmitry Baryshkov wrote: > Qualcomm interconnect code has been using .num_foo fields together with > the arrays embedded in the structure, which results in hard-to-notice > mistakes if .num_foo gets omitted or incorrect. > > Rework RPMh interconnect code to use NULL-terminated arrays for the > dynamic IDs case (as now all the arrays contain only pointers) and, > while we are at it, rework all the drivers to use dynamic IDs and drop > static IDs code. > > This series touches only RPMh interconnect drivers. Corresponding series > for RPM drivers will follow up shortly. Can you specify on which base thie patchset applies ? I tried v6.15, v6.16-rc1, v6.16-rc2, next-20250613 & next-20250616 and they all fail to apply on patch 5. Thanks, Neil > > Signed-off-by: Dmitry Baryshkov > --- > Dmitry Baryshkov (28): > interconnect: qcom: sc8280xp: specify num_links for qnm_a1noc_cfg > interconnect: qcom: sc8180x: specify num_nodes > interconnect: qcom: rpmh: make nodes a NULL_terminated array > interconnect: qcom: rpmh: make link_nodes a NULL_terminated array > interconnect: qcom: sc7280: convert to dynamic IDs > interconnect: qcom: sc8180x: convert to dynamic IDs > interconnect: qcom: sc8280xp: convert to dynamic IDs > interconnect: qcom: sdm845: convert to dynamic IDs > interconnect: qcom: sm8250: convert to dynamic IDs > interconnect: qcom: x1e80100: convert to dynamic IDs > interconnect: qcom: qcs615: convert to dynamic IDs > interconnect: qcom: qcs8300: convert to dynamic IDs > interconnect: qcom: qdu1000: convert to dynamic IDs > interconnect: qcom: sar2130p: convert to dynamic IDs > interconnect: qcom: sc7180: convert to dynamic IDs > interconnect: qcom: sdm670: convert to dynamic IDs > interconnect: qcom: sdx55: convert to dynamic IDs > interconnect: qcom: sdx65: convert to dynamic IDs > interconnect: qcom: sdx75: convert to dynamic IDs > interconnect: qcom: sm6350: convert to dynamic IDs > interconnect: qcom: sm7150: convert to dynamic IDs > interconnect: qcom: sm8150: convert to dynamic IDs > interconnect: qcom: sm8350: convert to dynamic IDs > interconnect: qcom: sm8450: convert to dynamic IDs > interconnect: qcom: sm8550: convert to dynamic IDs > interconnect: qcom: sm8650: convert to dynamic IDs > interconnect: qcom: sm8750: convert to dynamic IDs > interconnect: qcom: icc-rpmh: drop support for non-dynamic IDS > > drivers/interconnect/qcom/bcm-voter.c | 4 +- > drivers/interconnect/qcom/icc-rpmh.c | 20 +- > drivers/interconnect/qcom/icc-rpmh.h | 13 +- > drivers/interconnect/qcom/qcs615.c | 713 ++++++++----------- > drivers/interconnect/qcom/qcs615.h | 128 ---- > drivers/interconnect/qcom/qcs8300.c | 911 +++++++++++------------- > drivers/interconnect/qcom/qcs8300.h | 177 ----- > drivers/interconnect/qcom/qdu1000.c | 470 ++++++------ > drivers/interconnect/qcom/qdu1000.h | 95 --- > drivers/interconnect/qcom/sa8775p.c | 493 ++++++------- > drivers/interconnect/qcom/sar2130p.c | 795 ++++++++------------- > drivers/interconnect/qcom/sc7180.c | 892 +++++++++++------------ > drivers/interconnect/qcom/sc7180.h | 149 ---- > drivers/interconnect/qcom/sc7280.c | 840 ++++++++++------------ > drivers/interconnect/qcom/sc7280.h | 154 ---- > drivers/interconnect/qcom/sc8180x.c | 1013 +++++++++++++------------- > drivers/interconnect/qcom/sc8180x.h | 179 ----- > drivers/interconnect/qcom/sc8280xp.c | 1257 ++++++++++++++++----------------- > drivers/interconnect/qcom/sc8280xp.h | 209 ------ > drivers/interconnect/qcom/sdm670.c | 712 +++++++++---------- > drivers/interconnect/qcom/sdm670.h | 128 ---- > drivers/interconnect/qcom/sdm845.c | 986 ++++++++++++-------------- > drivers/interconnect/qcom/sdm845.h | 140 ---- > drivers/interconnect/qcom/sdx55.c | 611 ++++++++-------- > drivers/interconnect/qcom/sdx55.h | 70 -- > drivers/interconnect/qcom/sdx65.c | 577 +++++++-------- > drivers/interconnect/qcom/sdx65.h | 65 -- > drivers/interconnect/qcom/sdx75.c | 498 ++++++------- > drivers/interconnect/qcom/sdx75.h | 97 --- > drivers/interconnect/qcom/sm6350.c | 838 +++++++++++----------- > drivers/interconnect/qcom/sm6350.h | 139 ---- > drivers/interconnect/qcom/sm7150.c | 860 +++++++++++----------- > drivers/interconnect/qcom/sm7150.h | 140 ---- > drivers/interconnect/qcom/sm8150.c | 930 ++++++++++++------------ > drivers/interconnect/qcom/sm8150.h | 152 ---- > drivers/interconnect/qcom/sm8250.c | 977 ++++++++++++------------- > drivers/interconnect/qcom/sm8250.h | 168 ----- > drivers/interconnect/qcom/sm8350.c | 901 ++++++++++++----------- > drivers/interconnect/qcom/sm8350.h | 158 ----- > drivers/interconnect/qcom/sm8450.c | 823 ++++++++++----------- > drivers/interconnect/qcom/sm8450.h | 169 ----- > drivers/interconnect/qcom/sm8550.c | 683 ++++++++---------- > drivers/interconnect/qcom/sm8550.h | 138 ---- > drivers/interconnect/qcom/sm8650.c | 713 ++++++++----------- > drivers/interconnect/qcom/sm8650.h | 144 ---- > drivers/interconnect/qcom/sm8750.c | 779 ++++++++------------ > drivers/interconnect/qcom/x1e80100.c | 819 ++++++++++----------- > drivers/interconnect/qcom/x1e80100.h | 192 ----- > 48 files changed, 8655 insertions(+), 13464 deletions(-) > --- > base-commit: 410f15dcfe222c06f0d6379adec630061e88dc72 > change-id: 20250613-rework-icc-0d3b7276a798 > > Best regards,