From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, vkoul@kernel.org
Cc: alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com,
yung-chuan.liao@linux.intel.com, quic_srivasam@quicinc.com
Subject: Re: [PATCH v2 2/2] soundwire: qcom: do not send status of device 0 during alert
Date: Fri, 16 Sep 2022 16:22:03 +0200 [thread overview]
Message-ID: <78c9421e-d66a-3477-9dff-f819e1ac9414@linux.intel.com> (raw)
In-Reply-To: <20220916135352.19114-2-srinivas.kandagatla@linaro.org>
On 9/16/22 15:53, Srinivas Kandagatla wrote:
> Device0 can not be in alter status. And for consistency reasons do not
typo: alert
> send status of device0 to core.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> drivers/soundwire/qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index d3ce580cdeaf..a04a8863b228 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -428,7 +428,7 @@ static int qcom_swrm_get_alert_slave_dev_num(struct qcom_swrm_ctrl *ctrl)
>
> ctrl->reg_read(ctrl, SWRM_MCP_SLV_STATUS, &val);
>
> - for (dev_num = 0; dev_num <= SDW_MAX_DEVICES; dev_num++) {
> + for (dev_num = 1; dev_num <= SDW_MAX_DEVICES; dev_num++) {
> status = (val >> (dev_num * SWRM_MCP_SLV_STATUS_SZ));
>
> if ((status & SWRM_MCP_SLV_STATUS_MASK) == SDW_SLAVE_ALERT) {
next prev parent reply other threads:[~2022-09-16 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 13:53 [PATCH v2 1/2] soundwire: qcom: update status from device id 1 Srinivas Kandagatla
2022-09-16 13:53 ` [PATCH v2 2/2] soundwire: qcom: do not send status of device 0 during alert Srinivas Kandagatla
2022-09-16 14:22 ` Pierre-Louis Bossart [this message]
2022-09-16 14:22 ` [PATCH v2 1/2] soundwire: qcom: update status from device id 1 Pierre-Louis Bossart
2022-09-20 5:04 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78c9421e-d66a-3477-9dff-f819e1ac9414@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_srivasam@quicinc.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).