From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
konrad.dybcio@somainline.org, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 0/2] media: venus: Fix up buffer handling for HFI_VERSION_1XX
Date: Fri, 5 Aug 2022 15:42:37 +0300 [thread overview]
Message-ID: <79841c03-c0dc-366d-ecf1-3486c77fd882@linaro.org> (raw)
In-Reply-To: <20220726021455.1814096-1-bryan.odonoghue@linaro.org>
Hi Bryan,
Thanks for the patches!
On 7/26/22 05:14, Bryan O'Donoghue wrote:
> This series fixes two buffer handling bugs. The first bug is trivial and
> ~impossible to hit without the second bug but with fixing anyway. Its a
> simple NULL pointer handling issue.
>
> The second bug relates to HFI_VERSION_1XX output buffers. Unfortunately
> these have been broken since
>
> Commit: 9593126dae3e ("media: venus: Add a handling of QC08C compressed format")
>
> A bit of bisecting the commits in venus found it handily enough. Once the
> fix is applied we have I have decode working again on db410c.
>
> Bryan O'Donoghue (2):
> media: venus: dec: Handle the case where find_format fails
> media: venus: Fix NV12 decoder buffer discovery on HFI_VERSION_1XX
>
> drivers/media/platform/qcom/venus/helpers.c | 13 +++++++------
> drivers/media/platform/qcom/venus/vdec.c | 2 ++
> 2 files changed, 9 insertions(+), 6 deletions(-)
>
Looks good to me.
Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
--
regards,
Stan
prev parent reply other threads:[~2022-08-05 12:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 2:14 [PATCH 0/2] media: venus: Fix up buffer handling for HFI_VERSION_1XX Bryan O'Donoghue
2022-07-26 2:14 ` [PATCH 1/2] media: venus: dec: Handle the case where find_format fails Bryan O'Donoghue
2022-08-05 13:12 ` Stanimir Varbanov
2022-07-26 2:14 ` [PATCH 2/2] media: venus: Fix NV12 decoder buffer discovery on HFI_VERSION_1XX Bryan O'Donoghue
2022-08-05 13:12 ` Stanimir Varbanov
2022-07-26 12:11 ` [PATCH 0/2] media: venus: Fix up buffer handling for HFI_VERSION_1XX Bryan O'Donoghue
2022-08-05 12:42 ` Stanimir Varbanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79841c03-c0dc-366d-ecf1-3486c77fd882@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).