From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sai Prakash Ranjan Subject: Re: [PATCH] pstore/ram: Fix console ramoops to show the previous boot logs Date: Thu, 17 Jan 2019 20:58:49 +0530 Message-ID: <79870bf9-e40c-2249-0859-b2404af296c1@codeaurora.org> References: <20190117062620.23908-1-saiprakash.ranjan@codeaurora.org> <20190117151833.GA51139@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190117151833.GA51139@google.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Joel Fernandes Cc: Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Guenter Roeck , Rajendra Nayak , Vivek Gautam , Sibi Sankar , Stephen Boyd , Doug Anderson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On 1/17/2019 8:48 PM, Joel Fernandes wrote: > On Thu, Jan 17, 2019 at 11:56:20AM +0530, Sai Prakash Ranjan wrote: >> commit b05c950698fe ("pstore/ram: Simplify ramoops_get_next_prz() >> arguments") changed update assignment in getting next persistent >> ram zone by adding a check for record type. But the check always >> returns true since the record type is assigned 0. And this breaks >> console ramoops by showing current console log instead of previous >> log on warm reset and hard reset (actually hard reset should not >> be showing any logs). >> >> Fix this by having persistent ram zone type check instead of record >> type check. Tested this on SDM845 MTP and dragonboard 410c. >> >> Reproducing this issue is simple as below: >> >> 1. Trigger hard reset and mount pstore. Will see console-ramoops >> record in the mounted location which is the current log. >> >> 2. Trigger warm reset and mount pstore. Will see the current >> console-ramoops record instead of previous record. >> >> Fixes: b05c950698fe ("pstore/ram: Simplify ramoops_get_next_prz() arguments") >> Signed-off-by: Sai Prakash Ranjan > > > Acked-by: Joel Fernandes (Google) > Thanks Joel. -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation