linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Adam Skladowski <a39.skl@gmail.com>
Cc: phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Bjorn Andersson <andersson@kernel.org>,
	Andy Gross <agross@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	AngeloGioacchino Del Regno <kholk11@gmail.com>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] clk: qcom: hfpll: Allow matching pdata
Date: Mon, 24 Jul 2023 16:08:37 +0200	[thread overview]
Message-ID: <79cea221-f908-e501-eb0c-94f613eb06ee@linaro.org> (raw)
In-Reply-To: <20230723160827.22660-4-a39.skl@gmail.com>

On 23.07.2023 18:08, Adam Skladowski wrote:
> HFPLL driver can be used to drive PLLs also on different SoCs like MSM8976
> On MSM8976 each PLL gets it own different configuration,
> add matching pdata to driver to support multiple configurations.
> 
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
> ---
>  drivers/clk/qcom/hfpll.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/qcom/hfpll.c b/drivers/clk/qcom/hfpll.c
> index f4d78003d189..ec18bc8f0089 100644
> --- a/drivers/clk/qcom/hfpll.c
> +++ b/drivers/clk/qcom/hfpll.c
> @@ -6,6 +6,7 @@
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/of.h>
> +#include <linux/of_device.h>
>  #include <linux/clk.h>
>  #include <linux/clk-provider.h>
>  #include <linux/regmap.h>
> @@ -32,7 +33,7 @@ static const struct hfpll_data hdata = {
>  };
>  
>  static const struct of_device_id qcom_hfpll_match_table[] = {
> -	{ .compatible = "qcom,hfpll" },
> +	{ .compatible = "qcom,hfpll", &hdata },
As Angelo pointed out the last time around, ".data = " is missing

Konrad

  reply	other threads:[~2023-07-24 14:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-23 16:08 [PATCH v2 0/7] MSM8976 PLL,RPMPD and DTS changes Adam Skladowski
2023-07-23 16:08 ` [PATCH v2 1/7] drivers: soc: qcom: rpmpd: Fix MSM8976 power domains setup Adam Skladowski
2023-07-24 20:36   ` Dmitry Baryshkov
2023-07-23 16:08 ` [PATCH v2 2/7] clk: qcom: clk-hfpll: Configure l_val in init when required Adam Skladowski
2023-07-24 14:08   ` Konrad Dybcio
2023-07-23 16:08 ` [PATCH v2 3/7] clk: qcom: hfpll: Allow matching pdata Adam Skladowski
2023-07-24 14:08   ` Konrad Dybcio [this message]
2023-07-23 16:08 ` [PATCH v2 4/7] dt-bindings: clock: qcom,hfpll: Document MSM8976 compatibles Adam Skladowski
2023-07-24  7:30   ` Krzysztof Kozlowski
2023-07-23 16:08 ` [PATCH v2 5/7] clk: qcom: hfpll: Add MSM8976 PLL data Adam Skladowski
2023-07-25  8:02   ` Konrad Dybcio
2023-07-25 10:03     ` Adam Skladowski
2023-07-23 16:08 ` [PATCH v2 6/7] arm64: dts: qcom: msm8976: Split lpass region Adam Skladowski
2023-07-25  8:44   ` Konrad Dybcio
2023-07-25  9:46     ` Adam Skladowski
2023-07-23 16:08 ` [PATCH v2 7/7] arm64: dts: qcom: msm8976: Fix smsm ipc bit shifts Adam Skladowski
2023-07-24 20:38 ` [PATCH v2 0/7] MSM8976 PLL,RPMPD and DTS changes Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79cea221-f908-e501-eb0c-94f613eb06ee@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=a39.skl@gmail.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kholk11@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=mturquette@baylibre.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).