From: Adrian Hunter <adrian.hunter@intel.com>
To: Ritesh Harjani <riteshh@codeaurora.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, georgi.djakov@linaro.org,
asutoshd@codeaurora.org, stummala@codeaurora.org,
venkatg@codeaurora.org, pramod.gurav@linaro.org,
jeremymc@redhat.com
Subject: Re: [RESEND RFC 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops.
Date: Thu, 19 Jan 2017 12:43:01 +0200 [thread overview]
Message-ID: <79ff44d2-c20d-2dc7-9a0a-d77fb00df46d@intel.com> (raw)
In-Reply-To: <d8e5b1fe-1f4e-f6f9-6f94-f5c7adc027f3@codeaurora.org>
On 18/01/17 09:57, Ritesh Harjani wrote:
> Hi Shawn,
>
> On 1/10/2017 2:45 PM, Shawn Lin wrote:
>> On 2017/1/10 14:41, Ritesh Harjani wrote:
>>> From: Sahitya Tummala <stummala@codeaurora.org>
>>>
>>> Add new host operation ->platform_dumpregs to provide a
>>> mechanism through which host drivers can dump platform
>>> specific registers in addition to SDHC registers
>>> during error conditions.
>>>
>>
>> Although we have been preventing from adding new callback
>> for sdhci core, this one makes sense as there are more and more
>> vendor registers outside the scope of SDHCI spec.
We are not prevented from adding new callbacks, but they have to represent
logical functions not quirks.
This patch seems fine to me except the name "platform_dumpregs" because
"platform" doesn't mean "platform" here. Just plain "dumpregs" is better.
next prev parent reply other threads:[~2017-01-19 10:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 6:41 [RESEND RFC 0/3] mmc: sdhci: sdhci-msm: Add more debug logs Ritesh Harjani
2017-01-10 6:41 ` [RESEND RFC 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops Ritesh Harjani
2017-01-10 9:15 ` Shawn Lin
2017-01-18 7:57 ` Ritesh Harjani
2017-01-19 10:43 ` Adrian Hunter [this message]
2017-01-20 5:59 ` Ritesh Harjani
2017-01-10 6:41 ` [RESEND RFC 2/3] mmc: sdhci-msm: Implement platform_dumpregs callback in sdhci-msm Ritesh Harjani
2017-01-19 10:55 ` Adrian Hunter
2017-01-20 5:54 ` Ritesh Harjani
2017-01-10 6:41 ` [RESEND RFC 3/3] mmc: sdhci: Add more debug info in case of data error Ritesh Harjani
2017-01-19 11:54 ` Adrian Hunter
2017-01-20 6:26 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79ff44d2-c20d-2dc7-9a0a-d77fb00df46d@intel.com \
--to=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=georgi.djakov@linaro.org \
--cc=jeremymc@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pramod.gurav@linaro.org \
--cc=riteshh@codeaurora.org \
--cc=shawn.lin@rock-chips.com \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=venkatg@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox