From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sricharan R Subject: Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver Date: Tue, 29 May 2018 14:02:18 +0530 Message-ID: <7a2e86a2-00bc-cd64-6d86-4c5e8c7a7b0e@codeaurora.org> References: <20180523052054.19025-1-bjorn.andersson@linaro.org> <20180523052054.19025-6-bjorn.andersson@linaro.org> <20180523060516.GD20991@vkoul-mobl> <20180523065815.GZ14924@minitux> <20180523073723.GF20991@vkoul-mobl> <20180529040742.GD2259@tuxbook-pro> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180529040742.GD2259@tuxbook-pro> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Andersson Cc: Vinod , Ohad Ben-Cohen , Sibi Sankar , Rohit kumar , Andy Gross , linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-arm-msm@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org Hi Bjorn, On 5/29/2018 9:37 AM, Bjorn Andersson wrote: > On Wed 23 May 07:48 PDT 2018, Sricharan R wrote: >> On 5/23/2018 1:07 PM, Vinod wrote: >>> On 22-05-18, 23:58, Bjorn Andersson wrote: >>>> On Tue 22 May 23:05 PDT 2018, Vinod wrote: >>>>> On 22-05-18, 22:20, Bjorn Andersson wrote: > [..] >>>>> Looking at the patch, few other comments would be applicable too, so would be >>>>> great if you/Sricharan can update this >>>>> >>>> >>>> I agree, the primary purpose of this patch was rather to get feedback on >>>> the structure of the drivers, I do expect this to take another round >>>> through the editor to get some polishing touches. Sorry if this wasn't >>>> clear from the description. >>> >>> Since Sricharan replied to comments, I though they would be fixed. Yeah this is >>> fine from RFC.. >>> >> >> Thanks for this. >> >> Tested this on ipq8074 and wcss rproc is up with this. >> >> Tested-by: Sricharan R >> > > Thanks Sricharan! > >> So regarding the cleanup, as i see, this consolidates the code much better. >> >> so about the point of avoiding duplication for soc specific functions like >> qcv5_wcss_reset common between qcv5_wcss and qcv5_pil drivers as done in my >> series, with a second thought that feels it might be difficult to maintain >> in the longer run. Since the sequences are specific to each soc and for now >> although some part of it is common, for a minor update in one soc, common >> code needs to reworked every time and tested on all boards that share them. >> >> So feels like having the duplication for hw init sequences is the cleaner way. >> > > Sounds good, then let's go with this approach! > >> Apart from that for other comments on the q6v5 wcss driver, i can address them >> on this final patch that you have posted and same can be included in your >> next version. Please let me know how you want to go about it. >> > > If you can help me review the first 4 patches and fix up and resend the > 5th that would be greatly appreciated. Sure, will do. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation