From: konrad.dybcio@somainline.org
To: Parikshit Pareek <quic_ppareek@quicinc.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrew Halaney <ahalaney@redhat.com>,
Shazad Hussain <quic_shazhuss@quicinc.com>,
Brian Masney <bmasney@redhat.com>,
Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH v6 2/2] arm64: dts: qcom: add SA8540P ride(Qdrive-3)
Date: Thu, 20 Oct 2022 13:49:23 +0200 [thread overview]
Message-ID: <7a62dd552c02e2b83fabaf9ff55a7c6c@somainline.org> (raw)
In-Reply-To: <20221020073036.16656-3-quic_ppareek@quicinc.com>
On 2022-10-20 09:30, Parikshit Pareek wrote:
> Introduce the Qualcomm SA8540P ride automotive platform, also known as
> Qdrive-3 development board.
>
> This initial contribution supports SMP, CPUFreq, cluster idle, UFS,
> RPMh
> regulators, debug UART, PMICs, remoteprocs and USB.
>
> The SA8540P ride contains four PM8450 PMICs.
>
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> ---
Hi!
[...[
> + vreg_l3c: ldo3 {
> + regulator-name = "vreg_l3c";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + regulator-allow-set-load;
Not sure if setting load is desired after recent rpmh regulator changes.
[...]
> +
> +&spmi_bus {
> + pm8450a: pmic@0 {
> + compatible = "qcom,pm8150", "qcom,spmi-pmic";
Please add a pm8450[aceg].dtsi instead, as other boards would probably
like to
reuse this. Also, move the spmi.h inclusion there.
[...]
> +};
> +
> +/* PINCTRL */
Not sure if it's useful if there's nothing there for now.
Konrad
next prev parent reply other threads:[~2022-10-20 12:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 7:30 [PATCH v6 0/2] arm64: dts: qcom: add dts for sa8540p-ride board Parikshit Pareek
2022-10-20 7:30 ` [PATCH v6 1/2] dt-bindings: arm: qcom: Document additional sa8540p device Parikshit Pareek
2022-10-20 13:46 ` Krzysztof Kozlowski
2022-10-20 16:33 ` Brian Masney
2022-10-20 7:30 ` [PATCH v6 2/2] arm64: dts: qcom: add SA8540P ride(Qdrive-3) Parikshit Pareek
2022-10-20 11:49 ` konrad.dybcio [this message]
2022-10-28 7:50 ` Parikshit Pareek
2022-10-28 8:28 ` Brian Masney
2022-10-20 16:39 ` Brian Masney
2022-11-02 7:35 ` Shazad Hussain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a62dd552c02e2b83fabaf9ff55a7c6c@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_ppareek@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox