From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 144251FB3 for ; Thu, 21 Nov 2024 01:34:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732152878; cv=none; b=ptChbFHmDWmXqF0W2cUB7PnwzZs3OLRoGsYeRaAvcAJUBDiWMZrmhJFCWORBlPvkmiXjJJdRAB0vppMlB8yEksFfmcDq0Y6fg2lgl7tGrjSP3G7sOHpR95h/73ku2IgED5YRCLFyvmM17hiZvtt4GUOjVtCxXfEQtaWcnRf48jQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732152878; c=relaxed/simple; bh=j2Lj2gFA4YdQyBOiPDC+32OwWu+OLCxqmZAsIPDLNbM=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=G2PrGFN3nKnKSATp1871g9pfqsKYJazqabH9+dySPOhXQmcbvi905L5Otgy10QkC4NYFQJM21VZiTT+apQlfJCtVK4b1DluVrwBDFlQUwyHeHo657gu2aev/3FxAoN0VRo+yuT1j5QHI8S3fvVbY5/ZhhlmfVf99toI1LYeJEJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=omSzadeN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="omSzadeN" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AKK4ok7007627; Thu, 21 Nov 2024 01:34:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mWkJ7jmYZSvoFFxCxfuIKsg6tqBQ3T2uxkVx/Bp+wKA=; b=omSzadeNZsgz1sJ4 qx8bOmFf8olyQdQgEuMrLg5KhpKRYtj33/tbnqqBznKUSr95r6e2VL+dMFToeN8v 5PMV9pgje2OA3KPylJM8xfD4B7DNH30nC9f98BZqDxmTJ+xKFyGXfXr/baF9AD69 Z6PRi/Fj6uEJ02nBcMCc7FU6rsO9ZJ4Gsk3BIlNT3aIw6ERBjHM842z0fR+al4sp 7izZRy2UevvNNV9HqjuPIz+jHig92/gANEIfgKgkRmGZLuFr+yHcsw+GMSf9tZxj fNnBcffnLVeqIgWIMaAL/3eC1MHOnNfv+F1Ti61DKOh3WdnGZ3Ee/xNYlmabA/9C +vCqRQ== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4318uvjuvu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Nov 2024 01:34:33 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4AL1YWl4024498 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Nov 2024 01:34:32 GMT Received: from [10.64.16.151] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 20 Nov 2024 17:34:28 -0800 Message-ID: <7a7a0ba7-2d96-455c-aea7-a2cae8f60749@quicinc.com> Date: Thu, 21 Nov 2024 09:34:25 +0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] dt-bindings: display/msm: Add QCS615 DSI phy To: Dmitry Baryshkov CC: , , , , References: <20241014-add_display_support_for_qcs615-v1-0-4efa191dbdd4@quicinc.com> <20241014-add_display_support_for_qcs615-v1-4-4efa191dbdd4@quicinc.com> <34jwvxxycm2mi3tqndhuoapth4u5nbn4omsiaxxrh2iapwuky6@f7xttrmt7w2c> Content-Language: en-US From: fange zhang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 9Hrqy4H40pe6tyaiTOT2kOEfSctjzmY9 X-Proofpoint-GUID: 9Hrqy4H40pe6tyaiTOT2kOEfSctjzmY9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411210011 On 2024/11/20 20:22, Dmitry Baryshkov wrote: > On Tue, Nov 19, 2024 at 12:45:00PM +0800, fange zhang wrote: >> >> >> On 2024/10/14 18:30, Dmitry Baryshkov wrote: >>> On Mon, Oct 14, 2024 at 05:47:30PM +0800, fangez via B4 Relay wrote: >>>> From: lliu6 >>>> >>>> QCS615 platform uses the 14nm DSI PHY driver. >>> >>> - bindings describe the hardware, not the drivers. >>> - other platforms also have 14nm DSI PHY. Why do you need a separate >>> compatible? >> We need to introduce a new regulator configuration for the PHY: >> dsi_phy_14nm_36mA_regulators. This configuration has not been used before. >> >>> >>>> >>>> Signed-off-by: lliu6 >>>> --- >>>> Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >>>> index 52bbe132e6dae57246200757767edcd1c8ec2d77..029606d9e87e3b184bd10bd4a5076d6923d60e9e 100644 >>>> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >>>> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >>>> @@ -20,6 +20,7 @@ properties: >>>> - qcom,dsi-phy-14nm-660 >>>> - qcom,dsi-phy-14nm-8953 >>>> - qcom,sm6125-dsi-phy-14nm >>>> + - qcom,qcs615-dsi-phy-14nm > > qcom,sm6150-dsi-phy-14nm ok, will fix it in next patch >> sorry, still have some question about this yaml file. >> it's necessary for b4 check >> >> checkpatch.pl: drivers/gpu/drm/msm/dsi/phy/dsi_phy.c:564: WARNING: DT >> compatible string "qcom,dsi-phy-14nm-6150" appears un-doc >> umented -- check ./Documentation/devicetree/bindings/ >> >> need to add this new 6150 node for dsi-phy-14nm. >> shall i add it? >> >>>> reg: >>>> items: >>>> >>>> -- >>>> 2.25.1 >>>> >>>> >>> >> >> and could you please help to review the new version? >> Author: Li Liu >> Date: Tue Nov 19 12:35:12 2024 +0800 >> >> dt-bindings: display/msm: Add SM6150 DSI phy >> >> Add new compatible for SM6150 with dsi_phy_14nm_36mA_regulators >> >> Signed-off-by: Li Liu >> Signed-off-by: Fange Zhang >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> index 52bbe132e6da..fd6eb3434450 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> @@ -17,6 +17,7 @@ properties: >> enum: >> - qcom,dsi-phy-14nm >> - qcom,dsi-phy-14nm-2290 >> + - qcom,dsi-phy-14nm-6150 > > qcom,sm6150-dsi-phy-14nm ok, will fix it in next patch > >> - qcom,dsi-phy-14nm-660 >> - qcom,dsi-phy-14nm-8953 >> - qcom,sm6125-dsi-phy-14nm >> >