From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexey Klimov <alexey.klimov@linaro.org>, Lee Jones <lee@kernel.org>
Cc: Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Stephen Boyd <sboyd@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: sound: add bindings for pm4125 audio codec
Date: Thu, 24 Jul 2025 17:48:38 +0200 [thread overview]
Message-ID: <7b012ae4-32b8-4de8-97a5-9b73cced2e4c@kernel.org> (raw)
In-Reply-To: <DBKDVB96ZC98.NOF39E05HZ8H@linaro.org>
On 24/07/2025 17:17, Alexey Klimov wrote:
> On Fri Jul 18, 2025 at 2:43 PM BST, Lee Jones wrote:
>> On Fri, 11 Jul 2025, Alexey Klimov wrote:
>>
>>> The audio codec IC is found on Qualcomm PM4125/PM2250 PMIC.
>>> It has TX and RX soundwire slave devices hence two files are added.
>>>
>>> While at this, also add pattern for respecive node in mfd
>>> qcom,spmi-pmic schema so the devicetree for this audio block of
>>> PMIC can be validated properly.
>>>
>>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
>>> ---
>>> .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 +-
>>> .../bindings/sound/qcom,pm4125-codec.yaml | 134 +++++++++++++++++++++
>>> .../devicetree/bindings/sound/qcom,pm4125-sdw.yaml | 79 ++++++++++++
>>
>> Do you have to submit these all in a single patch?
>
> qcom,pm4125-codec.yaml and qcom,pm4125-sdw.yaml describe one device (sub-device)
> and change for qcom,spmi-pmic.yaml is needed to avoid failing dtbs check.
Preferred way to solve this is to just list compatibles, instead of
other schema, just like all qcom display bindings are doing.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-24 15:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 3:00 [PATCH v2 0/3] Add PM4125 audio codec driver Alexey Klimov
2025-07-11 3:00 ` [PATCH v2 1/3] dt-bindings: sound: add bindings for pm4125 audio codec Alexey Klimov
2025-07-11 8:27 ` Krzysztof Kozlowski
2025-07-18 13:43 ` Lee Jones
2025-07-24 15:17 ` Alexey Klimov
2025-07-24 15:48 ` Krzysztof Kozlowski [this message]
2025-08-13 22:28 ` Alexey Klimov
2025-07-11 3:00 ` [PATCH v2 2/3] ASoC: codecs: add new pm4125 audio codec driver Alexey Klimov
2025-07-11 8:29 ` Krzysztof Kozlowski
2025-07-24 15:41 ` Alexey Klimov
2025-08-13 23:08 ` Alexey Klimov
2025-07-11 13:32 ` Srinivas Kandagatla
2025-08-13 23:07 ` Alexey Klimov
2025-07-11 15:15 ` Christophe JAILLET
2025-08-13 23:04 ` Alexey Klimov
2025-07-11 3:00 ` [PATCH v2 3/3] MAINTAINERS: add Qualcomm PM4125 audio codec to drivers list Alexey Klimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b012ae4-32b8-4de8-97a5-9b73cced2e4c@kernel.org \
--to=krzk@kernel.org \
--cc=alexey.klimov@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=srini@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).