Re: [RESEND PATCH v4 7/7] clk: qcom: Add GCC_MSS_RESET support to reset MSS in v56 1.5.0

["Dwivedi, Avaneesh Kumar (avani)" <akdwived@codeaurora.org>]

On 12/9/2016 1:21 AM, Bjorn Andersson wrote:
> On Thu 24 Nov 02:00 PST 2016, Avaneesh Kumar Dwivedi wrote:
>
>> Add support to use reset control framework for resetting MSS
>> on v56 1.5.0.
>>
>> Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org>
> You should try (really hard) to limit your subject line to 50 characters
> and then use the body to describe your change - rather than just typing
> the same thing twice. E.g. a subject of "clk: gcc-msm8996: Add
> MSS_RESET" is short and to the point.
Ok, Sure :(
>
> Please update the subject and add:
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Regards,
> Bjorn
>
>> ---
>>   drivers/clk/qcom/gcc-msm8996.c               | 1 +
>>   include/dt-bindings/clock/qcom,gcc-msm8996.h | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c
>> index fe03e6f..fd4bf6f 100644
>> --- a/drivers/clk/qcom/gcc-msm8996.c
>> +++ b/drivers/clk/qcom/gcc-msm8996.c
>> @@ -3423,6 +3423,7 @@ enum {
>>   	[GCC_MSMPU_BCR] = { 0x8d000 },
>>   	[GCC_MSS_Q6_BCR] = { 0x8e000 },
>>   	[GCC_QREFS_VBG_CAL_BCR] = { 0x88020 },
>> +	[GCC_MSS_RESTART] = { 0x8f008 },
>>   };
>>   
>>   static const struct regmap_config gcc_msm8996_regmap_config = {
>> diff --git a/include/dt-bindings/clock/qcom,gcc-msm8996.h b/include/dt-bindings/clock/qcom,gcc-msm8996.h
>> index 1828723..1f5c422 100644
>> --- a/include/dt-bindings/clock/qcom,gcc-msm8996.h
>> +++ b/include/dt-bindings/clock/qcom,gcc-msm8996.h
>> @@ -339,6 +339,7 @@
>>   #define GCC_PCIE_PHY_COM_NOCSR_BCR				102
>>   #define GCC_USB3_PHY_BCR					103
>>   #define GCC_USB3PHY_PHY_BCR					104
>> +#define GCC_MSS_RESTART						105
>>   
>>   
>>   /* Indexes for GDSCs */
>> -- 
>> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project.
>>

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.