From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 653A1322A3F for ; Mon, 27 Oct 2025 15:47:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761580053; cv=none; b=QtcDgljhM6bkjI/5zHUzCyj5ksaXgx9AU/aAeUjWpGLBJ8hJgs8aOCtdTBrPA5ufNbyzYCyRQnJiHIpT9gu8oAsyz2IX9ycZiQVsYLt4PpJDS9YkXBQu9mVALSr0Ohw7Bgr8/Nq+nlFIoIJXu9cr4w9IWH4qMBZQa/7tdt2Ve7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761580053; c=relaxed/simple; bh=tQL6TIWCl8aDOrH0GaFalhGYJg12eSESkwTpBcEYy4o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VU9uUFQJWwiq0xUOGERbc6QcP6lliF+/wJWUSv7G8qdYb9hL8elunuhwI8u+r3QHtXGWaecpZC3rgkHFimKsf/+PwZ4E1gHfFyGJgI1551FO6OOTpFNquITU6MqOlVAe9KAypHETIwmpuuHkEzAK3SzyH/zd+Zu6D4JzQHEKN+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mgORrcLr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mgORrcLr" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59RCTqKt2752122 for ; Mon, 27 Oct 2025 15:47:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zaCZneb5YWhjC19k4/2yPgAXlS8d0rH/p95cOFgMm+o=; b=mgORrcLra9bOxg7T BMlgLI0vpCS8JfbfdZmTNX0ukmVnYaCpmYmWzEf9SWuwytvlRiEBXxsUP1r73M+k i3KI+Eu/H0GFZOTcH+H/5CeDEas0/dg7o3H4THI/rBwGZ7r5jOsQ4V+NwlZg2MJM IIyhvpaN633LsfXiXUC1MCdII7Ta3e5eBfYYfC9unGEVgNuCQ3mSpcp1Rzagoclo PkfAPKz8DXlp7lVLNVocXSQlSwcKAE86x+cDI5YzTuc2hVU+yKcMnHe7/ytKyoIo R4O1TVc8gtDAN8msWB7dFgrhVUEbmIAqpsDfz3YlSCHK9gIDS2w0urzi6wlAHZwD veOKWw== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a28swgqqj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Oct 2025 15:47:30 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-87dfd456d01so14802516d6.1 for ; Mon, 27 Oct 2025 08:47:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761580049; x=1762184849; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zaCZneb5YWhjC19k4/2yPgAXlS8d0rH/p95cOFgMm+o=; b=rHm2Z8nHAAdXpNkBYCl4f4+0iFBPRyHtqL1+NqvFxYhS6evfbl+/zof5QGI8GVdkhN FWsgXNRtIsMRYpWfgE0i0+4mMV9a0kBMc8he+pB73TNYWNa52cQc+TC3swwF3atE61NO 5WmknGJ0MmJ2t9Ml75uD9VHDzFLH3x/1qGH/SIKY4pEEcgudboFd0B0D43osYVILXb9F JZwLD3qOyhikeBkDl4aJNlXFgQeCXUmFmdYBhe6RWUNWtmaESwdg9BQypH+bGQfZ+/ev ilOPTjI6zDPQKiJaMkZKdad75J42FeQrdLDpVgtGntB67rf2aA0RO66Rh5D2DpuUUqjJ mwrQ== X-Forwarded-Encrypted: i=1; AJvYcCVDjlr2ZoMAGUBLRQOrR+MaK3PI1sdau2rd45haUF/PJIEttHOLVVOkNmOnfU6amw4wdrLy0GxsuFw5HBpB@vger.kernel.org X-Gm-Message-State: AOJu0YzwgFa+DJnWAWE+8rMoUkwaB1F1TyTLLZCW+Y4oLmF+o3U3U/SX qOa/A8iVBapsUCdUYhcaaOarVhEDAsvlUiKgnQxNoU5C9mGyqdhVPMDXBkzTEvbA93UJGOMPTxV IjNwsx3QOH0KzmL619MHPQuafvSYgRgRsvHbe7MGObylAPD4AX6EClwKTcyy+uXqPvcGR X-Gm-Gg: ASbGncvUlB2LRsUvHCZl8xPOKUNfi7aaV0ZOT8n3x6Jfm7QZwK8dXIKGxxJvKAOFWpc SxFDFQGVE+n9buMNkvnDbfqANs6+459BYN9CKnVbl9hD8xGe5wJ8rh0fyabMYmNOPGCCUjczByz KoWKlBtw18PrwEykwpLmi0MOKYXQGlQDh707+VjjFZ4vK6TnouMFg2ImvybsZYLeZrbZZwW0bx2 WkpeBJpeOxvjZU6+JhpYzh/HKQwoDZWU4wuC+LXQOfjcahsprNKc1+s34Kl4aC29MUqcXDAfchg SbDYFAinykiu0LNVtM9ttpaylTTyBbKezIQ0DhcGYx5qt66AXHN6bRIS+BEoFXh9gr4fxcHytlz ti7lrbMwsyczfktE5k1zIIDnAvlAV5hyl9y9bQYxV3gLWkxFaEwic60pt X-Received: by 2002:a05:622a:15c2:b0:4ec:f075:50cb with SMTP id d75a77b69052e-4ed07425e39mr4975251cf.2.1761580049435; Mon, 27 Oct 2025 08:47:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGIgcSp0xCZswOedEYchtLWxCtcXToz2VeG+CLk8VsDBcRyNSlY/6wzGEsHr6w4SRPPrVI0GQ== X-Received: by 2002:a05:622a:15c2:b0:4ec:f075:50cb with SMTP id d75a77b69052e-4ed07425e39mr4974841cf.2.1761580048893; Mon, 27 Oct 2025 08:47:28 -0700 (PDT) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b6d85413b88sm778566566b.55.2025.10.27.08.47.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Oct 2025 08:47:28 -0700 (PDT) Message-ID: <7b68381a-0f7f-43ff-b934-9db5d9b2e69f@oss.qualcomm.com> Date: Mon, 27 Oct 2025 16:47:26 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] soc: qcom: rpmh: Add support to read back resource settings To: Neil Armstrong , "Maulik Shah (mkshah)" , Bjorn Andersson , Kamal Wadhwa Cc: Konrad Dybcio , Liam Girdwood , Mark Brown , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251022-add-rpmh-read-support-v2-0-5c7a8e4df601@oss.qualcomm.com> <20251022-add-rpmh-read-support-v2-2-5c7a8e4df601@oss.qualcomm.com> <4831d12b-a42a-464a-a70f-e0e40cf4ae4b@oss.qualcomm.com> <5c0b4712-4a54-4a1a-ad73-dc3bdb21a0ff@oss.qualcomm.com> <9a227c15-dc60-4086-8d81-f80e3398a083@oss.qualcomm.com> <18e8d5db-e32a-4893-9d1f-5003670cedeb@oss.qualcomm.com> <7656e8f6-e281-4f7b-9ff4-1b2722234091@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <7656e8f6-e281-4f7b-9ff4-1b2722234091@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 3559DWPGKG_ysYZGbZecQHAJZ_dvzzJO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI3MDE0NyBTYWx0ZWRfX/aQHY0BGy5c+ clbc+23JJW8klqC5yWZaPdZfF8fpq93qSsNoYsN7wsYQSUDFltiLm6EXIiXUtu/6/EPQ2VukW7k 26mNFngkGWdKoNflt7jeWsDVRnMs5Q6rqNkHd7cG8pum1GMl01ylsC0zKF8EsJtNDtXssJIijjV PfEr4dUvq3h9uCzJN1f9CJmMQVyY4m3kc85Q89zCBRZKiguXbyMS0k3zmZRmgsyal13vK4VSRbp uX5J5gAYNPyn+6D6hVgbntKsEwWQIv4Siu+IYwmECIz7WHqZcl9+gjeDeYvSH+t9wm9Hs1qj06G VC0iCf6WTzKTmLYK2SW2oYnGgb21nxYJUsTvPxWriVK8OKqHq+a8EfZ21e7McMVuL1AI2Sr235O yOb0WCrZKw9qTEfuYyxGh2yCo+WdYQ== X-Proofpoint-GUID: 3559DWPGKG_ysYZGbZecQHAJZ_dvzzJO X-Authority-Analysis: v=2.4 cv=fL40HJae c=1 sm=1 tr=0 ts=68ff9412 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=gzx7cS8GTzoW4zH438oA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-27_06,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 phishscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 adultscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510020000 definitions=main-2510270147 On 10/27/25 3:38 PM, Neil Armstrong wrote: > On 10/27/25 14:29, Konrad Dybcio wrote: >> On 10/23/25 11:46 AM, Maulik Shah (mkshah) wrote: >>> >>> >>> On 10/23/2025 2:39 PM, Konrad Dybcio wrote: >>>> On 10/23/25 10:57 AM, Maulik Shah (mkshah) wrote: >>>>> >>>>> >>>>> On 10/23/2025 1:47 PM, Konrad Dybcio wrote: >>>>>> On 10/23/25 6:46 AM, Maulik Shah (mkshah) wrote: >>>>>>> >>>>>>> >>>>>>> On 10/23/2025 2:51 AM, Bjorn Andersson wrote: >>>>>>>> On Wed, Oct 22, 2025 at 02:38:54AM +0530, Kamal Wadhwa wrote: >>>>>>>>> From: Maulik Shah >>>>>>>>> >>>>>>>>> All rpmh_*() APIs so far have supported placing votes for various >>>>>>>>> resource settings but the H/W also have option to read resource >>>>>>>>> settings. >>>>>>>>> >>>>>>>>> This change adds a new rpmh_read() API to allow clients >>>>>>>>> to read back resource setting from H/W. This will be useful for >>>>>>>>> clients like regulators, which currently don't have a way to know >>>>>>>>> the settings applied during bootloader stage. >>>>>>>>> >>>>>>>> >>>>>>>> Allow me to express my disappointment over the fact that you sat on this >>>>>>>> for 7 years! >>>>>>> >>>>>>> This was a dead API (even in downstream) with no user since SDM845/ 7 years. >>>>>>> Read support was eventually removed from downstream driver too for the same reason. >>>>>>> There were early discussions to remove read support from RSC H/W, due to lack of users. >>>>>>> Its not realized yet and all SoCs still supports read. >>>>>> >>>>>> Can we read BCM states from HLOS this way too? >>>>> >>>>> Yes, Any of ARC/BCM/VRM can be read to get HLOS/DRV2 votes. >>>> >>>> Wow this is amazing.. >>>> >>>> Do you have code for this already, or should I hack on it? >>> >>> No, it won't be of much help, as i said above it gets HLOS/DRV2 votes only for a given resource. >>> More specifically, the read does not give the aggregated vote result across all the DRVs. >> >> Hm, perhaps it could still be of *some* use >> >> But maybe reading back rpmhpd and rpmhcc states would be of more >> use! > > The interconnect core definitely supports reading back the state at boot. Maulik probably isn't impressed with us only being able to provide information about HLOS votes, as e.g. ADSP could be voting on the same bus in parallel. I suppose the very same applies to what I suggested with clk and rpmhpd although probably it's less of a problem there Konrad