From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A2BC4321E for ; Thu, 1 Dec 2022 00:14:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbiLAAN7 (ORCPT ); Wed, 30 Nov 2022 19:13:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229951AbiLAANg (ORCPT ); Wed, 30 Nov 2022 19:13:36 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05CA8A0562 for ; Wed, 30 Nov 2022 16:07:05 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id j16so29340756lfe.12 for ; Wed, 30 Nov 2022 16:07:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WPrD93pLoHJDHfqU7iF0kkDXNwOLW25TnHPn7r3B0pg=; b=PbwrQ+zNQO06RoSt28/h+Fo+ZAGGkUX+1xRMtY3NFaVNuHM4s5AL9l0nVM2y2WqdQJ 5o993rjsVbuk5utuGKFYe+IZgBxb136GclFy3Tn6jpNoEPRNVZDQLdxWT5jiaCO8SsGi GkL1grn9ye0cli9iHmZpOW2Aa3bjOr4DUoiA9B6tyeR67d36aaMQHZCIqJvrDmLAN49a 6An2unYmCwRTBthslSxGE+Tn2N4qrMoti6UwLm5iMnvzFTDb8Eteb66kTVPNsy27EmGm BAe8rlAHbyAg/jVsq/APY0il3qemUDJ+gfNVOanlwjEOQQ6Tlvb4kMuhtjLxwtDD4Riz OVQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WPrD93pLoHJDHfqU7iF0kkDXNwOLW25TnHPn7r3B0pg=; b=s2I8QcTYLu0XdpfqFAxKu0M7IZYauD3KXPB+q/xJ4zGjSgESLHI6OgPHZnLcvCSXiX fh8FqIg0hdoRn6vTf6KYZxdM+Vgpk27ULFdmeTdhbjWF2nJQ4mMAO2RJXog6ezF1nA2i Tdirc2XkEUkpgG57bx/Cqzr4FN05Sa5P6kBt7X3FZ7sWZD5wGlHh6+ZTQew5prN0OqLZ GzRjYYd1cyoxgbE2QcM1YH28aaoTrGYG2Jd6H1EiZQOlWbKaiQxhbsnNHmImbztRr1cl Mw+OG0+shQIFppfD4KncRQcAda//qokDNV29e7MLWEOvfK0ZNGGJA9dizXngJUOKh6P2 xOoA== X-Gm-Message-State: ANoB5plAa9JY5jutNftFXD33Mryyo0VQB9uJYTO/S1O++dsg2jF9qHHX +B5gKcv8CTzz3tfmktRbF/HjBQ== X-Google-Smtp-Source: AA0mqf5YORHL5xhY4w8QqEjEt6mP1L5AvXuK5wuAdacXYewzC1TfB6Hz/F541WQCWirzdXPkyQskLA== X-Received: by 2002:a19:7b0f:0:b0:4a2:3bed:2008 with SMTP id w15-20020a197b0f000000b004a23bed2008mr22732329lfc.88.1669853223337; Wed, 30 Nov 2022 16:07:03 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id d10-20020a0565123d0a00b004b4b90a6992sm426023lfv.95.2022.11.30.16.07.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 16:07:03 -0800 (PST) Message-ID: <7bf73466-e476-4a1d-5dc0-1b63ea742226@linaro.org> Date: Thu, 1 Dec 2022 02:07:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v6 1/4] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint Content-Language: en-GB To: Kuogee Hsieh , dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, dianders@chromium.org, vkoul@kernel.org, daniel@ffwll.ch, airlied@linux.ie, agross@kernel.org, bjorn.andersson@linaro.org Cc: quic_abhinavk@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1669852310-22360-1-git-send-email-quic_khsieh@quicinc.com> <1669852310-22360-2-git-send-email-quic_khsieh@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <1669852310-22360-2-git-send-email-quic_khsieh@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 01/12/2022 01:51, Kuogee Hsieh wrote: > Move data-lanes property from mdss_dp node to dp_out endpoint. Also > add link-frequencies property into dp_out endpoint as well. The last > frequency specified at link-frequencies will be the max link rate > supported by DP. > > Changes in v5: > -- revert changes at sc7180.dtsi and sc7280.dtsi > -- add &dp_out to sc7180-trogdor.dtsi and sc7280-herobrine.dtsi > > Changes in v6: > -- add data-lanes and link-frequencies to yaml > > Signed-off-by: Kuogee Hsieh > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 17 +++++++++++++++++ Separate patch. Also you didn't check the get_maintainers output, so required parties were not included into the distribution. Also as you'd check the get_maintainers output, please fix other email addresses too. > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++++- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 6 +++++- > 3 files changed, 27 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index 94bc6e1..af70343 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -90,6 +90,20 @@ properties: > $ref: /schemas/graph.yaml#/properties/port > description: Output endpoint of the controller > > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + > + properties: > + link-frequencies: true > + data-lanes: true No. Use $ref for both of them. > + > + required: > + - link-frequencies > + - data-lanes No, they are not required. > + > + additionalProperties: false > + deprecation of old data-lanes property? > required: > - compatible > - reg > @@ -158,6 +172,9 @@ examples: > reg = <1>; > endpoint { > remote-endpoint = <&typec>; > + data-lanes = <1 2>; > + link-frequencies = /bits/ 64 <160000000 270000000 > + 540000000 810000000>; I guess the number of zeroes is wrong here. This is 160 MHz ... 810 Mhz, rather than 1.6 GHz ... 8.1 GHz > }; > }; > }; > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 754d2d6..39f0844 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -812,7 +812,11 @@ hp_i2c: &i2c9 { > status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&dp_hot_plug_det>; > - data-lanes = <0 1>; > +}; > + > +&dp_out { > + data-lanes = <0 1>; > + link-frequencies = /bits/ 64 <160000000 270000000 540000000>; Same comment here. > }; > > &pm6150_adc { > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > index 93e39fc..b7c343d 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -440,7 +440,11 @@ ap_i2c_tpm: &i2c14 { > status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&dp_hot_plug_det>; > - data-lanes = <0 1>; > +}; > + > +&dp_out { > + data-lanes = <0 1>; > + link-frequencies = /bits/ 64 <160000000 270000000 540000000 810000000>; And here. > }; > > &mdss_mdp { -- With best wishes Dmitry