From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6BD71B967 for ; Tue, 16 Jan 2024 12:00:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wuDGRZwC" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-50e9e5c97e1so12175533e87.0 for ; Tue, 16 Jan 2024 04:00:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705406407; x=1706011207; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2Wev8/+JRwMgshjlE6OA248QtJUcrnDfEQAw9G9glt4=; b=wuDGRZwCaOjiLTlWozSgUpoRxBdZfw22TJp3Fb6RYgOxZGvT2QZO10nl6uZSUcWx62 BtDFU2m6gPoSjJ7MPUnccJAVcYI5aqyLXqVAO9OAAdH3zJ1abkt6CCnrcC6Q0NEz79zO GUA9651QrtLh4VMBcH9HUDUTrlTrs7tQC+UWNOjkbnfwt+rcjpgntxMbBdmmTByAJjD5 NMZb3aSjrYcsEn0fWevDNQ8TlDqeL3jcZYhpRqVOf6NkojoXWNCpzzOrEvnarzIPeX4s +/ImilVI7jSFDAhJIs74sijhdDCzsUQcTlsqgtsfDtqkVkN0pK0Arap/L1OhR6UyZXy8 GHOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705406407; x=1706011207; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2Wev8/+JRwMgshjlE6OA248QtJUcrnDfEQAw9G9glt4=; b=epGxXLqf17R4zAgpOTC3rFiwMyww0IzeyH97Uw+iEOg33R2h1/x2JXwcz0L4bfjyRa FstP+9P9e/DXwLdheM6VYLQ5HSfJ8SeoOYDL+GePs2SP4O+FZWpfpYM2zT+YbR6IOCYY BnVR4OkpMPqH1qGU2xSP7XGu88hjtViGdgwDzUI26YY+7GnIVRRyIJzaMnZP7NamYlKR 6vQngUKSDkpQWH/XkT5u4KgwLWgJe1X06Gs+FMxzNLH4Zy7llTjd6sIbbNUGzrgHqHXs uKbtjbeyPM1UtLBIjIFvVs5/hIgSCdVYYotvIbC54X7EZqE+tLOLURVK7dXQm3TW/WYH JRYw== X-Gm-Message-State: AOJu0YzM75rLsfwtxedEbX2ajt653eCgiNp3SAx8L2uPsSk0M/8uEMAQ jx0sYg8hfVW1Op1/KFz+Xsc4OwUpoif3ag== X-Google-Smtp-Source: AGHT+IGfc6+yVYgBAet9fiwwSrpIoLDwtTHC0NEVx2i+LqboNZyB4n5xocQOM/TgazP+gwt7vgS4Mw== X-Received: by 2002:a05:6512:39d2:b0:50e:7b01:70df with SMTP id k18-20020a05651239d200b0050e7b0170dfmr4282250lfu.72.1705406406987; Tue, 16 Jan 2024 04:00:06 -0800 (PST) Received: from [172.30.204.234] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id f3-20020a056512092300b0050e7a2be0f8sm1724362lft.191.2024.01.16.04.00.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jan 2024 04:00:06 -0800 (PST) Message-ID: <7c86a91f-0339-4100-81a7-55f95cfcc18e@linaro.org> Date: Tue, 16 Jan 2024 13:00:04 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] arm64: dts: qcom: qcm2290: declare VLS CLAMP register for USB3 PHY Content-Language: en-US To: Dmitry Baryshkov , Bjorn Andersson , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Jeffrey Hugo Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org References: <20240116-usbc-phy-vls-clamp-v1-0-73b2da7691c5@linaro.org> <20240116-usbc-phy-vls-clamp-v1-5-73b2da7691c5@linaro.org> From: Konrad Dybcio In-Reply-To: <20240116-usbc-phy-vls-clamp-v1-5-73b2da7691c5@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/16/24 02:08, Dmitry Baryshkov wrote: > The USB3 PHY on the QCM2290 platform doesn't have built-in > PCS_MISC_CLAMP_ENABLE register. Instead clamping is handled separately > via the register in the TCSR space. Declare corresponding register. > > Fixes: 0c55f6229bc3 ("arm64: dts: qcom: qcm2290: Add USB3 PHY") > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/qcm2290.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > index 0911fb08ed63..68b52e8faba5 100644 > --- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > @@ -442,6 +442,11 @@ tcsr_mutex: hwlock@340000 { > #hwlock-cells = <1>; > }; > > + tcsr_regs_1: syscon@360000 { > + compatible = "qcom,qcm2290-tcsr", "syscon"; > + reg = <0x0 0x00360000 0x0 0x20000>; > + }; > + > tlmm: pinctrl@500000 { > compatible = "qcom,qcm2290-tlmm"; > reg = <0x0 0x00500000 0x0 0x300000>; > @@ -690,6 +695,8 @@ usb_qmpphy: phy@1615000 { > > #phy-cells = <0>; > > + qcom,tcsr-reg = <&tcsr_regs_1 0x6b244>; This also leaks outside the syscon space. Konrad