Re: [PATCH v2] arm64: dts: qcom: Add Dell Inspiron 14 Plus 5441

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 5/8/26 7:08 AM, Adam Szyma wrote:
> Add device tree for the Dell Inspiron 14 Plus 5441 laptop which uses
> the Qualcomm Snapdragon X Plus X1P64100 SoC. The device shares the
> same platform (Thena) as the Dell Inspiron 14 Plus 7441 and Dell
> Latitude 7455, and reuses the x1-dell-thena.dtsi include.
> 
> The 5441 has 2 speakers only (no front tweeters), so the tweeter
> nodes from x1-dell-thena.dtsi are deleted. There is no touchscreen.
> 
> Signed-off-by: Adam Szyma <adamszyma@wp.pl>
> ---
>  arch/arm64/boot/dts/qcom/Makefile             |  2 +
>  .../x1p64100-dell-inspiron-14-plus-5441.dts   | 44 +++++++++++++++++++
>  2 files changed, 46 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/x1p64100-dell-inspiron-14-plus-5441.dts
> 
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 4ba8e7306..81e058a22 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -449,3 +449,5 @@ x1p42100-lenovo-thinkbook-16-el2-dtbs	:= x1p42100-lenovo-thinkbook-16.dtb x1-el2
>  dtb-$(CONFIG_ARCH_QCOM)	+= x1p42100-lenovo-thinkbook-16.dtb x1p42100-lenovo-thinkbook-16-el2.dtb
>  x1p64100-microsoft-denali-el2-dtbs	:= x1p64100-microsoft-denali.dtb x1-el2.dtbo
>  dtb-$(CONFIG_ARCH_QCOM)	+= x1p64100-microsoft-denali.dtb x1p64100-microsoft-denali-el2.dtb
> +x1p64100-dell-inspiron-14-plus-5441-el2-dtbs	:= x1p64100-dell-inspiron-14-plus-5441.dtb x1-el2.dtbo
> +dtb-$(CONFIG_ARCH_QCOM)	+= x1p64100-dell-inspiron-14-plus-5441.dtb x1p64100-dell-inspiron-14-plus-5441-el2.dtb
> diff --git a/arch/arm64/boot/dts/qcom/x1p64100-dell-inspiron-14-plus-5441.dts b/arch/arm64/boot/dts/qcom/x1p64100-dell-inspiron-14-plus-5441.dts
> new file mode 100644
> index 000000000..b9e9ee417
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/x1p64100-dell-inspiron-14-plus-5441.dts
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2026 Adam Szyma <adamszyma@wp.pl>
> + */
> +
> +/dts-v1/;
> +#include "hamoa.dtsi"
> +#include "x1-dell-thena.dtsi"
> +
> +/ {
> +	model = "Dell Inspiron 14 Plus 5441";
> +	compatible = "dell,inspiron-14-plus-5441",
> +		     "qcom,x1p64100", "qcom,x1e80100";
> +};
> +
> +&sound {
> +	model = "X1E80100-Dell-Inspiron-14p-5441";
> +	/delete-node/ speaker@0,1;

I'm a little surprised this compiles.. but this doesn't do what you'd like
it to - it would, if the speaker@0,1 node was a child of the node bearing
the 'sound' label.

Also, I'm going to assume that the 2spk configuration follows other
machines, where only a single soundwire host is used (i.e. "left tweeter"
is actually "right speaker"), rather than the two soundwire hosts normally
used to house 2 speakers each only being utilized to drive one per side

To remove the inexistent ones, add:

/delete-node/ &right_woofer;
/delete-node/ &right_tweeter;

And re-label the existing ones:

left_spkr: &left_woofer {};
right_spkr: &left_tweeter {};

(customarily between the includes and the root node ("/ {"))

And then because these labels cease to exist, you'll need to make
adjustments to anything that references them, which I think will be
best to do as:

&wsa_playback_codec {
	sound-dai = <&left_spkr>, <&right_spkr>,
		    <&swr0 0>, <&lpass_wsamacro 0>;
};

And at last, to disable the now-unused swr3 host:

&swr3 {
	status = "disabled";
};
> +};
> +
> +&gpu {
> +	status = "okay";
> +};
> +
> +&gpu_zap_shader {
> +	firmware-name = "qcom/x1e80100/dell/inspiron-14-plus-5441/qcdxkmsuc8380.mbn";
> +};
> +
> +&iris {
> +	firmware-name = "qcom/x1e80100/dell/inspiron-14-plus-5441/qcvss8380.mbn";
> +	status = "okay";

Please also keep a uniform \n before 'status'

Konrad