From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE485211276 for ; Fri, 28 Mar 2025 05:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743139053; cv=none; b=bGCE4ZmFaU4RP+hQLI7R0wcMRd/G1jTeAWdXKIuax8tBqidTRHAouOyQcgB8Xqej04H7mbrAdTYIL6VrdcCXuLpjIlhslat1v4+w69ZqGDioUwVo3HCRJ1gSZ17QQCDJMTP7yLEYv7KdpvMwwu5vkB9rUdXIcacLqcWTA67yOGw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743139053; c=relaxed/simple; bh=CS5VMMk0LUE5wGq9IgIbXDHaQ2F3DWmXr4+f0/6topA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L0walKd8SrbAi1p3NyaSOWCx/iMP65aXV1oxe8eRABM+Qjoix8nEQDlf3mIVsyqzGctC+AulmSaSlEvlXJ32xDdWHkD29Pp50lRTLgPQyf0OS8sjgtwvbD3qgyBIuciIXVxL9BVbIwdvb1XmxvDmFmXUu2fgD80JzId+L40AzA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M+QPkzpt; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M+QPkzpt" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52RFILXD013761 for ; Fri, 28 Mar 2025 05:17:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HQgkYP40+p7+yHQUfnTVW3yGM29lJJuQVYPsqQvyoQY=; b=M+QPkzptLgiuhzRe BaqsaoWSuwcjSGk6EjXMN5en4gjxQl7jP2AuzoFMB93ZkDFLG+8Jcz4ahUYliavt DrRbu80T9CYxAsf4qIhgmkWldM39JMYlhV1w4Mw3YDu3BBMEJrU7xuz5VBzmfRg1 AqctpupqSwEhNilFjcneL5futNMheZXfXoypfMX6YY/gio734IpobucYDrMyEHzd AGRCQckKH0q0F8ARB6Cd/JvKbS6bvbFcIcJAJ2A90t4mrS5/0k/vZXdKXJ4xm7pb XRPfQzfCHu7NU/2X24mh9MP+Jt8bsD9qaCkwD/0lNdBSBTUyNL8/0zvXpXENCPqx yI33wA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45mffcp4y7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 28 Mar 2025 05:17:25 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-304cf76fd6aso3275177a91.2 for ; Thu, 27 Mar 2025 22:17:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743139044; x=1743743844; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HQgkYP40+p7+yHQUfnTVW3yGM29lJJuQVYPsqQvyoQY=; b=KdgB9RIe3siGyQnpYfCcLaSaYfz/Q6YLAAdNc0JE6vNG9q/ydrtYDcMgBheiMhsHxS b4HTjDIvr74eaApf8U2+n1VFk5WnNUQtFQ4Tf7KPaeXIBnMUsWs1rsluVTuavrEVyAEB jmNf7F0oN7U7SZinSuPnCqWIKNo5DugGrek8M9iE1nNojDujQxnh6E8h/gt8iV31KBcI zuZ3jUI5jmsOI5CtuXimmOimN+JaHngIbxZmid82z6GkMiWxyjb6nxWbWH6T/NpsCLCe ZHybNStnPkSR/oLKQ8rd2Se7+MzYUjTU1949erA0Y2D6mPhmnavq0L94BW0lvPgGbHqZ TXSg== X-Forwarded-Encrypted: i=1; AJvYcCWCIJB8XgE07YA/Djyn/PDDCUxHF0JlogPS2hE+VT9l9XWurHGEhH+NPIbz6Gd+FAZDv5O6c/mC6Skc+KHE@vger.kernel.org X-Gm-Message-State: AOJu0YwzXyAN2FmzB0vw3guDc/DYc1X521JBXMr7lrVdLJPrtsUOkVaH A2QzY5JCfMrOkbGEK30yPDWkqJycJGr6FCJqgV8wwyLRXhHw1KtfcCkmvbyWOdLEj8CpCcys4so AEkZm2OshGg9hhe3n9BbKfBIaze1zamV0TgpoIluqLVzwl3vDctsWKLksUsCyM+19 X-Gm-Gg: ASbGnctpUZq55C7ke0CAWKP9U5L7nIGwqfn9CwQWEldxBQpMsG78Rn6+IWAPGR4W91e 00rCq1+/6AlxYn1/lziSMwSKspg3GErO/M4Co04KbNBD3+vlKG3ybXtlgnnpZxlIFb04ykbhffP vwoOslQU/e8dQ+qjEqH+aL6VNSX07k/bsZFC9E4jcXi1XJc+W8S6OlZLvcJA5vPgnh1rLT/AaeF o9xoF9YkcviE2XlU54Rjks5ZeAxqVEgJ43iqkIIga472yGjc57mm5rIyzlTHMYi4VX3zbPJpAcD C+FICSOYy6eLTzkfg+f20Ej4oRH1k//hYc1l6jgKibmulT2AjUrUcA== X-Received: by 2002:a05:6a20:7f98:b0:1f5:769a:a4c3 with SMTP id adf61e73a8af0-1fea2f396e8mr10316352637.27.1743139043457; Thu, 27 Mar 2025 22:17:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVTpXZbP8MYkTaSUxvCf6P7tZPuQ3S9l3jbd9DcFaTnK18JUIF8nKYAtQNBzPJZrQEUQnBHg== X-Received: by 2002:a05:6a20:7f98:b0:1f5:769a:a4c3 with SMTP id adf61e73a8af0-1fea2f396e8mr10316280637.27.1743139042853; Thu, 27 Mar 2025 22:17:22 -0700 (PDT) Received: from [192.168.0.113] ([183.82.177.119]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af93b8b1aa6sm792238a12.52.2025.03.27.22.17.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Mar 2025 22:17:22 -0700 (PDT) Message-ID: <7ce80ffb-6519-4765-8418-42135ab07a3f@oss.qualcomm.com> Date: Fri, 28 Mar 2025 10:47:16 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 0/8] Add new driver for WCSS secure PIL loading To: Jeff Johnson , Gokul Sriram Palanisamy , jassisinghbrar@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, mathieu.poirier@linaro.org, konradybcio@kernel.org, quic_mmanikan@quicinc.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org, dmitry.baryshkov@linaro.org Cc: quic_viswanat@quicinc.com, quic_srichara@quicinc.com References: <20250107101647.2087358-1-quic_gokulsri@quicinc.com> <4b624830-00eb-46e8-ae5a-b822e32b2005@quicinc.com> Content-Language: en-US From: Vignesh Viswanathan In-Reply-To: <4b624830-00eb-46e8-ae5a-b822e32b2005@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=CdgI5Krl c=1 sm=1 tr=0 ts=67e630e5 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=VrYi6RMOWE5NFa6aqCLEpg==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=LpQP-O61AAAA:8 a=atyioMQIshmohzJ9PWcA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=TjNXssC_j7lpFel5tvFf:22 a=pioyyrs4ZptJ924tMmac:22 X-Proofpoint-GUID: 2pGDzrYVZyxwcQD61cjHfAJw5LEiSjio X-Proofpoint-ORIG-GUID: 2pGDzrYVZyxwcQD61cjHfAJw5LEiSjio X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-28_02,2025-03-27_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 phishscore=0 clxscore=1011 bulkscore=0 impostorscore=0 adultscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503280034 On 1/24/2025 11:30 PM, Jeff Johnson wrote: > On 1/7/25 02:16, Gokul Sriram Palanisamy wrote: >> This series depends on Sricharan's tmel-qmp mailbox driver series v2 [1]. >> >> - Secure PIL is signed, split firmware images which only TrustZone (TZ) >> can authenticate and load. Linux kernel will send a request to TZ to >> authenticate and load the PIL images. >> >> - When secure PIL support was added to the existing wcss PIL driver >> earlier in [2], Bjorn suggested not to overload the existing WCSS >> rproc driver, instead post a new driver for PAS based IPQ WCSS driver. >> This series adds a new secure PIL driver for the same. >> >> - Also adds changes to scm to pass metadata size as required for IPQ5332, >> reposted from [3]. >> >> [1] >> https://patchwork.kernel.org/project/linux-arm-msm/cover/20241231054900.2144961-1-quic_srichara@quicinc.com/ >> >> [2] >> https://patchwork.kernel.org/project/linux-arm-msm/patch/1611984013-10201-3-git-send-email-gokulsri@codeaurora.org/ >> >> [3] >> https://patchwork.kernel.org/project/linux-arm-msm/patch/20240820055618.267554-6-quic_gokulsri@quicinc.com/ >> >> changes in v3: >> - fixed copyright years and markings based on Jeff's comments. >> - replaced devm_ioremap_wc() with ioremap_wc() in >> wcss_sec_copy_segment(). >> - replaced rproc_alloc() and rproc_add() with their devres >> counterparts. >> - added mailbox call to tmelcom for secure image authentication >> as required for IPQ5424. Added ipq5424 APCS comatible required. >> - added changes to scm call to pass metadata size as equired for >> IPQ5332. >> >> changes in v2: >> - Removed dependency of this series to q6 clock removal series >> as recommended by Krzysztof >> >> Gokul Sriram Palanisamy (3): >> dt-bindings: mailbox: qcom: Add IPQ5424 APCS compatible >> mailbox: qcom: Add support for IPQ5424 APCS IPC >> arm64: dts: qcom: ipq5424: add nodes to bring up q6 >> >> Manikanta Mylavarapu (4): >> firmware: qcom_scm: ipq5332: add support to pass metadata size >> dt-bindings: remoteproc: qcom: document hexagon based WCSS secure PIL >> arm64: dts: qcom: ipq5332: add nodes to bringup q6 >> arm64: dts: qcom: ipq9574: add nodes to bring up q6 >> >> Vignesh Viswanathan (1): >> remoteproc: qcom: add hexagon based WCSS secure PIL driver >> >> .../mailbox/qcom,apcs-kpss-global.yaml | 1 + >> .../remoteproc/qcom,wcss-sec-pil.yaml | 131 ++++++ >> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 64 ++- >> arch/arm64/boot/dts/qcom/ipq5424.dtsi | 80 +++- >> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 60 ++- >> drivers/firmware/qcom/qcom_scm.c | 13 +- >> drivers/firmware/qcom/qcom_scm.h | 1 + >> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 + >> drivers/remoteproc/Kconfig | 22 + >> drivers/remoteproc/Makefile | 1 + >> drivers/remoteproc/qcom_q6v5_wcss_sec.c | 406 ++++++++++++++++++ >> 11 files changed, 775 insertions(+), 5 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,wcss-sec-pil.yaml >> create mode 100644 drivers/remoteproc/qcom_q6v5_wcss_sec.c >> > > This series is listed as a dependency of a WLAN series, and when I pull this > series using my automation I see the following kernel-doc warnings. I don't > know if these are existing issues, or issues introduced by the series, since > the automation runs kernel-doc on all of the patched files. > > drivers/firmware/qcom/qcom_scm.c:302: warning: No description found for return value of 'qcom_scm_call' > drivers/firmware/qcom/qcom_scm.c:328: warning: No description found for return value of 'qcom_scm_call_atomic' > drivers/firmware/qcom/qcom_scm.c:425: warning: No description found for return value of 'qcom_scm_set_warm_boot_addr' > drivers/firmware/qcom/qcom_scm.c:438: warning: No description found for return value of 'qcom_scm_set_cold_boot_addr' > drivers/firmware/qcom/qcom_scm.c:675: warning: No description found for return value of 'qcom_scm_pas_mem_setup' > drivers/firmware/qcom/qcom_scm.c:714: warning: No description found for return value of 'qcom_scm_pas_auth_and_reset' > drivers/firmware/qcom/qcom_scm.c:750: warning: No description found for return value of 'qcom_scm_pas_shutdown' > drivers/firmware/qcom/qcom_scm.c:787: warning: No description found for return value of 'qcom_scm_pas_supported' > drivers/firmware/qcom/qcom_scm.c:892: warning: No description found for return value of 'qcom_scm_restore_sec_cfg_available' > drivers/firmware/qcom/qcom_scm.c:1070: warning: No description found for return value of 'qcom_scm_assign_mem' > drivers/firmware/qcom/qcom_scm.c:1141: warning: No description found for return value of 'qcom_scm_ocmem_lock_available' > drivers/firmware/qcom/qcom_scm.c:1158: warning: No description found for return value of 'qcom_scm_ocmem_lock' > drivers/firmware/qcom/qcom_scm.c:1182: warning: No description found for return value of 'qcom_scm_ocmem_unlock' > drivers/firmware/qcom/qcom_scm.c:1298: warning: No description found for return value of 'qcom_scm_hdcp_available' > drivers/firmware/qcom/qcom_scm.c:1323: warning: No description found for return value of 'qcom_scm_hdcp_req' > drivers/firmware/qcom/qcom_scm.c:1879: warning: No description found for return value of 'qcom_scm_is_available' > drivers/firmware/qcom/qcom_scm.h:47: warning: missing initial short description on line: > * struct qcom_scm_desc > drivers/firmware/qcom/qcom_scm.h:57: warning: Function parameter or struct member 'svc' not described in 'qcom_scm_desc' > drivers/firmware/qcom/qcom_scm.h:57: warning: Function parameter or struct member 'cmd' not described in 'qcom_scm_desc' > drivers/firmware/qcom/qcom_scm.h:57: warning: Function parameter or struct member 'owner' not described in 'qcom_scm_desc' > drivers/firmware/qcom/qcom_scm.h:60: warning: missing initial short description on line: > * struct qcom_scm_res > 21 warnings as Errors Hi Jeff, These warnings are not introduced as part of this series. Thanks, Vignesh > >