From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] clk: qcom: common: Add support for power-domain attachment
Date: Fri, 29 Nov 2024 11:39:52 +0000 [thread overview]
Message-ID: <7cf4ce25-742c-48ff-99e0-bbbaea370e89@linaro.org> (raw)
In-Reply-To: <9b9bf718-b5a5-4fef-810a-1206743495f6@linaro.org>
On 29/11/2024 11:30, Vladimir Zapolskiy wrote:
>> + ret = devm_pm_domain_attach_list(dev, &pd_data, &cc->pd_list);
>
> Please make a call to the function like this:
>
> ret = devm_pm_domain_attach_list(dev, NULL, &cc->pd_list);
Passing &pd_data will cause devm_pd_domain_attach_list() to cycle
through the power-domains listed and do dev_pm_domain_attach_by_id();
instead of dv_pm_domain_attach_by_name();
That's what &pd_data is passed here. You want to have that simple
attachment of the power-domain list.
---
bod
next prev parent reply other threads:[~2024-11-29 11:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 16:37 [PATCH v5 0/3] clk: qcom: Add support for multiple power-domains for a clock controller Bryan O'Donoghue
2024-11-28 16:38 ` [PATCH v5 1/3] clk: qcom: gdsc: Capture pm_genpd_add_subdomain result code Bryan O'Donoghue
2024-11-28 16:38 ` [PATCH v5 2/3] clk: qcom: common: Add support for power-domain attachment Bryan O'Donoghue
2024-11-29 11:30 ` Vladimir Zapolskiy
2024-11-29 11:39 ` Bryan O'Donoghue [this message]
2024-11-29 11:44 ` Vladimir Zapolskiy
2024-11-29 12:44 ` Bryan O'Donoghue
2024-11-28 16:38 ` [PATCH v5 3/3] clk: qcom: Support attaching GDSCs to multiple parents Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cf4ce25-742c-48ff-99e0-bbbaea370e89@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox