From: Val Packett <val@packett.cool>
To: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@kernel.org>,
Stefan Schmidt <stefan.schmidt@linaro.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: iris: Refine internal buffer reconfiguration logic for resolution change
Date: Tue, 4 Nov 2025 20:50:20 -0300 [thread overview]
Message-ID: <7d26e4e9-e298-4991-883f-ceb60f240394@packett.cool> (raw)
In-Reply-To: <20251104-iris-seek-fix-v2-1-c9dace39b43d@oss.qualcomm.com>
On 11/4/25 2:11 AM, Dikshita Agarwal wrote:
> [..]
> --- a/drivers/media/platform/qcom/iris/iris_common.c
> +++ b/drivers/media/platform/qcom/iris/iris_common.c
> @@ -91,12 +91,13 @@ int iris_process_streamon_input(struct iris_inst *inst)
> int iris_process_streamon_output(struct iris_inst *inst)
> {
> const struct iris_hfi_command_ops *hfi_ops = inst->core->hfi_ops;
> - bool drain_active = false, drc_active = false;
> enum iris_inst_sub_state clear_sub_state = 0;
> int ret = 0;
>
> [..]
Somehow, you have lost the + edited line that declares the bools.. Hence
the CI failure reported for v1, and the kernel test robot message from
just a couple minutes ago.
But with `bool first_ipsc = false, drain_active = false, drc_active =
false;` filled in,
Tested-by: Val Packett <val@packett.cool>
finally the decoder is actually usable \o/
~val
next prev parent reply other threads:[~2025-11-04 23:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 5:11 [PATCH v2] media: iris: Refine internal buffer reconfiguration logic for resolution change Dikshita Agarwal
2025-11-04 23:46 ` kernel test robot
2025-11-04 23:50 ` Val Packett [this message]
2025-11-05 8:23 ` Dikshita Agarwal
2025-11-05 0:46 ` Dmitry Baryshkov
2025-11-05 1:08 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d26e4e9-e298-4991-883f-ceb60f240394@packett.cool \
--to=val@packett.cool \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=hverkuil@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stefan.schmidt@linaro.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox