From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E21713E2740 for ; Wed, 25 Mar 2026 15:14:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774451689; cv=none; b=mLIMdiOyGKpuxau6LdLJQKO63fpe3nnXhkDP2wl1XZ5ZrIZWSdUUMZohUEJlIgRfFgcnRPHU9B2lFBl9i7rKX+nmGevGhGC/LGb1xKno6lQy0FdAwKJzQdvLOuNctdYJA5OUPrIJweivyjm2W6gqgNOWFfw9TnwlvPpEDlEdwms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774451689; c=relaxed/simple; bh=rcShfDxb0SWVUoYsT+a4OUOe9fGgAM8/hMD9dz9s7Qk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NOSG6eEvAg1IWxtoMhH51xi8uW5MRHtGT2YrUVfvj7Vy7z3d+r6B55taCxL3TC+0GV9jrdWzW6U2AOhYFVKyeGuTGocMySk7T0oog5Wdi4INZhFTgIMeoeTobW7SOBiQsacQq+vukWy/zE+zkY6jxQeTHjbI2Py7RjW4ha57l+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iBZWJdn9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Dh/QOdHt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iBZWJdn9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Dh/QOdHt" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PBGXh6051815 for ; Wed, 25 Mar 2026 15:14:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= x7j3ryAcBMvHA8/N9VGk+JyVdzzgELfi5f6qP5tgez8=; b=iBZWJdn96S7kNo0K kQu6HMNiVVJBhY1PYontI5d4cBONCTnOG4CqdX18E2iP9s7y87dXZgdZeOLCdpzA 6qkHUiaqgoQj6lh8awR4BMrnR6KxWAMTlfx0UV+F2wrMw7wOgw+8ARweBoG/3lYb 1HNb+ImxHYJJQayhygppfqeDTrH/4oFZDMVhEZ764ymVQKLbyzVtVRIafzo6F0DV 54N1RwPZ1XF26jEJr8k6q5bCKTfQIDlSdkeXZcoznRVPGew3vy/haW7hTygGsqfq FgWJ4zqbfUK+li7wsSNCwgZSmQ0xH/oDi7ILHlJ0OdwjfyJRGjXRcJXVdwWh8xiE zXQisQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d46tp2mw5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Mar 2026 15:14:47 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-829b8bb5211so17023860b3a.2 for ; Wed, 25 Mar 2026 08:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774451686; x=1775056486; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=x7j3ryAcBMvHA8/N9VGk+JyVdzzgELfi5f6qP5tgez8=; b=Dh/QOdHt9BynPzYzScu6vWgau/yAqOdwiSwt7XTmXN70xXpVE690jB3PRaMJ3CMWnj sm3sEKD2jnSTp6y7LLL3dda4dp/wUMyF05/5c+jb7iCUDA18Xabb4CqjWw+cTyOM6myD xa76iR/jBjsWkRmLBTxUV4ZJcOoL+Rwh9L3bl1rxwOV6QqGxj+V8mo3VBRSkDgb7vE7G Z1LACovobXaCp4XnW3mhBhamb00JAus1b38H4HEwxXtfqfenIGG3cCL52RX7wK47KuJy IumFOyDzaRrRcLAPWVAWkK71o6QnIEjweYOHMRobMX+v9z/gcLTGzrcNtAmvvgqXFfAf yJFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774451686; x=1775056486; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x7j3ryAcBMvHA8/N9VGk+JyVdzzgELfi5f6qP5tgez8=; b=GDLMV3L2ieD7y0X159AnG5G4RBgGveNzX22Xm7SY/dvzSv3vo3oUAJqSRHXpwiAmSx PMx1z0AnemiGxRRYxT/E5d+4qqlPvo/0ZuFDEk0zYsQSvhITA9KJO56S87RS/+A2TZBJ OVz7mHzTSlxo2W+aVirLj9p3nKCMaBEWT8YvoaRq12/pmPbQseyT3MNVlm4ninBJChI+ X14ACYHlRSjG+sjG7JzSbM25zyIFLiifntUfDPD5Fq4XSjqxzxOtTeTDKYmL+gvy9Gxu MR7TZ0ncllECRAWODb6c8XXbTV8+AnN3joH1o+I7REztXpjOPjqdQlTnCXFpjlLfB5JN 4uCg== X-Gm-Message-State: AOJu0YwHE82rI091/mu5KbX1aMKtoh5sDBEnWaCxpQMVSqrS+V+ZIp/w cGmL7kaVxLoiOg8YFoF/G09GqyGwOu05zRYbawCq4+sOVrPPL/V4UQhG/TZs4rsN7vH8GPKBWaA vufL0TxRCKS4oMAL4c92vudN98jrMMT9LCmgmKw+oG8UPpoX8cwCHp5rfBW5qe6q/k9Nv X-Gm-Gg: ATEYQzxRvQOWUyrEfypwL2bq7n1D9Rv9Qikt85T2JlZiDbymhIdRBxo1Luo8rIR/b/h OfA83DEFtM2szwAEirtrf4TEEOgcf45wTAJiDP88fT9YQBANx3ryeT0bAry1fCHhjatsdxSrh9C vG2niUAdiHHzeE6OMGarg0ZuVEUqX5a15rfy6fTwXLuvDYQEwHzw5O5ya0viXAJ0E6O2HVFW31Y 78FKfQnRZk5+ikLFW+bdEXW1f1SrGls8zs0WGFMRWkhRmGtfL0GbxfPALJ8Kyd38ZN5dO/zgOx0 iT6XKrwuK2nS/2PNAobaYU7JsU+sQRH1h2c1cSJNpY/kjvekTVuWGpjcJLQV1zD93/hVL/q9uTE OrM6SbAAyNJvKiDQs9ShSdukxbcbIRadIgyt/5PhBdFu79eOc3e1SPg== X-Received: by 2002:a05:6a00:4147:b0:829:803e:678b with SMTP id d2e1a72fcca58-82c6e1039c5mr3966020b3a.54.1774451686468; Wed, 25 Mar 2026 08:14:46 -0700 (PDT) X-Received: by 2002:a05:6a00:4147:b0:829:803e:678b with SMTP id d2e1a72fcca58-82c6e1039c5mr3965989b3a.54.1774451685929; Wed, 25 Mar 2026 08:14:45 -0700 (PDT) Received: from [10.204.101.77] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82c7d1e619esm68019b3a.9.2026.03.25.08.14.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 08:14:45 -0700 (PDT) Message-ID: <7dbf7a23-7a02-4e9e-99c8-6716e3dcf7d9@oss.qualcomm.com> Date: Wed, 25 Mar 2026 20:44:37 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/7] media: iris: switch to hardware mode after firmware boot To: Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , Conor Dooley , Saravana Kannan , Joerg Roedel , Will Deacon , Robin Murphy , Stefan Schmidt , Hans Verkuil , Krzysztof Kozlowski , Vishnu Reddy , Hans Verkuil Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, Bryan O'Donoghue References: <20260313-kaanapali-iris-v3-0-9c0d1a67af4b@oss.qualcomm.com> <20260313-kaanapali-iris-v3-2-9c0d1a67af4b@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260313-kaanapali-iris-v3-2-9c0d1a67af4b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: N1XhbLsQPsdyC_ohO6Rj5P3SreyyhO8u X-Authority-Analysis: v=2.4 cv=F4lat6hN c=1 sm=1 tr=0 ts=69c3fbe7 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=dE1MpONsbtOZy1RxgbwA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: N1XhbLsQPsdyC_ohO6Rj5P3SreyyhO8u X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDEwOSBTYWx0ZWRfX0tymEknO57oQ 2FQYxOkX/UXPqXPJFXmHzS6uwZAThI0tU+fgc+AZWKdFPXURTbVFYOi6lyX9NImplKKcZfZ5FE2 9vWVq3nW+sdBx64VJO5+/kB7kxOVSSbYu3aSjshw+YAG7JMybZYJPkiSCDsa+hzFqE4WU1Tc35f SYhKlMU2UINVTJCEqKAN4+WxCsf4Z4md6HaQsm5nwfLDGiqwyH9hPyXtjZieAUaL6w/CdgyD766 yq8A3WyvyauQRRC0zbbh4wEvtV5sAbAikhslCzMtRfpsrBvXl5I0mP/Ok2GtBiYiPVDkKW5fAA9 D8O0b93eZAGRm7B2ZmkeMT0Ar5iZAUcaAYvvQLAAuhoDvj1uP8MdRHe+cO7MTmfl9A9kCw1sDEo x1uSSqAkFM6x5AM2DaQqD5xzeai+zgyN9L2+vAATq2Ev0EPIpGQjctu2WJZ94LMGvr0acd5cKCo Gs2/NcsEp7vgO4PLIMA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_04,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250109 On 3/13/2026 6:49 PM, Vikash Garodia wrote: > Currently the driver switches the vcodec GDSC to hardware (HW) mode > before firmware load and boot sequence. GDSC can be powered off, keeping > in hw mode, thereby the vcodec registers programmed in TrustZone (TZ) > carry default (reset) values. > Move the transition to HW mode after firmware load and boot sequence. > > The bug was exposed with driver configuring different stream ids to > different devices via iommu-map. With registers carrying reset values, > VPU would not generate desired stream-id, thereby leading to SMMU fault. > > For vpu4, when GDSC is switched to HW mode, there is a need to perform > the reset operation. Without reset, there are occassional issues of > register corruption observed. Hence the vpu GDSC switch also involves > the reset. > > Fixes: dde659d37036 ("media: iris: Introduce vpu ops for vpu4 with necessary hooks") > Co-developed-by: Vishnu Reddy > Signed-off-by: Vishnu Reddy > Signed-off-by: Vikash Garodia > --- Hi Bryan, Please pull this fix patch, let me know if you need me to resend this separately. Regards, Vikash