From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Ling Xu <quic_lxu5@quicinc.com>,
andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: quic_kuiw@quicinc.com, quic_ekangupt@quicinc.com,
kernel@quicinc.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] arm64: qcom: qcs8300: Add ADSP and CDSP0 fastrpc nodes
Date: Sat, 30 Nov 2024 14:43:07 +0100 [thread overview]
Message-ID: <7dc72269-63f0-4370-9564-e329bf53ea66@oss.qualcomm.com> (raw)
In-Reply-To: <20241119120635.687936-1-quic_lxu5@quicinc.com>
On 19.11.2024 1:06 PM, Ling Xu wrote:
> Add ADSP and CDSP0 fastrpc nodes for QCS8300 platform.
>
> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
> ---
> This patch depends on patch https://lore.kernel.org/all/20240904-qcs8300_initial_dtsi-v1-0-d0ea9afdc007@quicinc.com/#t
> Changes since v1:
> - Remove duplicate cdsp fastrpc nodes
> - Add adsp memory-region and vmids
> Changes since v2:
> - Remove extra duplicate cdsp fastrpc nodes
You removed effectively- duplicate iommus entries, no nodes were
removed compared to v2.
Also, I hope you gave this a smoke test, as some platforms in the
past had very strict sid/mask matching policies that didn't really
evaluate the effective value.
But it looks good now
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2024-11-30 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 12:06 [PATCH v3] arm64: qcom: qcs8300: Add ADSP and CDSP0 fastrpc nodes Ling Xu
2024-11-30 13:43 ` Konrad Dybcio [this message]
2024-12-26 18:26 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dc72269-63f0-4370-9564-e329bf53ea66@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_ekangupt@quicinc.com \
--cc=quic_kuiw@quicinc.com \
--cc=quic_lxu5@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox