From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B0C7210FD for ; Sat, 13 Jan 2024 13:58:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tMgXDlTQ" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-40e6bf323e8so5099975e9.2 for ; Sat, 13 Jan 2024 05:58:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705154327; x=1705759127; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WT8QIYQ+4FB0VcFrJSjLO9Fc2EguI6T2KF8zu0XQvV4=; b=tMgXDlTQelvPFnKLtkLb2OwHnuAofGXGKN9p0to3S5VWeB+4KBlQHOji31Yewx1OD9 13FGoa2uAmWp14AE+o/ovhdGTM1R0B88WogQSaN4/pi1djLsFBom+YQVz/MvVDJu/EBN JJnGKqkhVYeiDP3wfi9n0pXO9dQ1Cm+i0qio2ghliWcb1u30rjTMhOwqaDFcvBo2jji2 CyG+xyajlQ6RAORymnfHR50b6/jmIP/MFJVuPYaAhETAlZW4FpunLq/+XLRZOAws4aWW J/bCyscW76F1UL6Rr3wu6l0u9D1y8+WmV1jPywmxJ9ISPlv4MjuHKoq5VJLtkE0Ci/ie 2fkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705154327; x=1705759127; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WT8QIYQ+4FB0VcFrJSjLO9Fc2EguI6T2KF8zu0XQvV4=; b=jiCjc2GRxyethNm6cfOayyDHMYO7IietuMkmFRd+8ZMOVvqC06AzDZ1O9Kd3+lIcEW NTIueJ1RmepqpuUAnVNvn7JSvXClk2A/RIyULVh5vZON6UOO+piqlrm8P7aZvknh3Sxa GELv36V5JCX2IBzDsUjHaFFCCEEDw7IqQDeYOihi/Qd0D7bVQn8NjFMzQ02VQe4oTcWn mL+cSHnxJgSJ3IsETv3jhp0zqselqFZ51W3WKv/SPQjKWk1ehFmzpd7QK2TrKGvlxeCh MQOzQjaAZaRCksGB5GgN6R/1yRvI3GqDY7v27HIuilcS81Qqt5jZVnv7x3IrnJyHfF0L tdCA== X-Gm-Message-State: AOJu0YyaikFWjNLzkCyLBMzfHpAHbUmDmUZw10mNhWYYrSDrZke8kr3D HoflICxt+8Hd8ebxnMwE+ovh/8e5hgVjYQ== X-Google-Smtp-Source: AGHT+IGwKJspmTKwK0oeydh5C+0W91YyLyDhfqNDMWTHwa14f1p0dzNVkcnuqnvLJgl8jRaN9pq7Yg== X-Received: by 2002:a05:600c:4e48:b0:40d:39cb:6af6 with SMTP id e8-20020a05600c4e4800b0040d39cb6af6mr1701326wmq.28.1705154327179; Sat, 13 Jan 2024 05:58:47 -0800 (PST) Received: from [192.168.100.86] ([37.228.218.3]) by smtp.gmail.com with ESMTPSA id h6-20020a05600c350600b0040c6d559490sm9476148wmq.3.2024.01.13.05.58.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jan 2024 05:58:46 -0800 (PST) Message-ID: <7e15bce2-977d-4b02-9f8e-6503383eb281@linaro.org> Date: Sat, 13 Jan 2024 13:58:45 +0000 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/13] usb: typec: qcom-pmic-typec: add support for PMI632 PMIC Content-Language: en-US To: Konrad Dybcio , Dmitry Baryshkov , Bjorn Andersson , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Greg Kroah-Hartman , Vinod Koul , Kishon Vijay Abraham I , Guenter Roeck , Heikki Krogerus , Philipp Zabel , Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org References: <20240113-pmi632-typec-v1-0-de7dfd459353@linaro.org> <20240113-pmi632-typec-v1-6-de7dfd459353@linaro.org> <7e36b380-8ab5-4555-8919-1c2c6ff7aa68@linaro.org> From: Bryan O'Donoghue In-Reply-To: <7e36b380-8ab5-4555-8919-1c2c6ff7aa68@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/01/2024 10:33, Konrad Dybcio wrote: > On 13.01.2024 06:42, Dmitry Baryshkov wrote: >> The PMI632 PMIC support Type-C port handling, but lacks USB >> PowerDelivery support. The TCPM requires all callbacks to be provided >> by the implementation. Implement a special, 'stub' Qcom PD PHY >> implementation to enable the PMI632 support. >> >> Signed-off-by: Dmitry Baryshkov >> --- > > [...] > >> #endif /* __QCOM_PMIC_TYPEC_PDPHY_H__ */ >> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy_stub.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy_stub.c >> new file mode 100644 >> index 000000000000..5d3b0e78d4d8 >> --- /dev/null >> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy_stub.c > > Not a fan. > > Maybe add some TCPM_FLAG_NO_PD and solve it in a generic manner? > > Konrad This is a good suggestion, provided its the direction Heikki and Guenter want to go. Otherwise @Dmitry you can retain my Acked-by for the stubification. --- bod