From: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
To: "Paweł Owoc" <frut3k7@gmail.com>
Cc: Robert Marko <robimarko@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: ipq8074: Remove unused gpio from QPIC pins
Date: Mon, 18 Mar 2024 11:20:57 +0530 [thread overview]
Message-ID: <7e1df07d-d047-4cfe-bfdd-fb17d0daf158@quicinc.com> (raw)
In-Reply-To: <20240313102713.1727458-1-frut3k7@gmail.com>
On 3/13/2024 3:57 PM, Paweł Owoc wrote:
> gpio16 will only be used for LCD support, as its NAND/LCDC data[8]
> so its bit 9 of the parallel QPIC interface, and ONFI NAND is only 8
> or 16-bit with only 8-bit one being supported in our case so that pin
> is unused.
>
> It should be dropped from the default NAND pinctrl configuration
> as its unused and only needed for LCD.
Matches with downstream.
Reviewed-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
>
> Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index e5b89753aa5c..8bed34174460 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -349,7 +349,7 @@ qpic_pins: qpic-state {
> "gpio5", "gpio6", "gpio7",
> "gpio8", "gpio10", "gpio11",
> "gpio12", "gpio13", "gpio14",
> - "gpio15", "gpio16", "gpio17";
> + "gpio15", "gpio17";
> function = "qpic";
> drive-strength = <8>;
> bias-disable;
next prev parent reply other threads:[~2024-03-18 5:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 10:27 [PATCH] arm64: dts: qcom: ipq8074: Remove unused gpio from QPIC pins Paweł Owoc
2024-03-18 5:50 ` Kathiravan Thirumoorthy [this message]
2024-04-04 21:22 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e1df07d-d047-4cfe-bfdd-fb17d0daf158@quicinc.com \
--to=quic_kathirav@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frut3k7@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox