From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Rajendra Nayak <rajendra.nayak@oss.qualcomm.com>,
Pankaj Patil <pankaj.patil@oss.qualcomm.com>,
Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Cc: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Add Mahua TLMM support
Date: Fri, 2 Jan 2026 12:10:59 +0100 [thread overview]
Message-ID: <7e25da82-6a26-4ade-9247-1bb7abd5615c@kernel.org> (raw)
In-Reply-To: <20260102-pinctrl-qcom-mahua-tlmm-v1-1-0edd71af08b2@oss.qualcomm.com>
On 02/01/2026 12:07, Gopikrishna Garmidi wrote:
> Update the compatible property to accept both "qcom,glymur-tlmm" and
> "qcom,mahua-tlmm" using enum to allow proper device tree validation
> for both SoCs.
1. Why? You explained what, with a lot of redundant words. I do not find
"paid by commit line" useful. Drop all the redundancies, do not explain
what is "device tree validation". Look at other commits to learn how
this is supposed to be written.
2. Why they are not compatible? You have entire commit msg to say
something useful instead stating obvious and repeating the diff.
3. Subject: You cannot add "support" in the binding. Again, look at
other commits.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-02 11:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 11:07 [PATCH 0/2] pinctrl: qcom: Add Mahua TLMM support Gopikrishna Garmidi
2026-01-02 11:07 ` [PATCH 1/2] dt-bindings: pinctrl: " Gopikrishna Garmidi
2026-01-02 11:10 ` Krzysztof Kozlowski [this message]
2026-01-02 11:11 ` Krzysztof Kozlowski
2026-01-02 11:07 ` [PATCH 2/2] pinctrl: qcom: glymur: " Gopikrishna Garmidi
2026-01-02 12:40 ` Konrad Dybcio
2026-01-05 5:34 ` Manivannan Sadhasivam
2026-01-05 15:31 ` Bjorn Andersson
2026-01-05 17:20 ` Manivannan Sadhasivam
2026-01-07 10:30 ` Konrad Dybcio
2026-01-12 7:46 ` Gopikrishna Garmidi
2026-01-12 12:26 ` Konrad Dybcio
2026-01-13 15:00 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e25da82-6a26-4ade-9247-1bb7abd5615c@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gopikrishna.garmidi@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.patil@oss.qualcomm.com \
--cc=rajendra.nayak@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox