From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH 2/3] clk: qcom: Register the gdscs before the clocks Date: Thu, 30 Nov 2017 10:26:53 +0530 Message-ID: <7ea16dd5-1564-141d-5490-7caa9c8ce977@codeaurora.org> References: <1507791529-24353-1-git-send-email-rnayak@codeaurora.org> <1507791529-24353-3-git-send-email-rnayak@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:37712 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbdK3E47 (ORCPT ); Wed, 29 Nov 2017 23:56:59 -0500 In-Reply-To: <1507791529-24353-3-git-send-email-rnayak@codeaurora.org> Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Rajendra Nayak , sboyd@codeaurora.org, mturquette@baylibre.com Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, stanimir.varbanov@linaro.org, vivek.gautam@codeaurora.org On 10/12/2017 12:28 PM, Rajendra Nayak wrote: > We have atleast some instances of ALWAYS_ON gdscs, which need to > be turned ON *before* some clocks within the gdsc domain marked > with a CLK_IS_CRITICAL can be turned ON. > To facilitate this sequence, register the GDCSs (and hence handle > the ALWAYS_ON gdscs) before we register clocks (and handle the > clocks marked as CLK_IS_CRITICAL) GDSC registration requires the reset controller to be registered before. So, the ideal sequence of registration should be: - register reset controller - register gdscs - register clocks With that: Reviewed-by: Archit Taneja > > Signed-off-by: Rajendra Nayak > --- > drivers/clk/qcom/common.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c > index d523991..d7b0b6b 100644 > --- a/drivers/clk/qcom/common.c > +++ b/drivers/clk/qcom/common.c > @@ -232,6 +232,22 @@ int qcom_cc_really_probe(struct platform_device *pdev, > size_t num_clks = desc->num_clks; > struct clk_regmap **rclks = desc->clks; > > + if (desc->gdscs && desc->num_gdscs) { > + scd = devm_kzalloc(dev, sizeof(*scd), GFP_KERNEL); > + if (!scd) > + return -ENOMEM; > + scd->dev = dev; > + scd->scs = desc->gdscs; > + scd->num = desc->num_gdscs; > + ret = gdsc_register(scd, &reset->rcdev, regmap); > + if (ret) > + return ret; > + ret = devm_add_action_or_reset(dev, qcom_cc_gdsc_unregister, > + scd); > + if (ret) > + return ret; > + } > + > cc = devm_kzalloc(dev, sizeof(*cc), GFP_KERNEL); > if (!cc) > return -ENOMEM; > @@ -276,22 +292,6 @@ int qcom_cc_really_probe(struct platform_device *pdev, > if (ret) > return ret; > > - if (desc->gdscs && desc->num_gdscs) { > - scd = devm_kzalloc(dev, sizeof(*scd), GFP_KERNEL); > - if (!scd) > - return -ENOMEM; > - scd->dev = dev; > - scd->scs = desc->gdscs; > - scd->num = desc->num_gdscs; > - ret = gdsc_register(scd, &reset->rcdev, regmap); > - if (ret) > - return ret; > - ret = devm_add_action_or_reset(dev, qcom_cc_gdsc_unregister, > - scd); > - if (ret) > - return ret; > - } > - > return 0; > } > EXPORT_SYMBOL_GPL(qcom_cc_really_probe); > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project