From: Markus Elfring <Markus.Elfring@web.de>
To: Jie Gan <quic_jiegan@quicinc.com>,
coresight@lists.linaro.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
James Clark <james.clark@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Mike Leach <mike.leach@linaro.org>, Rob Herring <robh@kernel.org>,
Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Jinlong Mao <quic_jinlmao@quicinc.com>,
Song Chai <quic_songchai@quicinc.com>,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Tao Zhang <quic_taozha@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>
Subject: Re: [PATCH v4 2/5] Coresight: Add trace_id function to retrieving the trace ID
Date: Wed, 28 Aug 2024 19:50:24 +0200 [thread overview]
Message-ID: <7eb981c3-4a5c-4173-a62a-7180acb9f299@web.de> (raw)
In-Reply-To: <20240828012706.543605-3-quic_jiegan@quicinc.com>
…
> +++ b/drivers/hwtracing/coresight/coresight-sysfs.c
> @@ -168,6 +168,7 @@ int coresight_enable_sysfs(struct coresight_device *csdev)
> int cpu, ret = 0;
> struct coresight_device *sink;
> struct list_head *path;
> + struct cs_sink_data *sink_data;
…
* How do you think about to use the attribute “__free(kfree)” at more places accordingly?
https://elixir.bootlin.com/linux/v6.11-rc5/source/include/linux/slab.h#L282
* Would you like to reduce the scope for such a local variable?
Regards,
Markus
next prev parent reply other threads:[~2024-08-28 17:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 1:27 [PATCH v4 0/5] Coresight: Add Coresight TMC Control Unit driver Jie Gan
2024-08-28 1:27 ` [PATCH v4 1/5] Coresight: Add support for new APB clock name Jie Gan
2024-08-28 1:27 ` [PATCH v4 2/5] Coresight: Add trace_id function to retrieving the trace ID Jie Gan
2024-08-28 17:50 ` Markus Elfring [this message]
2024-08-28 1:27 ` [PATCH v4 3/5] dt-bindings: arm: Add Coresight TMC Control Unit hardware Jie Gan
2024-08-28 15:12 ` Rob Herring
2024-08-29 1:22 ` JieGan
2024-08-28 1:27 ` [PATCH v4 4/5] Coresight: Add Coresight TMC Control Unit driver Jie Gan
2024-08-28 17:52 ` Markus Elfring
2024-08-28 1:27 ` [PATCH v4 5/5] arm64: dts: qcom: Add CTCU and ETR nodes for SA8775p Jie Gan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eb981c3-4a5c-4173-a62a-7180acb9f299@web.de \
--to=markus.elfring@web.de \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mike.leach@linaro.org \
--cc=quic_jiegan@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_songchai@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox