Re: [PATCH v4 2/4] platform: Add ARM64 platform directory

[Nikita Travkin <nikita@trvn.ru>]

Bryan O'Donoghue писал(а) 12.03.2024 16:36:
> On 12/03/2024 08:42, Nikita Travkin wrote:
>> Some ARM64 based laptops and computers require vendor/board specific
>> drivers for their embedded controllers. Even though usually the most
>> important functionality of those devices is implemented inside ACPI,
>> unfortunately Linux doesn't currently have great support for ACPI on
>> platforms like Qualcomm Snapdragon that are used in most ARM64 laptops
>> today. Instead Linux relies on Device Tree for Qualcomm based devices
>> and it's significantly easier to reimplement the EC functionality in
>> a dedicated driver than to make use of ACPI code.
>>
>> This commit introduces a new platform/arm64 subdirectory to give a
>> place to such drivers for EC-like devices.
>>
>> A new MAINTAINERS entry is added for this directory. Patches to files in
>> this directory will be taken up by the platform-drivers-x86 team (i.e.
>> Hans de Goede and Mark Gross).
>>
>> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
>> ---
>>   MAINTAINERS                     |  9 +++++++++
>>   drivers/platform/Kconfig        |  2 ++
>>   drivers/platform/Makefile       |  1 +
>>   drivers/platform/arm64/Kconfig  | 19 +++++++++++++++++++
>>   drivers/platform/arm64/Makefile |  6 ++++++
>>   5 files changed, 37 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b43102ca365d..ec8d706a99aa 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3050,6 +3050,15 @@ F:	drivers/mmc/host/sdhci-of-arasan.c
>>   N:	zynq
>>   N:	xilinx
>>   +ARM64 PLATFORM DRIVERS
>> +M:	Hans de Goede <hdegoede@redhat.com>
>> +M:	Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>> +L:	platform-driver-x86@vger.kernel.org
>> +S:	Maintained
>> +Q:	https://patchwork.kernel.org/project/platform-driver-x86/list/
>> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
> 
> Surely some sort of Arm specific mailing list should be added here ? platform-drivers-x86 for arm64 platform drivers standalone, makes little sense.
> 

We agreed with Hans that pdx86 list/tree can work for EC drivers for
other platforms because many maintainers familiar with ECs through x86
are already there.

> Perhaps for each new SoC class added - you could add the appropriate mailing list linux-arm-msm is suspiciously missing from the list even though the only driver that will live in this directory after this series is a qcom based device.
> 
> And if tomorrow someone added a Rockchip based EC controller then you'd assume the rockchip mailing list should get a ping.

I believe that even though those drivers are "board specific" (Hans
asked to only include EC drivers here, and we have soc/ for other things
anyway) they are not at all "platform"/"soc" specific, so I'm not sure
adding arm lists here is a great idea:

I don't think these drivers would be too specific to the SoC given it's
just an i2c peripheral most of the time, and considering that it seems
there soon will be many WoA devices with socs from many vendors, we would
just have a collection of all the arm platform lists here...

So even if for now, while all existing WoA devices use Snapdragon chips,
we could get away with adding linux-arm-msm, it may end up just spamming
all the platform lists for no reason when the list grows...

I think it's better for the contributors to CC the relevant list for
their board themselves, which is easily done implicitly by adding dts
changes along the way, like in this series.

Of course if you and other people on linux-arm-msm are fine with that
possibility, we could add an extra list there and see if it gets out of
hand.

Nikita

> 
> ---
> bod