From: Bhupesh Sharma <bhupesh.sharma@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Bhupesh Sharma <bhupesh.linux@gmail.com>,
"Gross, Andy" <agross@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 1/1] dt-bindings: mmc: sdhci-msm: Fix issues in yaml bindings
Date: Tue, 26 Jul 2022 02:02:07 +0530 [thread overview]
Message-ID: <7fa26bdc-e07e-4978-03a3-2241373f4dbc@linaro.org> (raw)
In-Reply-To: <CAL_JsqLxXLFjre9h2dyoUJ=f0+pueUhSYezx_5bZ2SdpDt29xw@mail.gmail.com>
Hi Rob,
On 7/2/22 3:36 AM, Rob Herring wrote:
> On Sat, May 14, 2022 at 4:01 PM Bhupesh Sharma
> <bhupesh.sharma@linaro.org> wrote:
>>
>> Rob pointed some remaining issues in the sdhci-msm yaml
>> bindings (via [1]).
>>
>> Fix the same by first using the 'mmc-controller.yaml' as
>> 'ref' and thereafter also fix the issues reported by
>> 'make dtbs_check' check.
>>
>> [1]. https://lore.kernel.org/linux-arm-msm/YnLmNCwNfoqZln12@robh.at.kernel.org/
>>
>> Fixes: a45537723f4b ("dt-bindings: mmc: sdhci-msm: Convert bindings to yaml")
>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Ulf Hansson <ulf.hansson@linaro.org>
>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
>> ---
>> -> This patch uses the dts changes sent (here: https://lore.kernel.org/linux-arm-msm/20220514215424.1007718-1-bhupesh.sharma@linaro.org/), for fixing the dtbs_check errors.
>> -> This patch is rebased on 'linux-next/master'
>>
>> .../devicetree/bindings/mmc/sdhci-msm.yaml | 52 ++++++++++++++++---
>> 1 file changed, 44 insertions(+), 8 deletions(-)
>
> There's another issue with this applied:
>
> Documentation/devicetree/bindings/mmc/sdhci-msm.example.dtb:
> mmc@8804000: Unevaluated properties are not allowed
> ('operating-points-v2' was unexpected)
>
> Should just need a 'operating-points-v2: true' line.
>
> This won't show up until a fix for 'unevaluatedProperties' handling is
> applied. But first I need all the issues fixed.
Sorry, I totally missed this comment. I have sent a fix for the same via
[1]. Please help review the same.
Thanks
[1].
https://lore.kernel.org/linux-arm-msm/20220725202709.2861789-1-bhupesh.sharma@linaro.org/
prev parent reply other threads:[~2022-07-25 20:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 22:01 [PATCH 1/1] dt-bindings: mmc: sdhci-msm: Fix issues in yaml bindings Bhupesh Sharma
2022-05-31 13:38 ` Ulf Hansson
2022-07-01 22:06 ` Rob Herring
2022-07-02 9:14 ` Dmitry Baryshkov
2022-07-02 15:22 ` Rob Herring
2022-07-02 15:59 ` Dmitry Baryshkov
2022-07-25 20:32 ` Bhupesh Sharma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fa26bdc-e07e-4978-03a3-2241373f4dbc@linaro.org \
--to=bhupesh.sharma@linaro.org \
--cc=agross@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).