From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C5C727E7F3 for ; Fri, 16 May 2025 19:08:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747422537; cv=none; b=pN1U61voaYq2tchHlfUzL3Y9PfPk+Ju7DGkvFKqjDPQQ6amH1YsMj8biRCAM/Fv5cive2YV5TQuUBSTM/P8ONoo/Hvvo/+K1Ix75UgH2Z9GcESMC9udUUqU11ptVNl73FxhbGtpKkuX8WI4d/z6rcid4EPnXipxHvLQdJK+XopQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747422537; c=relaxed/simple; bh=pxXpE/fZNq6yLvc52y7PdDeNl9o9v335j69UIWK1LFc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AN1Sb2gBH52EBj3ywTAc2eEp3PUtHqfWfkz5WoEtFRe6Rz7U9AtwgZqa6f0q8XEowCTJy+cq4rYOBoGYkLMJ6L5bpSq2aGxx3nowsVCcFVCy/9IB8Np1ScD5xWo9VUSprq4cH07rkTFVBLmaMVLerSeoGNVKsd3Dx0b9o7Fedzc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Rh88UX7x; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Rh88UX7x" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54GCL6W7014952 for ; Fri, 16 May 2025 19:08:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= W1EJKheOMiPM9GqihfGtt+delr480OzcwQJk/CmfpTs=; b=Rh88UX7xz+3klM2w aTUXEORusMkVUL3WJQOOb3b2/WiVDz6HndDxyIzoyosIg9PJK2r6iH6H1BqCuadA 1Fji2zptDczbA7437/kxynI4nB1ijYe1Y0XIebjYan5Wo/1/DUxCH1Fo62nLqG/R SsCBNDwHi6SUYkT1wMbs1R1k5/HwnVAe26DEVa18hh9heI513OIPktfYscrgIfyB 8MzssdGq+f/9mo81ZGjp49Av5NU8nVLmEs62umkqCfoMDdgHvLejec4yRZA+cgS6 AHOdZpAiFm5hKMlgNRsY3F5O1NcUfwsCHSoGon0To+vBlTZj9eAURzpV0sWg/n89 yG2ZRg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46nx9jtdkr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 16 May 2025 19:08:54 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-30e895056f0so963833a91.3 for ; Fri, 16 May 2025 12:08:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747422533; x=1748027333; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W1EJKheOMiPM9GqihfGtt+delr480OzcwQJk/CmfpTs=; b=PeOiYQfFOn1rhLWfMPT/n0v1NoO+lv3zfKauNd1KVv8rLW5I/FDbDRUImSje9NDH75 cAmLHwBFFsbo9WsuN0dYr1Qgwq9SkHCZkgbpAM7dzn0DEjtgzObqtRhM0ZSeMsrcBkTb xTsMQCNamD1Dks6k/Dh1UD6cC8VSu6T0OytEmrMEzUKSrXirJ/1Lzfn7T/MHmobSrTU7 p16AsJYB9eOAsbvu5INVFJL1xbqCsTE2YZuuUvyaEgaBPBYJSmJg//CF4ZpPAxsBCjI4 QHokMt3G9BgAeVzcEGU04o7pLHjJWvH9uK+mbVnjQ7ol8rSrK0qLcIL2BrF1cXOhUEjB /raQ== X-Forwarded-Encrypted: i=1; AJvYcCWgFZoqLAhwgdjgHZciqiDSknbqp2W3iZ/agnlfHl/Gz0VHMHkVjcVGTtDfuzRYai9wxSPoCyoBHInMoejo@vger.kernel.org X-Gm-Message-State: AOJu0YxwN357VtLY6nWAfzbQbfYp3dFP2rXP4+LfOKbcnfwHbyMz59qI 6pkkqs8ePN/qxQK68J8tnsn9fkTnLy0lQlYFy+XvMH14aJq9mdSDEjYHgT2zCZ+EGRViIQH35Fl Mi3XywwuAqJsOLmURNFh/iNFIuzOr7rm2NFO79CoAGP0H2JMC6GNNw0C7soD6XaAW5w58 X-Gm-Gg: ASbGncuvT5JjJIKvF51JfO7F/J7szrwsw3P6TEVSU/w7CPvDsnkj2D6zdDb9aWGDO8y 1ZFz5iAWhHo0Jgm19P4z1rZUAU0SEecNKBAHdLZGiPs3SkvvWpPgie0JrVUQeQL1QXVZYTbxZwZ 02rD1A0/zR2DLHZK7jyoaWFvImaOvFD2S+U6JCJda37R+S3k0DGVHLGDun+oz+F1EpKI2YXzVTQ mHi/lbMRvLYvrc4zb68QF4Frj9i2/9YQJPFktKSM0/onx68uaWo16OCvJXFa7mS365iww3oelzL sQLCyBSuX3Mh3WjXPO15KvDTELn2Af7l2pD43VusC6z95ehbVPN3qkX1chvKEQ== X-Received: by 2002:a17:90b:1dd1:b0:30c:5255:ffd6 with SMTP id 98e67ed59e1d1-30e7d4f4016mr6537226a91.6.1747422533663; Fri, 16 May 2025 12:08:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjCoMdR7R7xPNjV/d+MGNlVvf+FoMIYIPH77AH2OP/4hldS1ZVPlxtnh5tCoi/7JYkYDA0OQ== X-Received: by 2002:a17:90b:1dd1:b0:30c:5255:ffd6 with SMTP id 98e67ed59e1d1-30e7d4f4016mr6537202a91.6.1747422533311; Fri, 16 May 2025 12:08:53 -0700 (PDT) Received: from [10.226.59.182] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30e334fb87dsm5537527a91.47.2025.05.16.12.08.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 May 2025 12:08:52 -0700 (PDT) Message-ID: <7fa413b1-99ee-4f60-b458-cce2a2bca388@oss.qualcomm.com> Date: Fri, 16 May 2025 13:08:49 -0600 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] bus: mhi: host: don't free bhie tables during suspend/hibernation To: Muhammad Usama Anjum , Manivannan Sadhasivam , Jeff Johnson , Youssef Samir , Matthew Leung , Carl Vanderlip , Yan Zhen , Jacek Lawrynowicz , Alex Elder , Greg Kroah-Hartman , Kunwu Chan , "Dr. David Alan Gilbert" , Troy Hanson Cc: kernel@collabora.com, sebastian.reichel@collabora.com, Jeff Johnson , Baochen Qiang , Sumit Garg , mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org References: <20250516184952.878726-1-usama.anjum@collabora.com> Content-Language: en-US From: Jeff Hugo In-Reply-To: <20250516184952.878726-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 9_9BHDj0AivQS-P_mJ7CcCASO4pWFCgA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTE2MDE4OCBTYWx0ZWRfX6gCQ7NG4hOtZ yl/kCCPvMGUx3nwkobDWipl1ALKVfxw/fhKZSPDzO8M3L8YB/43JXo5n/lVX5R6yOj9mpZEyD2i YqZOmpyseeobOo/qySj+VjPSPS43soo1Vvs/Ve6Bq2rtWWCTBHfwp2ruwsb3MfwBwDFwf1htXKM /ONP20ydi3eGwmf0HtTfHHCBEy9dbSlLlwOB10aqYl0+48+V+mMHdw1cLEgo/1YFbkcZefva7x9 srBL5a/wMXA0qed0VSqc5tP1sw14MKjgK5eZuR4oKzRsoC3wHpTHnp18lOxxbZ5UqqSenkdEZid sBC7qqjjtgjv9yyO5YZJMQi+Wa/9g+WzSgoSC2B6FGWugwWXwCD/YPFqobgojwAe5KTjxEpETkI Rf1afQutOgO/U2tO4mURmI/77Zoj22YDmzBamRd6wiJutzj56AE/32dysgyYtlOT4DKgISDD X-Authority-Analysis: v=2.4 cv=CIIqXQrD c=1 sm=1 tr=0 ts=68278d46 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=QX4gbG5DAAAA:8 a=uZSOL5_7EVOPlFl7amgA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=TjNXssC_j7lpFel5tvFf:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-Proofpoint-GUID: 9_9BHDj0AivQS-P_mJ7CcCASO4pWFCgA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-16_06,2025-05-16_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 mlxlogscore=999 spamscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505070000 definitions=main-2505160188 On 5/16/2025 12:49 PM, Muhammad Usama Anjum wrote: > Fix dma_direct_alloc() failure at resume time during bhie_table > allocation because of memory pressure. There is a report where at > resume time, the memory from the dma doesn't get allocated and MHI > fails to re-initialize. > > To fix it, don't free the memory at power down during suspend / > hibernation. Instead, use the same allocated memory again after every > resume / hibernation. This patch has been tested with resume and > hibernation both. > > Optimize the rddm and fbc bhie allocations. The rddm is of constant > size for a given hardware. While the fbc_image size depends on the > firmware. If the firmware changes, we'll free and allocate new memory > for it. This patch is motivated from the ath12k [1] and ath11k [2] > patches. They don't free the memory and reuse the same memory if new > size is same. The firmware caching hasn't been implemented for the > drivers other than in the nouveau. (The changing of firmware isn't > tested/supported for wireless drivers. But let's follow the example > patches here.) > > [1] https://lore.kernel.org/all/20240419034034.2842-1-quic_bqiang@quicinc.com/ > [2] https://lore.kernel.org/all/20220506141448.10340-1-quic_akolli@quicinc.com/ > > Tested-on: WCN6855 WLAN.HSP.1.1-03926.13-QCAHSPSWPL_V2_SILICONZ_CE-2.52297.6 > Tested-on: WCN7850 hw2.0 WLAN.HMT.1.1.c5-00284-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Acked-by: Jeff Johnson > Tested-by: Baochen Qiang > Signed-off-by: Muhammad Usama Anjum I think we are in a good spot now. Reviewed-by: Jeff Hugo