From: Kevin Hilman <khilman@kernel.org>
To: Lina Iyer <lina.iyer@linaro.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
daniel.lezcano@linaro.org, galak@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com,
msivasub@codeaurora.org
Subject: Re: [PATCH v7 4/7] qcom: pm: Add cpu low power mode functions
Date: Tue, 30 Sep 2014 10:35:45 -0700 [thread overview]
Message-ID: <7h4mvp105q.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20140930160310.GC528@ilina-mac.local> (Lina Iyer's message of "Tue, 30 Sep 2014 10:03:10 -0600")
Lina Iyer <lina.iyer@linaro.org> writes:
> On Mon, Sep 29 2014 at 17:37 -0600, Stephen Boyd wrote:
>>On 09/26/14 17:58, Lina Iyer wrote:
>>> Based on work by many authors, available at codeaurora.org
>>>
>>
>>> Signed-off-by: Lina Iyer <lina.iyer@linaro.org>
>>> [lina: simplify the driver for an initial submission, add commit text
>>> description of idle states]
>>
>>Maintainer tags don't really make sense unless there is another author.
>>
> Hmm.. Since this patch is a derivative work, I wanted to clarify, what
> changed seems important. The work was done by many authors. Adding
> signed-off from everybody who could have contributed to the patch
> downstream is confusing.
> I would be okay removing it.
Yes, you should remove it, but move the "Based on work by many authors"
part to just before your signoff. Also, it's considered good manners to
name any significant contributors if there are a few standouts. Also,
the "available at codeaurora.org" is wanting a link, ideally to a
specific commit, or a branch so original code can easily be found.
Kevin
next prev parent reply other threads:[~2014-09-30 17:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 0:58 [PATCH v7 0/7] QCOM 8974 and 8084 cpuidle driver Lina Iyer
2014-09-27 0:58 ` [PATCH v7 1/7] qcom: spm: Add Subsystem Power Manager driver Lina Iyer
2014-09-27 8:07 ` Pramod Gurav
2014-09-29 10:29 ` Pramod Gurav
2014-09-29 23:19 ` Stephen Boyd
2014-09-30 16:27 ` Lina Iyer
2014-09-30 17:26 ` Kevin Hilman
2014-09-30 21:18 ` Lina Iyer
2014-09-27 0:58 ` [PATCH v7 2/7] arm: dts: qcom: Add SPM device bindings for 8974 Lina Iyer
2014-09-29 23:02 ` Stephen Boyd
2014-09-27 0:58 ` [PATCH v7 3/7] arm: dts: qcom: Add SPM device bindings for 8084 Lina Iyer
2014-09-30 17:31 ` Kevin Hilman
2014-09-27 0:58 ` [PATCH v7 4/7] qcom: pm: Add cpu low power mode functions Lina Iyer
2014-09-27 8:22 ` Pramod Gurav
2014-09-29 23:37 ` Stephen Boyd
2014-09-30 16:03 ` Lina Iyer
2014-09-30 17:35 ` Kevin Hilman [this message]
2014-10-02 0:10 ` Stephen Boyd
2014-10-02 9:50 ` Lorenzo Pieralisi
2014-10-06 17:10 ` Lina Iyer
2014-09-27 0:58 ` [PATCH v7 5/7] qcom: cpuidle: Add cpuidle driver for QCOM cpus Lina Iyer
2014-09-27 8:18 ` Pramod Gurav
2014-09-29 10:31 ` Pramod Gurav
2014-09-29 15:04 ` Lina Iyer
2014-09-29 15:31 ` Lorenzo Pieralisi
2014-09-29 16:16 ` Lina Iyer
2014-09-29 17:22 ` Lorenzo Pieralisi
2014-09-30 17:41 ` Kevin Hilman
2014-09-30 17:51 ` Nicolas Pitre
2014-09-30 18:06 ` Kevin Hilman
2014-09-30 18:30 ` Nicolas Pitre
2014-09-30 18:41 ` Kevin Hilman
2014-09-30 20:36 ` Lina Iyer
2014-09-29 23:18 ` Stephen Boyd
2014-09-30 8:58 ` Lorenzo Pieralisi
2014-09-30 15:46 ` Lina Iyer
2014-09-30 15:41 ` Lina Iyer
2014-09-27 0:58 ` [PATCH v7 6/7] arm: dts: qcom: Add idle states device nodes for 8974 Lina Iyer
2014-09-27 0:58 ` [PATCH v7 7/7] arm: dts: qcom: Add idle states device nodes for 8084 Lina Iyer
2014-09-29 12:21 ` [PATCH v7 0/7] QCOM 8974 and 8084 cpuidle driver Pramod Gurav
2014-09-29 15:05 ` Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h4mvp105q.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=galak@codeaurora.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=msivasub@codeaurora.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).