From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [RFC 1/7] thermal: qcom: tsens: Add a skeletal tsens drivers Date: Fri, 05 Jun 2015 16:49:08 -0700 Message-ID: <7hpp59zpfv.fsf@deeprootsystems.com> References: <1429796773-7151-1-git-send-email-rnayak@codeaurora.org> <1429796773-7151-2-git-send-email-rnayak@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pa0-f47.google.com ([209.85.220.47]:35723 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752562AbbFEXtM (ORCPT ); Fri, 5 Jun 2015 19:49:12 -0400 Received: by pacyx8 with SMTP id yx8so21744347pac.2 for ; Fri, 05 Jun 2015 16:49:12 -0700 (PDT) In-Reply-To: <1429796773-7151-2-git-send-email-rnayak@codeaurora.org> (Rajendra Nayak's message of "Thu, 23 Apr 2015 19:16:07 +0530") Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Rajendra Nayak Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, sboyd@codeaurora.org, srinivas.kandagatla@linaro.org, nrajan@codeaurora.org, lina.iyer@linaro.org Hi Rajendra, Rajendra Nayak writes: > tsens is qualcomms' thermal temperature sensor device. It > supports reading temperatures from multiple thermal sensors > present on various QCOM SoCs. > Calibration data is generally read from a eeprom device. > > Add a skeleton driver with all the necessary abstractions so > a variety of qcom device families which support tsens can > add driver extensions. > > Also add the required device tree bindings which can be used > to descibe the tsens device in DT. > > Signed-off-by: Rajendra Nayak [...] > + ret = tmdev->ops->calibrate(tmdev); > + if (ret < 0) { > + dev_err(&pdev->dev, "tsens calibration failed\n"); > + return ret; > + } I was trying this series on linux-next with Srini's eeprom v4 and my first attempt was to build the eeprom, qfprom and tsens drivers as built-in. Unfortunately, the tsens driver probed before the eeprom/qfprom driver so failed here with the "calibration failed" message. Building things as modules worked better, but you might want to take a look at possibly using -EPROBE_DEFER here? Kevin