From: Bart Van Assche <bvanassche@acm.org>
To: Asutosh Das <quic_asutoshd@quicinc.com>,
quic_cang@quicinc.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Cc: quic_nguyenb@quicinc.com, quic_xiaosenh@quicinc.com,
stanley.chu@mediatek.com, eddie.huang@mediatek.com,
daejun7.park@samsung.com, avri.altman@wdc.com, mani@kernel.org,
beanhuo@micron.com, quic_richardp@quicinc.com,
linux-arm-msm@vger.kernel.org,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Kiwoong Kim <kwmad.kim@samsung.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 09/17] ufs: core: mcq: Configure operation and runtime interface
Date: Thu, 27 Oct 2022 15:01:46 -0700 [thread overview]
Message-ID: <8113c37b-9917-b5f2-87c8-cb76f59c69da@acm.org> (raw)
In-Reply-To: <84a13c45fa8edc375b3342a5b9b35fc097208bab.1666288432.git.quic_asutoshd@quicinc.com>
On 10/20/22 11:03, Asutosh Das wrote:
> +/**
> + * ufshcd_mcq_config_mac - Set the #Max Activ Cmds.
> + * @hba - per adpater instance
adpater -> adapter
> + * @max_active_cmds - maximum # of active commands to the device at any time.
> + *
> + * The controller wouldn't send more than the max_active_cmds to the device at
> + * any time.
> + */
wouldn't -> won't
> +#define MCQ_CFG_n(r, i) \
> + ((r) + MCQ_QCFG_SIZE * (i))
No need to spread this macro over two lines.
Otherwise this patch looks good to me.
Bart.
next prev parent reply other threads:[~2022-10-27 22:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 18:03 [PATCH v3 00/17] Add Multi Circular Queue Support Asutosh Das
2022-10-20 18:03 ` [PATCH v3 01/17] ufs: core: Probe for ext_iid support Asutosh Das
2022-10-27 21:02 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 02/17] ufs: core: Optimize duplicate code to read extended feature Asutosh Das
2022-10-27 21:05 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 03/17] ufs: core: Introduce Multi-circular queue capability Asutosh Das
2022-10-27 21:09 ` Bart Van Assche
2022-10-28 16:51 ` Asutosh Das
2022-10-28 21:44 ` Bart Van Assche
2022-10-30 12:11 ` Avri Altman
2022-10-20 18:03 ` [PATCH v3 04/17] ufs: core: Defer adding host to scsi if mcq is supported Asutosh Das
2022-10-27 21:18 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 05/17] ufs: core: mcq: Introduce Multi Circular Queue Asutosh Das
2022-10-27 21:33 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 06/17] ufs: core: mcq: Configure resource regions Asutosh Das
2022-10-26 9:14 ` Eddie Huang
2022-10-20 18:03 ` [PATCH v3 07/17] ufs: core: mcq: Calculate queue depth Asutosh Das
2022-10-27 21:52 ` Bart Van Assche
2022-10-30 11:43 ` Avri Altman
2022-10-31 19:34 ` Asutosh Das
2022-10-31 19:24 ` Asutosh Das
2022-10-31 19:42 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 08/17] ufs: core: mcq: Allocate memory for mcq mode Asutosh Das
2022-10-27 21:38 ` Bart Van Assche
2022-10-30 12:28 ` Avri Altman
2022-10-31 19:39 ` Asutosh Das
2022-10-20 18:03 ` [PATCH v3 09/17] ufs: core: mcq: Configure operation and runtime interface Asutosh Das
2022-10-27 22:01 ` Bart Van Assche [this message]
2022-10-20 18:03 ` [PATCH v3 10/17] ufs: core: mcq: Use shared tags for MCQ mode Asutosh Das
2022-10-28 21:47 ` Bart Van Assche
2022-10-30 13:06 ` Avri Altman
2022-11-01 16:29 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 11/17] ufs: core: Prepare ufshcd_send_command for mcq Asutosh Das
2022-10-28 21:49 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 12/17] ufs: core: mcq: Find hardware queue to queue request Asutosh Das
2022-10-28 21:53 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 13/17] ufs: core: Prepare for completion in mcq Asutosh Das
2022-10-28 21:56 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 14/17] ufs: mcq: Add completion support of a cqe Asutosh Das
2022-10-28 22:05 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 15/17] ufs: core: mcq: Add completion support in poll Asutosh Das
2022-10-28 22:07 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 16/17] ufs: core: mcq: Enable Multi Circular Queue Asutosh Das
2022-10-28 22:07 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 17/17] ufs: qcom-host: Enable multi circular queue capability Asutosh Das
2022-10-28 22:08 ` Bart Van Assche
2022-11-01 18:47 ` Asutosh Das
2022-10-26 9:21 ` [PATCH v3 00/17] Add Multi Circular Queue Support Eddie Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8113c37b-9917-b5f2-87c8-cb76f59c69da@acm.org \
--to=bvanassche@acm.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bjorn.andersson@linaro.org \
--cc=daejun7.park@samsung.com \
--cc=eddie.huang@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kwmad.kim@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_richardp@quicinc.com \
--cc=quic_xiaosenh@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox