From mboxrd@z Thu Jan 1 00:00:00 1970 From: ablay@codeaurora.org Subject: Re: [PATCH/RFC 5/5] usb: Add support for streams alloc/dealloc to devio.c Date: Fri, 17 Jun 2011 01:55:40 -0700 (PDT) Message-ID: <8196aa784ab3686cb19581131df0be16.squirrel@www.codeaurora.org> References: <1308231068-24038-2-git-send-email-tlinder@codeaurora.org> <1308231068-24038-6-git-send-email-tlinder@codeaurora.org> <20110616162839.GY12230@legolas.emea.dhcp.ti.com> <20110616182141.GC1439@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:19456 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757271Ab1FQIzk (ORCPT ); Fri, 17 Jun 2011 04:55:40 -0400 In-Reply-To: <20110616182141.GC1439@kroah.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Greg KH Cc: Felipe Balbi , Tatyana Brokhman , linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, open list > On Thu, Jun 16, 2011 at 07:28:40PM +0300, Felipe Balbi wrote: >> On Thu, Jun 16, 2011 at 04:31:07PM +0300, Tatyana Brokhman wrote: >> > Allow user space applications such as LIBUSB, to request >> > streams alloc/dealloc from HCD that implements XHCI. >> > >> > Signed-off-by: Amit Blay >> > Signed-off-by: Tatyana Brokhman >> >> other than what Alan said, this needs major splitting. This patch is too >> big. First we need to discuss the ABI details with the guys at >> libusb-devel, then we implement. > > No, we don't break the abi, but rather, create a new one for streams, > and then we can work on adding them to libusb, which should be quite > easy when done. > > thanks, > > greg k-h > My name is Amit Blay, I'm working with Tatyana Brokhman, I originally created this patch. I want to make sure I understand the solution: We will create a new IOCTL, i.e., USBDEVFS_SUBMITURB_SS. This IOCTL will pass new URB structure, usbdevfs_urb_ss, which will hold the "legacy" URB and in addition the stream_id. libusb will be able to use the new ABI whenever SuperSpeed streams are required. Is this correct? Thanks, Amit Blay, --- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.