From: mkrishn@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: linux-arm-msm@vger.kernel.org, kalyan_t@codeaurora.org,
tanmay@codeaurora.org, abhinavk@codeaurora.org,
robdclark@gmail.com, bjorn.andersson@linaro.org,
vinod.koul@linaro.org, rnayak@codeaurora.org,
dianders@chromium.org, sibis@codeaurora.org,
khsieh@codeaurora.org
Subject: Re: [PATCH v14 3/4] dt-bindings: msm: dsi: add yaml schemas for DSI PHY bindings
Date: Fri, 26 Mar 2021 16:06:30 +0530 [thread overview]
Message-ID: <81ea21602c74d2b18e4b013dda3a3213@codeaurora.org> (raw)
In-Reply-To: <161671311714.3012082.4777798674596112311@swboyd.mtv.corp.google.com>
On 2021-03-26 04:28, Stephen Boyd wrote:
> Quoting Krishna Manikandan (2021-03-25 05:01:00)
>> diff --git
>> a/Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml
>> b/Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml
>> new file mode 100644
>> index 0000000..4a26bef
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml
>> @@ -0,0 +1,68 @@
>> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/msm/dsi-phy-10nm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Display DSI 10nm PHY
>> +
>> +maintainers:
>> + - Krishna Manikandan <mkrishn@codeaurora.org>
>> +
>> +allOf:
>> + - $ref: dsi-phy-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - const: qcom,dsi-phy-10nm
>> + - const: qcom,dsi-phy-10nm-8998
>> +
>> + reg:
>> + items:
>> + - description: dsi phy register set
>> + - description: dsi phy lane register set
>> + - description: dsi pll register set
>> +
>> + reg-names:
>> + items:
>> + - const: dsi_phy
>> + - const: dsi_phy_lane
>> + - const: dsi_pll
>> +
>> + vdds-supply:
>> + description: |
>> + Connected to DSI0_MIPI_DSI_PLL_VDDA0P9 pin for sc7180 target
>> and
>> + connected to VDDA_MIPI_DSI_0_PLL_0P9 pin for sdm845 target
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> + - vdds-supply
>> +
>> +unevaluatedProperties: false
>
> additionalProperties: false instead? This comment applies to the other
> bindings in this patch.
Hi Stephen,
We are referencing dsi-phy-common.yaml in this file. Since the
properties of dsi-phy-common.yaml are applicable to this file also, I
added unevaluatedProperties: false. If we add additionalProperties:
false instead, then the properties of dsi-phy-common.yaml will not be
applicable here and this will throw an error if we add the properties
from dsi-phy-common.yaml in the example.
I will address all other comments in the next patchset.
Thanks,
Krishna
>
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/qcom,dispcc-sdm845.h>
>> + #include <dt-bindings/clock/qcom,rpmh.h>
>> +
>> + dsi-phy@ae94400 {
>> + compatible = "qcom,dsi-phy-10nm";
>> + reg = <0x0ae94400 0x200>,
>> + <0x0ae94600 0x280>,
>> + <0x0ae94a00 0x1e0>;
>> + reg-names = "dsi_phy",
>> + "dsi_phy_lane",
>> + "dsi_pll";
>> +
>> + #clock-cells = <1>;
>> + #phy-cells = <0>;
>> +
>> + vdds-supply = <&vdda_mipi_dsi0_pll>;
>> + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
>> + <&rpmhcc RPMH_CXO_CLK>;
>> + clock-names = "iface", "ref";
>> + };
>> +...
>> diff --git
>> a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml
>> b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml
>> new file mode 100644
>> index 0000000..72a00cc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml
>> @@ -0,0 +1,66 @@
>> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/msm/dsi-phy-14nm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Display DSI 14nm PHY
>> +
>> +maintainers:
>> + - Krishna Manikandan <mkrishn@codeaurora.org>
>> +
>> +allOf:
>> + - $ref: dsi-phy-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - const: qcom,dsi-phy-14nm
>> + - const: qcom,dsi-phy-14nm-660
>> +
>> + reg:
>> + items:
>> + - description: dsi phy register set
>> + - description: dsi phy lane register set
>> + - description: dsi pll register set
>> +
>> + reg-names:
>> + items:
>> + - const: dsi_phy
>> + - const: dsi_phy_lane
>> + - const: dsi_pll
>> +
>> + vcca-supply:
>> + description: Phandle to vcca regulator device node.
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> + - vcca-supply
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/qcom,dispcc-sdm845.h>
>> + #include <dt-bindings/clock/qcom,rpmh.h>
>> +
>> + dsi-phy@ae94400 {
>> + compatible = "qcom,dsi-phy-14nm";
>> + reg = <0x0ae94400 0x200>,
>> + <0x0ae94600 0x280>,
>> + <0x0ae94a00 0x1e0>;
>> + reg-names = "dsi_phy",
>> + "dsi_phy_lane",
>> + "dsi_pll";
>> +
>> + #clock-cells = <1>;
>> + #phy-cells = <0>;
>> +
>> + vcca-supply = <&vcca_reg>;
>> + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
>> + <&rpmhcc RPMH_CXO_CLK>;
>> + clock-names = "iface", "ref";
>> + };
>> +...
>> diff --git
>> a/Documentation/devicetree/bindings/display/msm/dsi-phy-20nm.yaml
>> b/Documentation/devicetree/bindings/display/msm/dsi-phy-20nm.yaml
>> new file mode 100644
>> index 0000000..743806d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-20nm.yaml
>> @@ -0,0 +1,71 @@
>> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/msm/dsi-phy-20nm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Display DSI 20nm PHY
>> +
>> +maintainers:
>> + - Krishna Manikandan <mkrishn@codeaurora.org>
>> +
>> +allOf:
>> + - $ref: dsi-phy-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - const: qcom,dsi-phy-20nm
>> +
>> + reg:
>> + items:
>> + - description: dsi pll register set
>> + - description: dsi phy register set
>> + - description: dsi phy regulator register set
>> +
>> + reg-names:
>> + items:
>> + - const: dsi_pll
>> + - const: dsi_phy
>> + - const: dsi_phy_regulator
>> +
>> + vcca-supply:
>> + description: Phandle to vcca regulator device node.
>> +
>> + vddio-supply:
>> + description: Phandle to vdd-io regulator device node.
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> + - vddio-supply
>> + - vcca-supply
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/qcom,dispcc-sdm845.h>
>> + #include <dt-bindings/clock/qcom,rpmh.h>
>> +
>> + dsi-phy@fd922a00 {
>> + compatible = "qcom,dsi-phy-20nm";
>> + reg = <0xfd922a00 0xd4>,
>> + <0xfd922b00 0x2b0>,
>> + <0xfd922d80 0x7b>;
>> + reg-names = "dsi_pll",
>> + "dsi_phy",
>> + "dsi_phy_regulator";
>> +
>> + #clock-cells = <1>;
>> + #phy-cells = <0>;
>> +
>> + vcca-supply = <&vcca_reg>;
>> + vddio-supply = <&vddio_reg>;
>> +
>> + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
>> + <&rpmhcc RPMH_CXO_CLK>;
>> + clock-names = "iface", "ref";
>> + };
>> +...
>> diff --git
>> a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>> b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>> new file mode 100644
>> index 0000000..78f6b16
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>> @@ -0,0 +1,68 @@
>> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/msm/dsi-phy-28nm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Display DSI 28nm PHY
>> +
>> +maintainers:
>> + - Krishna Manikandan <mkrishn@codeaurora.org>
>> +
>> +allOf:
>> + - $ref: dsi-phy-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - const: qcom,dsi-phy-28nm-hpm
>> + - const: qcom,dsi-phy-28nm-lp
>> + - const: qcom,dsi-phy-28nm-8960
>> +
>> + reg:
>> + items:
>> + - description: dsi pll register set
>> + - description: dsi phy register set
>> + - description: dsi phy regulator register set
>> +
>> + reg-names:
>> + items:
>> + - const: dsi_pll
>> + - const: dsi_phy
>> + - const: dsi_phy_regulator
>> +
>> + vddio-supply:
>> + description: Phandle to vdd-io regulator device node.
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> + - vddio-supply
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/qcom,dispcc-sdm845.h>
>> + #include <dt-bindings/clock/qcom,rpmh.h>
>> +
>> + dsi-phy@fd922a00 {
>> + compatible = "qcom,dsi-phy-28nm";
>> + reg = <0xfd922a00 0xd4>,
>> + <0xfd922b00 0x2b0>,
>> + <0xfd922d80 0x7b>;
>> + reg-names = "dsi_pll",
>> + "dsi_phy",
>> + "dsi_phy_regulator";
>> +
>> + #clock-cells = <1>;
>> + #phy-cells = <0>;
>> +
>> + vddio-supply = <&vddio_reg>;
>> +
>> + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
>> + <&rpmhcc RPMH_CXO_CLK>;
>> + clock-names = "iface", "ref";
>> + };
>> +...
>> diff --git
>> a/Documentation/devicetree/bindings/display/msm/dsi-phy-common.yaml
>> b/Documentation/devicetree/bindings/display/msm/dsi-phy-common.yaml
>> new file mode 100644
>> index 0000000..c81399f
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/display/msm/dsi-phy-common.yaml
>> @@ -0,0 +1,41 @@
>> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/msm/dsi-phy-common.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Description of Qualcomm Display DSI PHY common dt properties
>> +
>> +maintainers:
>> + - Krishna Manikandan <mkrishn@codeaurora.org>
>> +
>> +description: |
>> + This defines the DSI PHY dt properties which are common for all
>> + dsi phy versions.
>> +
>> +properties:
>> + "#clock-cells":
>> + const: 1
>> +
>> + "#phy-cells":
>> + const: 0
>> +
>> + power-domains:
>> + maxItems: 1
>> +
>> + clocks:
>> + items:
>> + - description: Display AHB clock
>> + - description: Board XO source
>> +
>> + clock-names:
>> + items:
>> + - const: iface
>> + - const: ref
>> +
>> +required:
>> + - clocks
>> + - clock-names
>
> Why isn't #phy-cells and #clock-cells always required? I would guess
> power-domains may also always be required.
>
>> +
>> +additionalProperties: true
>> +...
next prev parent reply other threads:[~2021-03-26 10:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 12:00 [PATCH v14 1/4] dt-bindings: msm: disp: add yaml schemas for DPU bindings Krishna Manikandan
2021-03-25 12:00 ` [PATCH v14 2/4] dt-bindings: msm: dsi: add yaml schemas for DSI bindings Krishna Manikandan
2021-03-25 13:27 ` Dmitry Baryshkov
2021-03-25 22:28 ` Stephen Boyd
2021-03-25 22:48 ` Stephen Boyd
2021-03-25 12:01 ` [PATCH v14 3/4] dt-bindings: msm: dsi: add yaml schemas for DSI PHY bindings Krishna Manikandan
2021-03-25 22:58 ` Stephen Boyd
2021-03-26 10:36 ` mkrishn [this message]
2021-03-29 3:19 ` Stephen Boyd
2021-03-30 9:22 ` mkrishn
2021-03-30 19:17 ` Stephen Boyd
2021-03-30 19:42 ` Rob Herring
2021-03-31 4:02 ` mkrishn
2021-03-25 12:01 ` [PATCH v14 4/4] dt-bindings: msm/dp: Add bindings of MSM DisplayPort controller Krishna Manikandan
2021-03-25 23:10 ` Stephen Boyd
2021-03-25 22:45 ` [PATCH v14 1/4] dt-bindings: msm: disp: add yaml schemas for DPU bindings Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81ea21602c74d2b18e4b013dda3a3213@codeaurora.org \
--to=mkrishn@codeaurora.org \
--cc=abhinavk@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=kalyan_t@codeaurora.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=sibis@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=tanmay@codeaurora.org \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox