From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB8FD31770B; Mon, 29 Dec 2025 07:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766993049; cv=none; b=C+hTVGH0KtSOqj0bTSgproeS2InBEC9US8KoRdCumWTCgN8Ji/UzQzc9SSHVGYCmNPda+HhZ+V/vXFvd0KqWq+qfK1PhDu/oGD6JD4RgM2yv9ZXXx6hZ5T6vlrxH1DuHdx3B0hivieBFYZ49yC3cOc7ZLn3cEuN0d5chtll+7X4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766993049; c=relaxed/simple; bh=+tdCpRj8osX1FlMe16CEO5gvakw+XTaV+BWAlaWaJCw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SgChshLx7bkctfXMgxaGtR1oaZdHmFG7w2UTqLxNa5qW3noA6wzJY8O7ZUmvQoVC+I6zbHiCChB1ecw2xU0k+4aOgJpcQIg61kxIKf6mvkqjJV5xGUyWfOeDuLbZIwD+gf5iepHpOgGpGGrgHGIOX1/x/YlusG5axs0gPxZJSbs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BiM82rFJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BiM82rFJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2503C4CEF7; Mon, 29 Dec 2025 07:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766993045; bh=+tdCpRj8osX1FlMe16CEO5gvakw+XTaV+BWAlaWaJCw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BiM82rFJWh+d5G+g7fCxEzjTRz0rAd7so+8bFVS2luT51DEjM7qVwyV16Uzrr/VlD 0JJKDu4uLzoqytQ78qPkNfTWHAG77Ba3lC0KL/kWFWGQvUB3ppDnK0KXaMSxQuSSAY f7+2QM3AxsTRlTNLE+nQ0gm1njzp9I0CjQp0TNkpqEE6aNy2+YneU0kZK5gTlKch8O fKQQoXzKaI9nLAz2qrLSG3kiiBxV2nzsC7CyddvrgXP+SvY3K9B1kz7XlqIMTk0fTh VhuMMOinkbFUW9JlkW7DSZj5AWmk7LrY6eOKSOIbRdIadzgAe/M5KbxTHszlesJnuz +l3OR0+MQbbQw== Message-ID: <8288af85-13da-46e3-8d89-71995fbd17f8@kernel.org> Date: Mon, 29 Dec 2025 08:23:56 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: display/msm/gpu: Narrow reg and reg-names for Adreno 610.0 and alike To: rob.clark@oss.qualcomm.com Cc: Krzysztof Kozlowski , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251227110504.36732-3-krzysztof.kozlowski@oss.qualcomm.com> <2a35d31a-1a3e-4cd4-ac3a-27104ff12801@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 28/12/2025 15:59, Rob Clark wrote: > On Sat, Dec 27, 2025 at 11:56 PM Krzysztof Kozlowski wrote: >> >> On 27/12/2025 23:01, Rob Clark wrote: >>> On Sat, Dec 27, 2025 at 3:05 AM Krzysztof Kozlowski >>> wrote: >>>> >>>> DTS files for qcom,adreno-610.0 and qcom,adreno-07000200 contain only one >>>> "reg" entry, not two, and the binding defines the second entry in >>>> "reg-names" differently than top-level part, so just simplify it and >>>> narrow to only one entry. >>> >>> I'll defer to Akhil about whether this is actually needed (vs just >>> incomplete gpu devcoredump support for certain GPUs). In general >>> cx_dbgc is needed to capture state for gpu devcoredump state >>> snapshots, but not directly used in normal operations. It seems >>> similar to the situation with mapping gpucc as part of gmu, ie. not >>> something the CPU normally deals with directly, but necessary to >>> capture crash state. >> >> I don't get why binding was added with cx_dbgc, but DTS not. Neither >> binding nor DTS depends on actual usage, so I assume someone >> intentionally did not want DTS to contain cx_dbgc and binding should >> follow. Otherwise we should make the DTS complete and make the binding >> strict (leading to warnings if DTS is not updated). > > I'm not sure about the history.. but I can say that cx_dbgc is only > used for gpu state snapshot / devcoredump. So it would be easy to not > notice if it were missing. > > We have a similar slightly ugly thing where gpucc is included in the > gmu map.. only for devcoredump. Maybe we need a different way to > handle these things that are only mapped for state capture? No. Either hardware has it or not. If hardware has it, then both DTS and binding should have it. If people decided that DTS should not have it (for whatever reason), then apparently that's the desired hardware description and let's remove it from the binding to match the ABI. Best regards, Krzysztof