From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>,
manivannan.sadhasivam@linaro.org, alim.akhtar@samsung.com,
avri.altman@wdc.com, bvanassche@acm.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, agross@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_narepall@quicinc.com, quic_nitirawa@quicinc.com
Subject: Re: [PATCH V1 1/3] dt-bindings: ufs: qcom: Document ice configuration table
Date: Sun, 6 Oct 2024 10:31:23 +0200 [thread overview]
Message-ID: <834100a0-ffc3-4206-9fc1-50f1dbd2d57f@kernel.org> (raw)
In-Reply-To: <20241005064307.18972-2-quic_rdwivedi@quicinc.com>
On 05/10/2024 08:43, Ram Kumar Dwivedi wrote:
> There are three algorithms supported for inline crypto engine:
> Floor based, Static and Instantaneous algorithm.
>
> Document the compatible used for the algorithm configurations
> for inline crypto engine found.
>
> Co-developed-by: Naveen Kumar Goud Arepalli <quic_narepall@quicinc.com>
> Signed-off-by: Naveen Kumar Goud Arepalli <quic_narepall@quicinc.com>
> Co-developed-by: Nitin Rawat <quic_nitirawa@quicinc.com>
> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
Three people developed the code, but none of them cared to test it? Or
make it even slightly correct?
Sorry, this code is not ready for upstream. Please work internally on
doing meaningful review and basic tests BEFORE posting.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-06 8:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 6:43 [PATCH V1 0/3] Add support for multiple ICE algorithms Ram Kumar Dwivedi
2024-10-05 6:43 ` [PATCH V1 1/3] dt-bindings: ufs: qcom: Document ice configuration table Ram Kumar Dwivedi
2024-10-05 14:24 ` Rob Herring (Arm)
2024-10-29 10:55 ` Ram Kumar Dwivedi
2024-10-05 14:37 ` Rob Herring
2024-10-05 19:15 ` Eric Biggers
2024-10-29 11:08 ` Ram Kumar Dwivedi
2024-10-06 8:31 ` Krzysztof Kozlowski [this message]
2024-10-05 6:43 ` [PATCH V1 2/3] arm64: dts: qcom: sm8650: Add ICE algorithm entries Ram Kumar Dwivedi
2024-10-06 8:32 ` Krzysztof Kozlowski
2024-10-29 11:06 ` Ram Kumar Dwivedi
2024-10-29 11:23 ` Krzysztof Kozlowski
2024-10-05 6:43 ` [PATCH V1 3/3] scsi: ufs: qcom: Add support for multiple ICE algorithms Ram Kumar Dwivedi
2024-10-05 19:33 ` Christophe JAILLET
2024-10-29 11:10 ` Ram Kumar Dwivedi
2024-10-06 7:14 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834100a0-ffc3-4206-9fc1-50f1dbd2d57f@kernel.org \
--to=krzk@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_rdwivedi@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).