From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E76D523958A for ; Tue, 30 Sep 2025 02:54:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759200897; cv=none; b=F/+Ol9u0+JrjMBipkNfKm3UVrfAjumlMGEWLkQaoUGjb8ZdLH/ZuO0QpIz6j/BiC/NqAoCZekiK4wucelVyWtY3yNiWxbeYfUHdKWzDRVK70CRW2X0xR3jfX+vEb5cstkVfUzUwgl3QYhAfHS3fD/nMezsgb/fU+8R+mlo+yvHQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759200897; c=relaxed/simple; bh=w4MY4M0ZoWU1y5jjPtE+5dfTzqCRPe+p6fmHLn2iO4w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=afkMnwS2W/iqpToSDcnw+blWGTqjJjlZsPp1YQlCqqQXkFJ9bl4iNNYyTQpstyFw0k6CDW4BH5H+X/S3D1u26X7w7TF6H9Q72P+AnqYrW4+XVEWdSl9jk1l/h1cOGNxlsG4Kj6ctrCOI9tY7RVCWRY9CChMykF/X6PJdAJ/zPJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CYX7aIA7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CYX7aIA7" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58TIFgpE012385 for ; Tue, 30 Sep 2025 02:54:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lW15lYOriH+/8boh668aZ4x5LRiCcst0TEYI2Bbz8sk=; b=CYX7aIA7cEvgX+vS NYpmcconCCmJvM6Kdt1N4r3VIh8NdkFHSh1ugUCyLpDAdFsDwmjDZA5up43LjZy3 ED+T6/8cyg4F0d7C6kNwp7xTiIf5KBKdx3XS2/5pxJSRkLziLYcbBJuzieUY9v8Y mTqLEjCWXSRgrhFZUlOi3zx93xxbnW12SNrkrc5Eld6dDKF1I67+ph8OXossGX5d wRC2tcJ54fJ3D9hsZdaTxFax4eDhu4Q92WHEPGO8K6VA92mL7LSVxrY4j3OAn2tx iU43TEs6fLKLQitt0gQnRZm3OcZN7Q2/lMK87uSCSisPG/mgY9cuL8EstQXEB4FH XlBR/Q== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49e59myrqg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 30 Sep 2025 02:54:54 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-77f68c697d3so3787650b3a.1 for ; Mon, 29 Sep 2025 19:54:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759200893; x=1759805693; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lW15lYOriH+/8boh668aZ4x5LRiCcst0TEYI2Bbz8sk=; b=cArVCq7eRaVO05wfbjfVEA4xanXZg8Ug87gxHwmHMwRFiImQLGJZtDk5ZGB7aSHUKG NGcrVJzvoaKgkjECEKyOtSTUPWCHIY76yhUGQn3CiB8A6s2cE6JWbswQiDyE4fZ8Wbxh 6TCux178aeEiH5+Nyyy4/vP0MWYstL8vtxWhRQAkqIvBbqMTeyZsyMKF7xSf3kTzzijh hLgjCPUc6HUzsov9s4k5xpVLvquzY4k1Clp44JM1pSHsUnxnq0hki0ouqo4I0Xzizax9 tfyaOaCtw5ZVC3vE6ejCX4br6BI9yh8m2cq4PylJm/mcWg2k20alTFRkz1lj37Wur2ok zvmg== X-Forwarded-Encrypted: i=1; AJvYcCWccoQileK6lgPAF9IIByvcPfDRv60R1NLC+TrcG7P2GTL64mWGUU+veYvpbKllJBvv3ak6Q+1VpUJGCUnI@vger.kernel.org X-Gm-Message-State: AOJu0YyrdcclMPkj/hTyVKu1ueNB7V0h3mumjmdqHlZ4CpH/q3z5qeGZ TFDt8SJ5slAtVStI9GYeFHzytz5Kcnx6Owbr8xHpoobochpzeLD92rCFesEUm70ACmBZONh+6Jv upfm5jvaGc5pcINXNvNqQl9T5kMJG/8K3ovy9NjqaIxj+KCgdTQe1E5+/ntcALHyMzsAz X-Gm-Gg: ASbGnctGk6sjdQ/y3IwLioDb6tEDKNhtg3kBsli62ZP4w0qc6B2XSG+8Y540vzq3SXT ooVUmmX3CvyjreqlUYqLNI55kQAOOnpc7ggeWNe1+IxzRSxmYDtzqBejmjAisT14aB0Ayf2qofX XNr+inVLxMPiizKE4ZjlqMxDlTWiX1v0pkUl7eVK6YvQU/Jzo6NCXmSpNWUCPJbl7BVtNOdCJam UKojuf3BRpIBXh/b8njNd8wh6OVZijKhQtwnK3s7n5tIhAlUHpXB2y+BrZfQ1ZhjrKju5PWC9c0 mIPIefRNVHzyWS2t7A55oQKadymaVcbLacTCnTTQj6XDt9AEjeMzKok+QuMGwsl//XHJhgrLZI1 rUvyl1d+vdaUz2W8rxt5akkQiTSkYdVQ+Nk01erHQ X-Received: by 2002:a05:6a00:1a86:b0:781:2531:7002 with SMTP id d2e1a72fcca58-78125317087mr12518155b3a.27.1759200893538; Mon, 29 Sep 2025 19:54:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEdKwOgMfiVkqYcB9C/XChUPLUfqbWJlZyrazoYFKdlPfuRBeuKh2AS0CtUVaJFGFf6+d+Itg== X-Received: by 2002:a05:6a00:1a86:b0:781:2531:7002 with SMTP id d2e1a72fcca58-78125317087mr12518131b3a.27.1759200893071; Mon, 29 Sep 2025 19:54:53 -0700 (PDT) Received: from [10.133.33.234] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7840f54b0a2sm4930664b3a.46.2025.09.29.19.54.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Sep 2025 19:54:52 -0700 (PDT) Message-ID: <838d6de3-80df-4cfb-a9d2-6ae667aee254@oss.qualcomm.com> Date: Tue, 30 Sep 2025 10:54:46 +0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali ADSP To: Dmitry Baryshkov Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com References: <20250924-knp-remoteproc-v1-0-611bf7be8329@oss.qualcomm.com> <20250924-knp-remoteproc-v1-1-611bf7be8329@oss.qualcomm.com> <4a25e085-39f8-49dc-85c6-7a4267689dd1@oss.qualcomm.com> <0209a062-2763-4e50-adfa-3cbdbb35eaef@oss.qualcomm.com> Content-Language: en-US From: Jingyi Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: hoqvqM-BsVF2sj2Ek21eYGdfNSPH9cc9 X-Authority-Analysis: v=2.4 cv=O4g0fR9W c=1 sm=1 tr=0 ts=68db467e cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=jyhGSXCUmUVbAOAwL-cA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: hoqvqM-BsVF2sj2Ek21eYGdfNSPH9cc9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI3MDAwMSBTYWx0ZWRfX1w9a+3C/IssA tFnMHpq0DO544FsfZogE/gA3VXTm92oTV/SLb6YJ2PbBg5rHmVnLTSDY06dtWKYGFX7+u2W9kjn cMYk/yoYfpUYlqAGnMneWIrBQBtmwwpCABkmWf0rasuqAykA5/xyChDYcUEZHy/c0xfXGJUlN+x yu7JTZeFAs84sghRPAckbaUwLOUYGRCZGvK7YDxMH2l2RlvSP3XtF7aSANa6AfFYxjfpQzes8af 7jcrnlcN32BVAfZba0adJjiAZvfgTl/QuC6XbGjoSU4uW61qKnJzZBIXQzSaABHo8kIa+IYYNoL m3MdSTPt9E3nhSqkHaxaBWAQImMVmO3vD/hktoF1oD8NBUD+iEGsWIG4/jIyVyS054D4QR72TxO +AztGaoHTl2ol3fTEL7bJFfs8XS7XQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-29_08,2025-09-29_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509270001 On 9/30/2025 10:16 AM, Dmitry Baryshkov wrote: > On Tue, Sep 30, 2025 at 10:12:27AM +0800, Jingyi Wang wrote: >> >> >> On 9/29/2025 8:22 PM, Dmitry Baryshkov wrote: >>> On Mon, Sep 29, 2025 at 06:11:23PM +0800, Jingyi Wang wrote: >>>> >>>> >>>> On 9/29/2025 5:39 PM, Dmitry Baryshkov wrote: >>>>> On Mon, Sep 29, 2025 at 02:06:11PM +0800, Jingyi Wang wrote: >>>>>> >>>>>> >>>>>> On 9/25/2025 10:19 AM, Dmitry Baryshkov wrote: >>>>>>> On Wed, Sep 24, 2025 at 04:37:22PM -0700, Jingyi Wang wrote: >>>>>>>> Document compatible for Qualcomm Kaanapali SoC ADSP PAS which looks fully >>>>>>>> compatible with SM8750, which can fallback to SM8550 except for one more >>>>>>>> interrupt ("shutdown-ack"). >>>>>>>> >>>>>>>> Signed-off-by: Jingyi Wang >>>>>>>> --- >>>>>>>> Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 6 +++++- >>>>>>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>>>>>> >>>>>>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>>>>> index 2dd479cf4821..be9e2a0bc060 100644 >>>>>>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>>>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>>>>> @@ -28,7 +28,9 @@ properties: >>>>>>>> - qcom,x1e80100-adsp-pas >>>>>>>> - qcom,x1e80100-cdsp-pas >>>>>>>> - items: >>>>>>>> - - const: qcom,sm8750-adsp-pas >>>>>>>> + - enum: >>>>>>>> + - qcom,kaanapali-adsp-pas >>>>>>>> + - qcom,sm8750-adsp-pas >>>>>>>> - const: qcom,sm8550-adsp-pas >>>>>>>> - items: >>>>>>>> - const: qcom,sm8750-cdsp-pas >>>>>>>> @@ -95,6 +97,7 @@ allOf: >>>>>>>> compatible: >>>>>>>> contains: >>>>>>>> enum: >>>>>>>> + - qcom,kaanapali-adsp-pas >>>>>>> >>>>>>> This one and the next entry are redundant. Do you see why? >>>>>>> >>>>>> >>>>>> This one describe the interrupt: >>>>>> >>>>>> - if: >>>>>> properties: >>>>>> compatible: >>>>>> contains: >>>>> >>>>>> enum: >>>>>> - qcom,kaanapali-adsp-pas >>>>>> - qcom,sm8750-adsp-pas >>>>> >>>>> It's still redundant. Don't you see it? >>>>> >>>> >>>> sorry I didn't get your point here, could you explain more? >>> >>> For you device you have two compat strings, kaanapali and sm8750. This >>> schema block is covered by 'if compat contains sm8750', so you don't >>> need to add kaanapali to the if-case. You already hit this check thanks >>> to the fallback compat. >>> >> >> Hi Dimitry, >> >> our device contains sm8550, not sm8750. > > I should be reading the patches more carefully. I beg your pardon, > indeed, you were right. > No worries at all, appreciate for your review and clarification. Thanks, Jingyi