From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Abel Vesa <abel.vesa@linaro.org>,
Sai Prakash Ranjan <quic_saipraka@quicinc.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: sm8550: fix qup_spi0_cs node
Date: Wed, 8 Mar 2023 10:58:02 +0100 [thread overview]
Message-ID: <83a8caff-2bfa-3a82-eac3-3b4568d477ae@linaro.org> (raw)
In-Reply-To: <20230308-topic-sm8550-upstream-dt-fixups-v1-2-595b02067672@linaro.org>
On 8.03.2023 09:32, Neil Armstrong wrote:
> The node is incomplete and doesn't need a subnode, add the missing
> properties and move everything to the root of qup-spi0-cs-state node.
>
> Fixes: ffc50b2d3828 ("arm64: dts: qcom: Add base SM8550 dtsi")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index fe8b92954550..c25c68257412 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -2807,10 +2807,10 @@ qup_i2c15_data_clk: qup-i2c15-data-clk-state {
> };
>
> qup_spi0_cs: qup-spi0-cs-state {
> - cs-pins {
> - pins = "gpio31";
> - function = "qup1_se0";
> - };
> + pins = "gpio31";
> + function = "qup1_se0";
> + drive-strength = <6>;
> + bias-disable;
> };
>
> qup_spi0_data_clk: qup-spi0-data-clk-state {
>
next prev parent reply other threads:[~2023-03-08 9:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 8:32 [PATCH 0/3] arm64: dts: qcom: sm8550: various DT fixes Neil Armstrong
2023-03-08 8:32 ` [PATCH 1/3] arm64: dts: qcom: sm8550: replace 0x0 to 0 Neil Armstrong
2023-03-08 9:59 ` Konrad Dybcio
2023-03-08 10:01 ` Neil Armstrong
2023-03-08 8:32 ` [PATCH 2/3] arm64: dts: qcom: sm8550: fix qup_spi0_cs node Neil Armstrong
2023-03-08 9:58 ` Konrad Dybcio [this message]
2023-03-08 8:32 ` [PATCH 3/3] arm64: dts: qcom: sm8550: misc style fixes Neil Armstrong
2023-03-08 9:58 ` Konrad Dybcio
2023-03-16 3:20 ` (subset) [PATCH 0/3] arm64: dts: qcom: sm8550: various DT fixes Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a8caff-2bfa-3a82-eac3-3b4568d477ae@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_saipraka@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox