From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings
Date: Wed, 1 Feb 2023 16:46:44 +0100 [thread overview]
Message-ID: <844ecb2f-e398-1187-810a-4f24372bd189@linaro.org> (raw)
In-Reply-To: <20230201154321.276419-1-krzysztof.kozlowski@linaro.org>
On 1.02.2023 16:43, Krzysztof Kozlowski wrote:
> Bindings expect pins to be named with certain pattern.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Do we want a Fixes: here?
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
> Endless work... People keep sending patches without running dtbs_check
> faster than I am fixing existing warnings.
> ---
> arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> index df841230d1b7..ece1a7cb8b3b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> @@ -723,7 +723,7 @@ usb_hub_enabled_state: usb-hub-enabled-state {
> };
>
> lt9611_state: lt9611-state {
> - rst {
> + rst-pins {
> pins = "gpio48";
> function = "normal";
>
> @@ -731,7 +731,7 @@ rst {
> input-disable;
> };
>
> - irq {
> + irq-pins {
> pins = "gpio50";
> function = "gpio";
> bias-disable;
next prev parent reply other threads:[~2023-02-01 15:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 15:43 [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings Krzysztof Kozlowski
2023-02-01 15:43 ` [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: correct LT9611 pin function Krzysztof Kozlowski
2023-02-01 15:47 ` Konrad Dybcio
2023-02-02 9:36 ` Krzysztof Kozlowski
2023-02-01 15:43 ` [PATCH 3/3] dt-bindings: pinctrl: qcom,sm8350: add input-disable Krzysztof Kozlowski
2023-02-02 23:47 ` Rob Herring
2023-02-03 7:17 ` (subset) " Krzysztof Kozlowski
2023-02-01 15:46 ` Konrad Dybcio [this message]
2023-02-02 9:36 ` [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings Krzysztof Kozlowski
2023-02-09 4:23 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=844ecb2f-e398-1187-810a-4f24372bd189@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox