From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7001DC433EF for ; Thu, 16 Jun 2022 19:46:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377975AbiFPTqY (ORCPT ); Thu, 16 Jun 2022 15:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349355AbiFPTqX (ORCPT ); Thu, 16 Jun 2022 15:46:23 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E195359BA1 for ; Thu, 16 Jun 2022 12:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1655408782; x=1686944782; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=q+zfdU8CHrLB6fcOwNpYub9QfP/SQqDPjkb0NAMPTC0=; b=eB1LbX4yB25KyfiY/tq6Fa0cLIdoMCzoE8qQHP9ptXIBw70pvmkCS7gJ Tmivq4KVvIbqy5fJVCs6FSpyreMZGkiUwDE2+7UnPSlU4XEwmAeYwh6ES YVC2obpgddQf7Y+QM4Mwjd2CqWRHLvSOBlP8K2LCnI6ZKnegdXGrkXyDw c=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-02.qualcomm.com with ESMTP; 16 Jun 2022 12:46:22 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2022 12:46:22 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 16 Jun 2022 12:46:21 -0700 Received: from [10.111.175.222] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 16 Jun 2022 12:46:19 -0700 Message-ID: <84f5e432-ee63-68c2-8072-e5ae2024b4ae@quicinc.com> Date: Thu, 16 Jun 2022 12:46:17 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2 1/3] drm/msm/mdp4: convert to drm_crtc_handle_vblank() Content-Language: en-US To: Dmitry Baryshkov , Rob Clark , Sean Paul CC: Stephen Boyd , David Airlie , Daniel Vetter , Bjorn Andersson , , , References: <20220507170922.1723712-1-dmitry.baryshkov@linaro.org> From: Abhinav Kumar In-Reply-To: <20220507170922.1723712-1-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 5/7/2022 10:09 AM, Dmitry Baryshkov wrote: > Stop using deprecated drm_handle_vblank(), use drm_crtc_handle_vblank() > instead. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c > index 4d49f3ba6a96..ddcdd5e87853 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c > @@ -69,8 +69,7 @@ irqreturn_t mdp4_irq(struct msm_kms *kms) > struct mdp_kms *mdp_kms = to_mdp_kms(kms); > struct mdp4_kms *mdp4_kms = to_mdp4_kms(mdp_kms); > struct drm_device *dev = mdp4_kms->dev; > - struct msm_drm_private *priv = dev->dev_private; > - unsigned int id; > + struct drm_crtc *crtc; > uint32_t status, enable; > > enable = mdp4_read(mdp4_kms, REG_MDP4_INTR_ENABLE); > @@ -81,9 +80,9 @@ irqreturn_t mdp4_irq(struct msm_kms *kms) > > mdp_dispatch_irqs(mdp_kms, status); > > - for (id = 0; id < priv->num_crtcs; id++) > - if (status & mdp4_crtc_vblank(priv->crtcs[id])) > - drm_handle_vblank(dev, id); > + drm_for_each_crtc(crtc, dev) > + if (status & mdp4_crtc_vblank(crtc)) > + drm_crtc_handle_vblank(crtc); > > return IRQ_HANDLED; > }