Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: add IPQ5210 pinctrl

[Krzysztof Kozlowski <krzk@kernel.org>]

On 30/03/2026 06:56, Kathiravan Thirumoorthy wrote:
> 
> On 3/26/2026 1:55 PM, Krzysztof Kozlowski wrote:
>> On Wed, Mar 25, 2026 at 01:05:15PM +0530, Kathiravan Thirumoorthy wrote:
>>> Add device tree bindings for IPQ5210 TLMM block.
>>>
>>> Signed-off-by: Kathiravan Thirumoorthy<kathiravan.thirumoorthy@oss.qualcomm.com>
>> I don't see any differences here and cover letter does not explain that.
> 
> Pin control function names are made generic for some of the functions, 
> so I thought I should drop it and mentioned it in the cover letter as below.
> 
> Changes in v3:
> - Grouped the QUP SE pins instead of mentioning by function wise
> - Splitted the PWM functions which I messed up in V2
> - Audio primary and secondary mclk function names are expanded to avoid the
>    confusion
> - Dropped the R-b tags due to the above changes
> 
> Based on your comment, I understand that since there is no schematic 
> changes to the binding, there is no need to drop the tag. So I have 
> picked up the tags in V4.

So you dropped the tags because something changed in the "function"
property? Why would that matter for review?

I am not looking at this again.

Best regards,
Krzysztof