From: Chris Lew <clew@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <andy.gross@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>
Cc: Arun Kumar Neelakantam <aneela@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v2 2/5] soc: qcom: Introduce QMI helpers
Date: Wed, 8 Nov 2017 13:40:29 -0800 [thread overview]
Message-ID: <858b59b9-6bff-6ed9-fd25-e35cbeec8aec@codeaurora.org> (raw)
In-Reply-To: <20171107052042.22569-3-bjorn.andersson@linaro.org>
Hi Bjorn,
Found a minor typo.
On 11/6/2017 9:20 PM, Bjorn Andersson wrote:
[..]
> +ssize_t qmi_send_indication(struct qmi_handle *qmi, struct sockaddr_qrtr *sq,
> + int msg_id, size_t len, struct qmi_elem_info *ei,
> + const void *c_struct)
> +{
> + struct qmi_txn txn;
> + ssize_t rval;
> + int ret;
> +
> + ret = qmi_txn_init(qmi, &txn, NULL, NULL);
> + if (ret < 0)
> + return ret;;
Double semi colon on ret.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-11-08 21:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 5:20 [PATCH v2 0/5] In-kernel QMI helpers and sysmon Bjorn Andersson
2017-11-07 5:20 ` [PATCH v2 1/5] soc: qcom: Introduce QMI encoder/decoder Bjorn Andersson
2017-11-07 5:20 ` [PATCH v2 2/5] soc: qcom: Introduce QMI helpers Bjorn Andersson
2017-11-07 16:27 ` Arun Kumar Neelakantam
2017-11-07 19:18 ` Bjorn Andersson
2017-11-08 21:40 ` Chris Lew [this message]
2017-11-07 5:20 ` [PATCH v2 3/5] remoteproc: Pass type of shutdown to subdev remove Bjorn Andersson
2017-11-07 5:20 ` [PATCH v2 4/5] remoteproc: qcom: Introduce sysmon Bjorn Andersson
2017-11-07 5:20 ` [PATCH v2 5/5] samples: Introduce Qualcomm QMI sample client Bjorn Andersson
2017-11-07 18:40 ` Jonathan Neuschäfer
2017-11-07 19:06 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=858b59b9-6bff-6ed9-fd25-e35cbeec8aec@codeaurora.org \
--to=clew@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=aneela@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).