From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Lew Subject: Re: [PATCH v2 2/5] soc: qcom: Introduce QMI helpers Date: Wed, 8 Nov 2017 13:40:29 -0800 Message-ID: <858b59b9-6bff-6ed9-fd25-e35cbeec8aec@codeaurora.org> References: <20171107052042.22569-1-bjorn.andersson@linaro.org> <20171107052042.22569-3-bjorn.andersson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171107052042.22569-3-bjorn.andersson@linaro.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Andersson , Andy Gross , Ohad Ben-Cohen Cc: Arun Kumar Neelakantam , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-remoteproc@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org Hi Bjorn, Found a minor typo. On 11/6/2017 9:20 PM, Bjorn Andersson wrote: [..] > +ssize_t qmi_send_indication(struct qmi_handle *qmi, struct sockaddr_qrtr *sq, > + int msg_id, size_t len, struct qmi_elem_info *ei, > + const void *c_struct) > +{ > + struct qmi_txn txn; > + ssize_t rval; > + int ret; > + > + ret = qmi_txn_init(qmi, &txn, NULL, NULL); > + if (ret < 0) > + return ret;; Double semi colon on ret. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project