From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 236CFC433EF for ; Wed, 6 Apr 2022 13:53:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233923AbiDFNzq (ORCPT ); Wed, 6 Apr 2022 09:55:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233926AbiDFNzg (ORCPT ); Wed, 6 Apr 2022 09:55:36 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2FBF594A12; Wed, 6 Apr 2022 02:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1649235981; x=1680771981; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=aX+b1uqq4+PfyGSXyXG4gQ8cO/HihiWD/0mraoJeuq0=; b=RWM5aX6kTc1rZfBvEoeEJE24gEdXq7gOyEHv9VEtYtkMBaoWQLJVElhY kspb2rzc+/7ZQk35eA8MzHfewuT82IcLZUOfyyD/UlL+vUqda7yLPqvm/ oKR/ixglleSCmHsGvo3e6NCGA8UCbrdxMrgzHc6AYNzTzKTCvNkhX6bi0 w=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-02.qualcomm.com with ESMTP; 06 Apr 2022 02:06:13 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 02:06:12 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 6 Apr 2022 02:06:12 -0700 Received: from [10.216.50.162] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 6 Apr 2022 02:06:08 -0700 Subject: Re: [PATCH V9 4/6] regulator: Add a regulator driver for the PM8008 PMIC To: Mark Brown CC: Bjorn Andersson , Rob Herring , Lee Jones , Liam Girdwood , , , , , , , References: <1649166633-25872-1-git-send-email-quic_c_skakit@quicinc.com> <1649166633-25872-5-git-send-email-quic_c_skakit@quicinc.com> From: "Satya Priya Kakitapalli (Temp)" Message-ID: <85ceeb51-56d2-4e87-c67d-c203a30ecfec@quicinc.com> Date: Wed, 6 Apr 2022 14:36:04 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 4/5/2022 7:47 PM, Mark Brown wrote: > On Tue, Apr 05, 2022 at 07:20:31PM +0530, Satya Priya wrote: > >> +#include >> +#include > Why does the driver need machine.h? That's usually a bug, though I > didn't spot anywhere where it's used so it's probably just an extra > header. Yeah, I'll remove it. Thanks for spotting this. >> + .set_voltage_sel = pm8008_regulator_set_voltage, >> + .get_voltage = pm8008_regulator_get_voltage, > You shouldn't mix and match the selector and non-selector operations, > since the device just takes a voltage you may as well just use the > non-selector version for both. I was suggested to use set_voltage_sel on my previous posts. I think I'll use get_voltage_sel to avoid mixing selector and non-selector APIs. > Otherwise this all looks good, just those two minor points.